qemu-e2k/qom
Markus Armbruster ab2d185d6b qom: Plug memory leak in "info qom-tree"
Commit e8c9e65816 "qom: Make "info qom-tree" show children sorted"
created a memory leak, because I didn't realize
object_get_canonical_path_component()'s value needs to be freed.

Reproducer:

    $ qemu-system-x86_64 -nodefaults -display none -S -monitor stdio
    QEMU 5.0.50 monitor - type 'help' for more information
    (qemu) info qom-tree

This leaks some 4500 path components, 12-13 characters on average,
i.e. roughly 100kBytes depending on the allocator.  A couple of
hundred "info qom-tree" here, a couple of hundred there, and soon
enough we're talking about real memory.

Plug the leak.

Fixes: e8c9e65816
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reported-by: Reviewed-by: Li Qiang <liq3ea@gmail.com> [sent same patch]
Message-Id: <20200714160202.3121879-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
2020-07-17 10:44:23 +02:00
..
container.c qom/container: remove .instance_size initializer from container_info 2020-06-10 12:09:59 -04:00
Makefile.objs qemu-storage-daemon: Add --object option 2020-03-06 17:21:28 +01:00
object_interfaces.c qom: Introduce object_property_try_add_child() 2020-07-10 18:02:16 -04:00
object.c qom: Introduce object_property_try_add_child() 2020-07-10 18:02:16 -04:00
qom-hmp-cmds.c qom: Plug memory leak in "info qom-tree" 2020-07-17 10:44:23 +02:00
qom-qmp-cmds.c qom: Put name parameter before value / visitor parameter 2020-07-10 15:18:08 +02:00
qom-qobject.c error: Eliminate error_propagate() manually 2020-07-10 15:18:08 +02:00
trace-events