qemu-e2k/crypto
Kevin Wolf 668cb74b2a crypto: Forbid broken unloading of secrets
qcrypto_secret_prop_set_loaded() forgets to reset secret->rawdata after
unloading a secret, which will lead to a double free at some point.

Because there is no use case for unloading an already loaded secret
(apart from deleting the whole secret object) and we know that nobody
could use this because it would lead to crashes, let's just forbid the
operation instead of fixing the unloading.

Eventually, we'll want to get rid of 'loaded' in the external interface,
but for the meantime this is more consistent with rng, which has a
similar property 'opened' that also can't be reset to false after it
became true.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-01-29 17:07:53 +00:00
..
aes.c crypto: Fix some code style problems, add spaces around operator 2021-01-29 17:07:53 +00:00
afalg.c crypto: introduce some common functions for af_alg backend 2017-07-19 10:11:05 +01:00
afalgpriv.h crypto: Allocate QCryptoCipher with the subclass 2020-09-10 11:02:23 +01:00
afsplit.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
block-luks.c qapi: Use QAPI_LIST_APPEND in trivial cases 2021-01-28 08:08:45 +01:00
block-luks.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block-qcow.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block-qcow.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block.c qcrypto/core: add generic infrastructure for crypto options amendment 2020-07-06 08:49:28 +02:00
blockpriv.h qcrypto/core: add generic infrastructure for crypto options amendment 2020-07-06 08:49:28 +02:00
cipher-afalg.c crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new 2020-09-10 11:02:23 +01:00
cipher-builtin.c.inc crypto/builtin: Split QCryptoCipherBuiltin into subclasses 2020-09-10 11:02:23 +01:00
cipher-gcrypt.c.inc crypto/gcrypt: Split QCryptoCipherGcrypt into subclasses 2020-09-10 11:02:23 +01:00
cipher-nettle.c.inc crypto/nettle: Split QCryptoCipherNettle into subclasses 2020-09-10 11:02:23 +01:00
cipher.c crypto: Constify cipher data tables 2020-09-10 11:02:23 +01:00
cipherpriv.h crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new 2020-09-10 11:02:23 +01:00
desrfb.c crypto: Fix some code style problems, add spaces around operator 2021-01-29 17:07:53 +00:00
hash-afalg.c crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
hash-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash-glib.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash-nettle.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hashpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
hmac-gcrypt.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
hmac-glib.c glib: bump min required glib library version to 2.48 2019-08-22 10:46:34 +01:00
hmac-nettle.c crypto: fix function signatures for nettle 2.7 vs 3 2019-07-19 12:48:22 +01:00
hmac.c Include qapi/error.h exactly where needed 2018-02-09 13:50:17 +01:00
hmacpriv.h crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
init.c crypto: Remove use of GCRYPT_VERSION macro. 2020-06-15 11:33:51 +01:00
ivgen-essiv.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-essiv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain64.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain64.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgenpriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
meson.build crypto: Move the creation of the library to the main meson.build 2020-10-12 11:50:20 -04:00
pbkdf-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-nettle.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-stub.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
random-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
random-gnutls.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
random-none.c crypto: add "none" random provider 2020-06-15 11:33:50 +01:00
random-platform.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
secret_common.c crypto: Forbid broken unloading of secrets 2021-01-29 17:07:53 +00:00
secret_keyring.c crypto: Move USER_CREATABLE to secret_common base class 2021-01-29 17:07:53 +00:00
secret.c crypto: Move USER_CREATABLE to secret_common base class 2021-01-29 17:07:53 +00:00
tls-cipher-suites.c tls-cipher-suites: Correct instance_size 2020-09-02 07:29:25 -04:00
tlscreds.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tlscredsanon.c qom: Put name parameter before value / visitor parameter 2020-07-10 15:18:08 +02:00
tlscredspriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
tlscredspsk.c qom: Put name parameter before value / visitor parameter 2020-07-10 15:18:08 +02:00
tlscredsx509.c crypto: Fix some code style problems, add spaces around operator 2021-01-29 17:07:53 +00:00
tlssession.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
trace-events crypto: Add tls-cipher-suites object 2020-07-03 18:16:01 +02:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00
xts.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00