qemu-e2k/migration
Eric Blake 7fb1cf1606 qapi: Don't let implicit enum MAX member collide
Now that we guarantee the user doesn't have any enum values
beginning with a single underscore, we can use that for our
own purposes.  Renaming ENUM_MAX to ENUM__MAX makes it obvious
that the sentinel is generated.

This patch was mostly generated by applying a temporary patch:

|diff --git a/scripts/qapi.py b/scripts/qapi.py
|index e6d014b..b862ec9 100644
|--- a/scripts/qapi.py
|+++ b/scripts/qapi.py
|@@ -1570,6 +1570,7 @@ const char *const %(c_name)s_lookup[] = {
|     max_index = c_enum_const(name, 'MAX', prefix)
|     ret += mcgen('''
|     [%(max_index)s] = NULL,
|+// %(max_index)s
| };
| ''',
|                max_index=max_index)

then running:

$ cat qapi-{types,event}.c tests/test-qapi-types.c |
    sed -n 's,^// \(.*\)MAX,s|\1MAX|\1_MAX|g,p' > list
$ git grep -l _MAX | xargs sed -i -f list

The only things not generated are the changes in scripts/qapi.py.

Rejecting enum members named 'MAX' is now useless, and will be dropped
in the next patch.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1447836791-369-23-git-send-email-eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[Rebased to current master, commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2015-12-17 08:21:28 +01:00
..
Makefile.objs postcopy: OS support test 2015-11-10 15:00:26 +01:00
block.c block-migration: limit the memory usage 2015-11-25 15:27:28 +01:00
exec.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
fd.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
migration.c qapi: Don't let implicit enum MAX member collide 2015-12-17 08:21:28 +01:00
postcopy-ram.c Assume madvise for (no)hugepage works 2015-11-25 15:27:28 +01:00
qemu-file-buf.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-file-internal.h Split struct QEMUFile out 2014-12-16 17:47:36 +05:30
qemu-file-stdio.c coroutine: move into libqemuutil.a library 2015-10-20 14:59:04 +01:00
qemu-file-unix.c migration: Clean up use of g_poll() in socket_writev_buffer() 2015-12-03 00:03:00 +01:00
qemu-file.c Return path: Open a return path on QEMUFile for sockets 2015-11-10 14:51:49 +01:00
ram.c Fix xbzrle vs last_sent_block update 2015-12-11 12:51:27 +00:00
rdma.c migration: Make 32bit linux compile with RDMA 2015-11-12 17:52:29 +01:00
savevm.c migration: normalize locking in migration/savevm.c 2015-11-19 11:50:00 +01:00
tcp.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
unix.c Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler 2015-06-12 13:26:21 +01:00
vmstate.c vmstate: Create optional sections 2015-07-07 14:54:52 +02:00
xbzrle.c Start migrating migration code into a migration directory 2014-12-16 17:47:36 +05:30