qemu-e2k/gdbstub
Matheus Tavares Bernardino 758370052f gdbstub: only send stop-reply packets when allowed to
GDB's remote serial protocol allows stop-reply messages to be sent by
the stub either as a notification packet or as a reply to a GDB command
(provided that the cmd accepts such a response). QEMU currently does not
implement notification packets, so it should only send stop-replies
synchronously and when requested. Nevertheless, it still issues
unsolicited stop messages through gdb_vm_state_change().

Although this behavior doesn't seem to cause problems with GDB itself
(the messages are just ignored), it can impact other debuggers that
implement the GDB remote serial protocol, like hexagon-lldb. Let's
change the gdbstub to send stop messages only as a response to a
previous GDB command that accepts such a reply.

Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <a49c0897fc22a6a7827c8dfc32aef2e1d933ec6b.1683214375.git.quic_mathbern@quicinc.com>
2023-05-18 12:40:52 -07:00
..
gdbstub.c gdbstub: only send stop-reply packets when allowed to 2023-05-18 12:40:52 -07:00
internals.h gdbstub: only send stop-reply packets when allowed to 2023-05-18 12:40:52 -07:00
meson.build gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary 2023-04-04 15:56:37 +01:00
softmmu.c gdbstub: only send stop-reply packets when allowed to 2023-05-18 12:40:52 -07:00
syscalls.c gdbstub: Build syscall.c once 2023-03-07 20:44:09 +00:00
trace-events gdbstub: move chunk of softmmu functionality to own file 2023-03-07 17:06:41 +00:00
trace.h
user-target.c gdbstub: move chunks of user code into own files 2023-03-07 20:44:04 +00:00
user.c gdbstub: only send stop-reply packets when allowed to 2023-05-18 12:40:52 -07:00