David Gibson 5c4537bded spapr: Fix 2.7<->2.8 migration of PCI host bridge ... daa2369 "spapr_pci: Add a 64-bit MMIO window" subtly broke migration from qemu-2.7 to the current version. It split the device's MMIO window into two pieces for 32-bit and 64-bit MMIO. The patch included backwards compatibility code to convert the old property into the new format. However, the property value was also transferred in the migration stream and compared with a (probably unwise) VMSTATE_EQUAL. So, the "raw" value from 2.7 is compared to the new style converted value from (pre-)2.8 giving a mismatch and migration failure. Along with the actual field that caused the breakage, there are several other ill-advised VMSTATE_EQUAL()s. To fix forwards migration, we read the values in the stream into scratch variables and ignore them, instead of comparing for equality. To fix backwards migration, we populate those scratch variables in pre_save() with adjusted values to match the old behaviour. To permit the eventual possibility of removing this cruft from the stream, we only include these compatibility fields if a new 'pre-2.8-migration' property is set. We clear it on the pseries-2.8 machine type, which obviously can't be migrated backwards, but set it on earlier machine type versions. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Greg Kurz <groug@kaod.org> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>		2016-11-23 12:00:48 +11:00
..
apb.h	Clean up header guards that don't match their file name	2016-07-12 16:19:16 +02:00
gpex.h	pci: Add generic PCIe host bridge	2015-02-13 05:46:07 +00:00
pam.h	hw/i386: remove smram_update	2015-06-05 17:36:39 +02:00
ppce500.h	Clean up header guards that don't match their file name	2016-07-12 16:19:16 +02:00
q35.h	acpi: add DMAR scope definition for root IOAPIC	2016-07-20 19:30:27 +03:00
spapr.h	spapr: Fix 2.7<->2.8 migration of PCI host bridge	2016-11-23 12:00:48 +11:00