qemu-e2k/hw/vfio
Daniel P. Berrangé 772f1b3721 trace: forbid use of %m in trace event format strings
The '%m' format instructs glibc's printf()/syslog() implementation to
insert the contents of strerror(errno). Since this is a glibc extension
it should generally be avoided in QEMU due to need for portability to a
variety of platforms.

Even though vfio is Linux-only code that could otherwise use "%m", it
must still be avoided in trace-events files because several of the
backends do not use the format string and so this error information is
invisible to them.

The errno string value should be given as an explicit trace argument
instead, making it accessible to all backends. This also allows it to
work correctly with future patches that use the format string with
systemtap's simple printf code.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20190123120016.4538-4-berrange@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2019-01-24 14:16:56 +00:00
..
Makefile.objs s390x/vfio: ap: Introduce VFIO AP device 2018-10-12 11:32:18 +02:00
amd-xgbe.c vfio/platform: Make the vfio-platform device non-abstract 2018-10-15 10:52:09 -06:00
ap.c Clean up includes 2018-12-20 10:29:08 +01:00
calxeda-xgmac.c vfio/platform: Make the vfio-platform device non-abstract 2018-10-15 10:52:09 -06:00
ccw.c qemu-error: add {error, warn}_report_once_cond 2018-09-24 17:13:07 +02:00
common.c qemu/queue.h: typedef QTAILQ heads 2019-01-11 15:46:55 +01:00
display.c hw/vfio/display: add ramfb support 2018-10-15 10:52:09 -06:00
pci-quirks.c vfio: Clean up error reporting after previous commit 2018-10-19 14:51:34 +02:00
pci.c trace: forbid use of %m in trace event format strings 2019-01-24 14:16:56 +00:00
pci.h hw/vfio/display: add ramfb support 2018-10-15 10:52:09 -06:00
platform.c vfio: Clean up error reporting after previous commit 2018-10-19 14:51:34 +02:00
spapr.c vfio/spapr: Allow backing bigger guest IOMMU pages with smaller physical pages 2018-08-21 14:28:45 +10:00
trace-events trace: forbid use of %m in trace event format strings 2019-01-24 14:16:56 +00:00