Eric Blake 262a69f428 osdep.h: Prohibit disabling assert() in supported builds ... We already have several files that knowingly require assert() to work, sometimes because refactoring the code for proper error handling has not been tackled yet; there are probably other files that have a similar situation but with no comments documenting the same. In fact, we have places in migration that handle untrusted input with assertions, where disabling the assertions risks a worse security hole than the current behavior of losing the guest to SIGABRT when migration fails because of the assertion. Promote our current per-file safety-valve to instead be project-wide, and expand it to also cover glib's g_assert(). Note that we do NOT want to encourage 'assert(side-effects);' (that is a bad practice that prevents copy-and-paste of code to other projects that CAN disable assertions; plus it costs unnecessary reviewer mental cycles to remember whether a project special-cases the crippling of asserts); and we would LIKE to fix migration to not rely on asserts (but that takes a big code audit). But in the meantime, we DO want to send a message that anyone that disables assertions has to tweak code in order to compile, making it obvious that they are taking on additional risk that we are not going to support. At the same time, leave comments mentioning NDEBUG in files that we know still need to be scrubbed, so there is at least something to grep for. It would be possible to come up with some other mechanism for doing runtime checking by default, but which does not abort the program on failure, while leaving side effects in place (unlike how crippling assert() avoids even the side effects), perhaps under the name q_verify(); but it was not deemed worth the effort (developers should not have to learn a replacement when the standard C macro works just fine, and it would be a lot of churn for little gain). The patch specifically uses #error rather than #warn so that a user is forced to tweak the header to acknowledge the issue, even when not using a -Werror compilation. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-Id: <20170911211320.25385-1-eblake@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>		2017-09-19 16:20:49 +02:00
..
Makefile.objs	vhost-user-scsi: Introduce vhost-user-scsi host device	2017-06-15 11:18:40 +02:00
esp-pci.c	hw/scsi: Concentrate -drive if=scsi auto-create in one place	2017-02-21 13:17:45 +01:00
esp.c	scsi/esp: Rename the ESP macro to ESP_STATE	2017-09-19 14:09:33 +02:00
lsi53c895a.c	scsi/lsi53c895a: Remove unused lsi_mem_*() return value	2017-06-04 18:42:55 +03:00
megasas.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
mfi.h	Clean up header guards that don't match their file name	2016-07-12 16:19:16 +02:00
mpi.h	hw: Add support for LSI SAS1068 (mptsas) device	2016-02-09 15:45:26 +01:00
mptconfig.c	scsi: mptconfig: fix misuse of MPTSAS_CONFIG_PACK	2016-09-13 19:08:46 +02:00
mptendian.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
mptsas.c	osdep.h: Prohibit disabling assert() in supported builds	2017-09-19 16:20:49 +02:00
mptsas.h	mptsas: really fix migration compatibility	2016-08-03 18:44:56 +02:00
scsi-bus.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
scsi-disk.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
scsi-generic.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
spapr_vscsi.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
srp.h	spapr-vscsi: add task management	2013-09-12 08:46:21 +02:00
trace-events	trace-events: fix code style: print 0x before hex numbers	2017-08-01 12:13:07 +01:00
vhost-scsi-common.c	vhost-user-scsi: Introduce vhost-user-scsi host device	2017-06-15 11:18:40 +02:00
vhost-scsi.c	migration: Create migration/blocker.h	2017-05-17 12:04:59 +02:00
vhost-user-scsi.c	vhost-user-scsi: Introduce vhost-user-scsi host device	2017-06-15 11:18:40 +02:00
viosrp.h	hw: move private headers to hw/ subdirectories.	2013-04-08 18:13:16 +02:00
virtio-scsi-dataplane.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
virtio-scsi.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
vmw_pvscsi.c	scsi: move block/scsi.h to include/scsi/constants.h	2017-09-19 14:09:31 +02:00
vmw_pvscsi.h	scsi: VMWare PVSCSI paravirtual device implementation	2013-04-19 10:44:17 +02:00