OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
qemu-e2k/monitor
History
Markus Armbruster 6193344f93 hmp: Unbreak "change vnc" 
HMP command "change vnc" can take the password as argument, or prompt
for it:

    (qemu) change vnc password 123
    (qemu) change vnc password
    Password: ***
    (qemu)

This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET"
command", v6.0.0.

    (qemu) change vnc passwd 123
    Password: ***
    (qemu) change vnc passwd
    (qemu)

The latter passes NULL to qmp_change_vnc_password(), which is a no-no.
Looks like it puts the display into "password required, but none set"
state.

The logic error is easy to miss in review, but testing should've
caught it.

Fix the obvious way.

Fixes: cfb5387a1d
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210909081219.308065-2-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
 		2021-09-27 10:57:21 +02:00
..
hmp-cmds.c hmp: Unbreak "change vnc" 2021-09-27 10:57:21 +02:00
hmp.c monitor: allow register hmp commands 2021-07-09 18:21:33 +02:00
meson.build meson: add spice_headers dependency. 2020-10-15 11:14:40 +02:00
misc.c trace: iter init tweaks 2021-07-12 17:37:07 +01:00
monitor-internal.h monitor: Drop query-qmp-schema 'gen': false hack 2021-03-19 16:05:09 +01:00
monitor.c chardev: mark explicitly first argument as poisoned 2021-08-05 16:15:33 +04:00
qmp-cmds-control.c qapi: Implement deprecated-output=hide for QMP introspection 2021-03-19 16:05:11 +01:00
qmp-cmds.c arch_init.h: Don't include arch_init.h unnecessarily 2021-08-26 17:02:00 +01:00
qmp.c monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB 2021-05-12 17:29:11 +02:00
trace-events docs: fix references to docs/devel/tracing.rst 2021-06-02 06:51:09 +02:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00