Stefano Garzarella 8fc898ce0b block/backup: avoid integer overflow of max-workers ... QAPI generates `struct BackupPerf` where `max-workers` value is stored in an `int64_t` variable. But block_copy_async(), and the underlying code, uses an `int` parameter. At the end that variable is used to initialize `max_busy_tasks` in block/aio_task.c causing the following assertion failure if a value greater than INT_MAX(2147483647) is used: ../block/aio_task.c:63: aio_task_pool_wait_one: Assertion `pool->busy_tasks > 0' failed. Let's check that `max-workers` doesn't exceed INT_MAX and print an error in that case. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2009310 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Message-Id: <20211005161157.282396-2-sgarzare@redhat.com> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>		2021-10-05 18:56:20 +02:00
..
export	block/export/fuse.c: fix fuse-lseek on uclibc or musl	2021-09-01 14:38:08 +02:00
monitor	block/monitor: Consolidate hmp_handle_error calls to reduce redundant code	2021-09-01 12:57:31 +02:00
accounting.c
aio_task.c
amend.c
backup.c	block/backup: avoid integer overflow of max-workers	2021-10-05 18:56:20 +02:00
blkdebug.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
blklogwrites.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
blkreplay.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
blkverify.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
block-backend.c	block: introduce blk_replace_bs	2021-09-01 12:57:31 +02:00
block-copy.c	block/block-copy: block_copy_state_new(): drop extra arguments	2021-09-01 14:38:08 +02:00
block-gen.h
bochs.c	block: use int64_t instead of uint64_t in driver read handlers	2021-09-29 13:46:31 -05:00
cloop.c	block: use int64_t instead of uint64_t in driver read handlers	2021-09-29 13:46:31 -05:00
commit.c	block: use int64_t instead of uint64_t in driver read handlers	2021-09-29 13:46:31 -05:00
copy-before-write.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
copy-before-write.h	block/copy-before-write: bdrv_cbw_append(): drop unused compress arg	2021-09-01 14:03:47 +02:00
copy-on-read.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
copy-on-read.h
coroutines.h	block/nbd: reuse nbd_co_do_establish_connection() in nbd_open()	2021-06-18 12:21:22 -05:00
create.c
crypto.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
crypto.h
curl.c	block: use int64_t instead of uint64_t in driver read handlers	2021-09-29 13:46:31 -05:00
dirty-bitmap.c	iotests: Improve and rename test 291 to qemu-img-bitmap	2021-07-21 14:14:41 -05:00
dmg-bz2.c
dmg-lzfse.c
dmg.c	block: use int64_t instead of uint64_t in driver read handlers	2021-09-29 13:46:31 -05:00
dmg.h
file-posix.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
file-win32.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
filter-compress.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
gluster.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
io_uring.c	block/io_uring: resubmit when result is -EAGAIN	2021-07-29 17:14:55 +01:00
io.c	block/io: allow 64bit discard requests	2021-09-29 13:46:32 -05:00
iscsi-opts.c	modules: add block module annotations	2021-07-09 18:20:27 +02:00
iscsi.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
linux-aio.c	linux-aio: limit the batch size using aio-max-batch parameter	2021-07-21 13:47:50 +01:00
meson.build	block: rename backup-top to copy-before-write	2021-09-01 12:57:31 +02:00
mirror.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
nbd.c	block/nbd: check that received handle is valid	2021-09-29 13:46:33 -05:00
nfs.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
null.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
nvme.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
parallels-ext.c
parallels.c
parallels.h
preallocate.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
progress_meter.c	progressmeter: protect with a mutex	2021-06-25 14:24:24 +03:00
qapi-sysemu.c
qapi.c	block: use GDateTime for formatting timestamp when dumping snapshot info	2021-06-14 13:28:50 +01:00
qcow2-bitmap.c	nbd patches for 2021-03-09	2021-03-11 13:57:08 +00:00
qcow2-cache.c
qcow2-cluster.c	block: use int64_t instead of uint64_t in driver read handlers	2021-09-29 13:46:31 -05:00
qcow2-refcount.c	qcow2-refcount: check_refblocks(): add separate message for reserved	2021-09-15 18:42:38 +02:00
qcow2-snapshot.c	block: consistently use bdrv_is_read_only()	2021-06-02 14:23:20 +02:00
qcow2-threads.c
qcow2.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
qcow2.h	qcow2-refcount: check_refblocks(): add separate message for reserved	2021-09-15 18:42:38 +02:00
qcow.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
qed-check.c
qed-cluster.c
qed-l2-cache.c
qed-table.c
qed.c	block: use int64_t instead of int in driver write_zeroes handlers	2021-09-29 13:46:32 -05:00
qed.h
quorum.c	block: use int64_t instead of int in driver write_zeroes handlers	2021-09-29 13:46:32 -05:00
raw-format.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
rbd.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
replication.c	replication: Remove workaround	2021-07-20 16:11:53 +02:00
snapshot.c	block/snapshot: Clarify goto fallback behavior	2021-06-24 09:49:04 +02:00
ssh.c	util/uri: do not check argument of uri_free()	2021-07-09 12:26:05 +02:00
stream.c	stream: Don't crash when node permission is denied	2021-03-19 10:15:06 +01:00
throttle-groups.c
throttle.c	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
trace-events	block: use int64_t instead of int in driver discard handlers	2021-09-29 13:46:32 -05:00
trace.h
vdi.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
vhdx-endian.c
vhdx-log.c	block: consistently use bdrv_is_read_only()	2021-06-02 14:23:20 +02:00
vhdx.c
vhdx.h
vmdk.c	block: use int64_t instead of int in driver write_zeroes handlers	2021-09-29 13:46:32 -05:00
vpc.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
vvfat.c	block: use int64_t instead of uint64_t in driver write handlers	2021-09-29 13:46:31 -05:00
win32-aio.c
write-threshold.c	write-threshold: deal with includes	2021-05-14 16:14:10 +02:00