ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
46 lines
1.2 KiB
C
46 lines
1.2 KiB
C
#ifndef QEMU_DISAS_H
|
|
#define QEMU_DISAS_H
|
|
|
|
#include "exec/hwaddr.h"
|
|
|
|
#ifdef NEED_CPU_H
|
|
#include "cpu.h"
|
|
|
|
/* Disassemble this for me please... (debugging). */
|
|
void disas(FILE *out, void *code, unsigned long size);
|
|
void target_disas(FILE *out, CPUState *cpu, target_ulong code,
|
|
target_ulong size);
|
|
|
|
void monitor_disas(Monitor *mon, CPUState *cpu,
|
|
target_ulong pc, int nb_insn, int is_physical);
|
|
|
|
/* Look up symbol for debugging purpose. Returns "" if unknown. */
|
|
const char *lookup_symbol(target_ulong orig_addr);
|
|
#endif
|
|
|
|
struct syminfo;
|
|
struct elf32_sym;
|
|
struct elf64_sym;
|
|
|
|
#if defined(CONFIG_USER_ONLY)
|
|
typedef const char *(*lookup_symbol_t)(struct syminfo *s, target_ulong orig_addr);
|
|
#else
|
|
typedef const char *(*lookup_symbol_t)(struct syminfo *s, hwaddr orig_addr);
|
|
#endif
|
|
|
|
struct syminfo {
|
|
lookup_symbol_t lookup_symbol;
|
|
unsigned int disas_num_syms;
|
|
union {
|
|
struct elf32_sym *elf32;
|
|
struct elf64_sym *elf64;
|
|
} disas_symtab;
|
|
const char *disas_strtab;
|
|
struct syminfo *next;
|
|
};
|
|
|
|
/* Filled in by elfload.c. Simplistic, but will do for now. */
|
|
extern struct syminfo *syminfos;
|
|
|
|
#endif /* QEMU_DISAS_H */
|