bc19a0a6e4
The following QMP command leads to a crash when iothreads are used:
{ 'execute': 'device_del', 'arguments': {'id': 'data'} }
The backtrace involves the queue restart coroutine where
tgm->throttle_state is a NULL pointer because
throttle_group_unregister_tgm() has already been called:
(gdb) bt full
#0 0x00005585a7a3b378 in qemu_mutex_lock_impl (mutex=0xffffffffffffffd0, file=0x5585a7bb3d54 "block/throttle-groups.c", line=412) at util/qemu-thread-posix.c:64
err = <optimized out>
__PRETTY_FUNCTION__ = "qemu_mutex_lock_impl"
__func__ = "qemu_mutex_lock_impl"
#1 0x00005585a79be074 in throttle_group_restart_queue_entry (opaque=0x5585a9de4eb0) at block/throttle-groups.c:412
_f = <optimized out>
data = 0x5585a9de4eb0
tgm = 0x5585a9079440
ts = 0x0
tg = 0xffffffffffffff98
is_write = false
empty_queue = 255
This coroutine should not execute in the iothread after the throttle
group member has been unregistered!
The root cause is that the device_del code path schedules the restart
coroutine in the iothread while holding the AioContext lock. Therefore
the iothread cannot execute the coroutine until after device_del
releases the lock - by this time it's too late.
This patch adds a reference count to ThrottleGroupMember so we can
synchronously wait for restart coroutines to complete. Once they are
done it is safe to unregister the ThrottleGroupMember.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 20190114133257.30299-2-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
91 lines
3.2 KiB
C
91 lines
3.2 KiB
C
/*
|
|
* QEMU block throttling group infrastructure
|
|
*
|
|
* Copyright (C) Nodalink, EURL. 2014
|
|
* Copyright (C) Igalia, S.L. 2015
|
|
*
|
|
* Authors:
|
|
* Benoît Canet <benoit.canet@nodalink.com>
|
|
* Alberto Garcia <berto@igalia.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 or
|
|
* (at your option) version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef THROTTLE_GROUPS_H
|
|
#define THROTTLE_GROUPS_H
|
|
|
|
#include "qemu/throttle.h"
|
|
#include "block/block_int.h"
|
|
|
|
/* The ThrottleGroupMember structure indicates membership in a ThrottleGroup
|
|
* and holds related data.
|
|
*/
|
|
|
|
typedef struct ThrottleGroupMember {
|
|
AioContext *aio_context;
|
|
/* throttled_reqs_lock protects the CoQueues for throttled requests. */
|
|
CoMutex throttled_reqs_lock;
|
|
CoQueue throttled_reqs[2];
|
|
|
|
/* Nonzero if the I/O limits are currently being ignored; generally
|
|
* it is zero. Accessed with atomic operations.
|
|
*/
|
|
unsigned int io_limits_disabled;
|
|
|
|
/* Number of pending throttle_group_restart_queue_entry() coroutines.
|
|
* Accessed with atomic operations.
|
|
*/
|
|
unsigned int restart_pending;
|
|
|
|
/* The following fields are protected by the ThrottleGroup lock.
|
|
* See the ThrottleGroup documentation for details.
|
|
* throttle_state tells us if I/O limits are configured. */
|
|
ThrottleState *throttle_state;
|
|
ThrottleTimers throttle_timers;
|
|
unsigned pending_reqs[2];
|
|
QLIST_ENTRY(ThrottleGroupMember) round_robin;
|
|
|
|
} ThrottleGroupMember;
|
|
|
|
#define TYPE_THROTTLE_GROUP "throttle-group"
|
|
#define THROTTLE_GROUP(obj) OBJECT_CHECK(ThrottleGroup, (obj), TYPE_THROTTLE_GROUP)
|
|
|
|
const char *throttle_group_get_name(ThrottleGroupMember *tgm);
|
|
|
|
ThrottleState *throttle_group_incref(const char *name);
|
|
void throttle_group_unref(ThrottleState *ts);
|
|
|
|
void throttle_group_config(ThrottleGroupMember *tgm, ThrottleConfig *cfg);
|
|
void throttle_group_get_config(ThrottleGroupMember *tgm, ThrottleConfig *cfg);
|
|
|
|
void throttle_group_register_tgm(ThrottleGroupMember *tgm,
|
|
const char *groupname,
|
|
AioContext *ctx);
|
|
void throttle_group_unregister_tgm(ThrottleGroupMember *tgm);
|
|
void throttle_group_restart_tgm(ThrottleGroupMember *tgm);
|
|
|
|
void coroutine_fn throttle_group_co_io_limits_intercept(ThrottleGroupMember *tgm,
|
|
unsigned int bytes,
|
|
bool is_write);
|
|
void throttle_group_attach_aio_context(ThrottleGroupMember *tgm,
|
|
AioContext *new_context);
|
|
void throttle_group_detach_aio_context(ThrottleGroupMember *tgm);
|
|
/*
|
|
* throttle_group_exists() must be called under the global
|
|
* mutex.
|
|
*/
|
|
bool throttle_group_exists(const char *name);
|
|
|
|
#endif
|