7fb48c0ee1
The compiler encounters trace event format strings in generated code. Format strings are error-prone and therefore clear compiler errors are important. Use the #line directive to show the trace-events filename and line number in format string errors: https://gcc.gnu.org/onlinedocs/gcc-10.2.0/cpp/Line-Control.html For example, if the cpu_in trace event's %u is changed to %p the following error is reported: trace-events:29:18: error: format ‘%p’ expects argument of type ‘void *’, but argument 7 has type ‘unsigned int’ [-Werror=format=] Line 29 in trace-events is where cpu_in is defined. This works for any trace-events file in the QEMU source tree and the correct path is displayed. Unfortunately there does not seem to be a way to set the column, so "18" is not the right character on that line. Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20200827142915.108730-5-stefanha@redhat.com>
53 lines
1.3 KiB
Python
53 lines
1.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
"""
|
|
Syslog built-in backend.
|
|
"""
|
|
|
|
__author__ = "Paul Durrant <paul.durrant@citrix.com>"
|
|
__copyright__ = "Copyright 2016, Citrix Systems Inc."
|
|
__license__ = "GPL version 2 or (at your option) any later version"
|
|
|
|
__maintainer__ = "Stefan Hajnoczi"
|
|
__email__ = "stefanha@redhat.com"
|
|
|
|
|
|
from tracetool import out
|
|
|
|
|
|
PUBLIC = True
|
|
|
|
|
|
def generate_h_begin(events, group):
|
|
out('#include <syslog.h>',
|
|
'')
|
|
|
|
|
|
def generate_h(event, group):
|
|
argnames = ", ".join(event.args.names())
|
|
if len(event.args) > 0:
|
|
argnames = ", " + argnames
|
|
|
|
if "vcpu" in event.properties:
|
|
# already checked on the generic format code
|
|
cond = "true"
|
|
else:
|
|
cond = "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper())
|
|
|
|
out(' if (%(cond)s) {',
|
|
'#line %(event_lineno)d "%(event_filename)s"',
|
|
' syslog(LOG_INFO, "%(name)s " %(fmt)s %(argnames)s);',
|
|
'#line %(out_next_lineno)d "%(out_filename)s"',
|
|
' }',
|
|
cond=cond,
|
|
event_lineno=event.lineno,
|
|
event_filename=event.filename,
|
|
name=event.name,
|
|
fmt=event.fmt.rstrip("\n"),
|
|
argnames=argnames)
|
|
|
|
|
|
def generate_h_backend_dstate(event, group):
|
|
out(' trace_event_get_state_dynamic_by_id(%(event_id)s) || \\',
|
|
event_id="TRACE_" + event.name.upper())
|