8bdab83b34
When COLO use only one vnet_hdr_support parameter between
filter-redirector and filter-mirror(or colo-compare), COLO will crash
with segmentation fault. Back track as follow:
Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault.
0x0000555555cb200b in eth_get_l2_hdr_length (p=0x0)
at /home/tao/project/COLO/colo-qemu/include/net/eth.h:296
296 uint16_t proto = be16_to_cpu(PKT_GET_ETH_HDR(p)->h_proto);
(gdb) bt
0 0x0000555555cb200b in eth_get_l2_hdr_length (p=0x0)
at /home/tao/project/COLO/colo-qemu/include/net/eth.h:296
1 0x0000555555cb22b4 in parse_packet_early (pkt=0x555556a44840) at
net/colo.c:49
2 0x0000555555cb2b91 in is_tcp_packet (pkt=0x555556a44840) at
net/filter-rewriter.c:63
So wrong vnet_hdr_len will cause pkt->data become NULL. Add check to
raise error and add trace-events to track vnet_hdr_len.
Signed-off-by: Tao Xu <tao3.xu@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
26 lines
1.4 KiB
Plaintext
26 lines
1.4 KiB
Plaintext
# See docs/devel/tracing.rst for syntax documentation.
|
|
|
|
# announce.c
|
|
qemu_announce_self_iter(const char *id, const char *name, const char *mac, int skip) "%s:%s:%s skip: %d"
|
|
qemu_announce_timer_del(bool free_named, bool free_timer, char *id) "free named: %d free timer: %d id: %s"
|
|
|
|
# vhost-user.c
|
|
vhost_user_event(const char *chr, int event) "chr: %s got event: %d"
|
|
|
|
# colo.c
|
|
colo_proxy_main(const char *chr) ": %s"
|
|
colo_proxy_main_vnet_info(const char *sta, int size) ": %s = %d"
|
|
|
|
# colo-compare.c
|
|
colo_compare_main(const char *chr) ": %s"
|
|
colo_compare_drop_packet(const char *queue, const char *chr) ": %s: %s"
|
|
colo_compare_udp_miscompare(const char *sta, int size) ": %s = %d"
|
|
colo_compare_icmp_miscompare(const char *sta, int size) ": %s = %d"
|
|
colo_compare_ip_info(int psize, const char *sta, const char *stb, int ssize, const char *stc, const char *std) "ppkt size = %d, ip_src = %s, ip_dst = %s, spkt size = %d, ip_src = %s, ip_dst = %s"
|
|
colo_old_packet_check_found(int64_t old_time) "%" PRId64
|
|
colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int hdlen, int pdlen, int offset, int flags) "%s: seq/ack= %u/%u hdlen= %d pdlen= %d offset= %d flags=%d"
|
|
|
|
# filter-rewriter.c
|
|
colo_filter_rewriter_pkt_info(const char *func, const char *src, const char *dst, uint32_t seq, uint32_t ack, uint32_t flag) "%s: src/dst: %s/%s p: seq/ack=%u/%u flags=0x%x"
|
|
colo_filter_rewriter_conn_offset(uint32_t offset) ": offset=%u"
|