qemu-e2k/migration
Markus Armbruster 9cde9caa04 migration/rdma: Plug memory leaks in qemu_rdma_registration_stop()
qemu_rdma_registration_stop() uses the ERROR() macro to create, report
to stderr, and store an Error object.  The stored Error object is
never used, and its memory is leaked.

Even where ERROR() doesn't leak, it is ill-advised.  The whole point
of passing an Error to the caller is letting the caller handle the
error.  Error handling may report to stderr, to somewhere else, or not
at all.  Also reporting in the callee mixes up concerns that should be
kept separate.  Since I don't know what reporting to stderr is
supposed to accomplish, I'm not touching it.

Commit 2a1bc8bde7 "migration/rdma: rdma_accept_incoming_migration fix
error handling" plugged the same leak in
rdma_accept_incoming_migration().

Plug the memory leak the same way: keep the report part, delete the
store part.

The report part uses fprintf().  If it's truly an error, it should use
error_report() instead.  But I don't know, so I leave it alone, just
like commit 2a1bc8bde7 did.

Fixes: 2da776db48
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200630090351.1247703-27-armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
2020-07-02 11:54:48 +02:00
..
block-dirty-bitmap.c migration: forbid bitmap migration by generated node-name 2020-05-28 13:15:22 -05:00
block.c migration/block: rename BLOCK_SIZE macro 2020-02-28 09:25:49 +01:00
block.h
channel.c
channel.h
colo-failover.c
colo.c migration/colo.c: Move colo_notify_compares_event to the right place 2020-06-01 18:44:27 +01:00
exec.c
exec.h
fd.c
fd.h
global_state.c
Makefile.objs multifd: Add zstd compression multifd support 2020-02-28 09:25:49 +01:00
migration.c qdev: qdev_create(), qdev_try_create() are now unused, drop 2020-06-15 22:05:28 +02:00
migration.h migration/colo.c: Use event instead of semaphore 2020-06-01 18:44:27 +01:00
multifd-zlib.c multifd: Add zlib compression multifd support 2020-02-28 09:24:43 +01:00
multifd-zstd.c multifd: Add zstd compression multifd support 2020-02-28 09:25:49 +01:00
multifd.c migration: fix multifd_send_pages() next channel 2020-06-17 17:48:39 +01:00
multifd.h multifd: Add zstd compression multifd support 2020-02-28 09:25:49 +01:00
page_cache.c
page_cache.h
postcopy-ram.c core: replace getpagesize() with qemu_real_host_page_size 2019-10-26 15:38:06 +02:00
postcopy-ram.h
qemu-file-channel.c
qemu-file-channel.h
qemu-file.c osdep: Make MIN/MAX evaluate arguments only once 2020-06-26 09:39:39 -04:00
qemu-file.h
qjson.c
qjson.h
ram.c migration: fix xbzrle encoding rate calculation 2020-06-18 10:26:02 +01:00
ram.h migration/colo.c: Flush ram cache only after receiving device state 2020-06-01 18:44:27 +01:00
rdma.c migration/rdma: Plug memory leaks in qemu_rdma_registration_stop() 2020-07-02 11:54:48 +02:00
rdma.h
savevm.c accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
savevm.h migration: Optimization about wait-unplug migration state 2020-02-13 10:53:10 +01:00
socket.c
socket.h
tls.c
tls.h
trace-events migration: Support QLIST migration 2020-01-20 09:10:23 +01:00
vmstate-types.c migration: Simplify get_qlist 2020-01-29 11:28:59 +01:00
vmstate.c migration/vmstate: Remove redundant statement in vmstate_save_state_v() 2020-02-28 09:25:49 +01:00
xbzrle.c
xbzrle.h