OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
9eb840a209
qemu-e2k/hw/pci
History
Igor Mammedov 6b0969f1ec acpi: pcihp: pcie: set power on cap on parent slot 
on creation a PCIDevice has power turned on at the end of pci_qdev_realize()
however later on if PCIe slot isn't populated with any children
it's power is turned off. It's fine if native hotplug is used
as plug callback will power slot on among other things.
However when ACPI hotplug is enabled it replaces native PCIe plug
callbacks with ACPI specific ones (acpi_pcihp_device_*plug_cb) and
as result slot stays powered off. It works fine as ACPI hotplug
on guest side takes care of enumerating/initializing hotplugged
device. But when later guest is migrated, call chain introduced by]
commit d5daff7d31 (pcie: implement slot power control for pcie root ports)

   pcie_cap_slot_post_load()
       -> pcie_cap_update_power()
           -> pcie_set_power_device()
               -> pci_set_power()
                   -> pci_update_mappings()

will disable earlier initialized BARs for the hotplugged device
in powered off slot due to commit 23786d1344 (pci: implement power state)
which disables BARs if power is off.

Fix it by setting PCI_EXP_SLTCTL_PCC to PCI_EXP_SLTCTL_PWR_ON
on slot (root port/downstream port) at the time a device
hotplugged into it. As result PCI_EXP_SLTCTL_PWR_ON is migrated
to target and above call chain keeps device plugged into it
powered on.

Fixes: d5daff7d31 ("pcie: implement slot power control for pcie root ports")
Fixes: 23786d1344 ("pci: implement power state")
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2053584
Suggested-by: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <20220301151200.3507298-3-imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2022-03-06 05:08:23 -05:00
..
Kconfig kconfig: add CONFIG_MSI_NONBROKEN 2019-03-18 09:39:57 +01:00
meson.build pcie: Add support for Single Root I/O Virtualization (SR/IOV) 2022-03-06 05:08:23 -05:00
msi.c pci/msi: export msi_is_masked() 2019-02-05 10:58:33 -05:00
msix.c migration: Replace migration's JSON writer by the general one 2020-12-19 10:39:16 +01:00
pci_bridge.c pci: fix PCI resource reserve capability on BE 2021-10-20 06:18:17 -04:00
pci_host.c trace-events,pci: unify trace events format 2022-01-07 05:19:55 -05:00
pci-stub.c qapi: Extract PCI commands to 'pci.json' 2020-09-29 15:41:36 +02:00
pci.c pci: show id info when pci BDF conflict 2022-03-06 05:08:23 -05:00
pcie_aer.c pcie_aer: Don't trigger a LSI if none are defined 2022-01-07 05:19:55 -05:00
pcie_host.c Do not include exec/address-spaces.h if it's not really necessary 2021-05-02 17:24:51 +02:00
pcie_port.c pcie: rename 'native-hotplug' to 'x-native-hotplug' 2021-11-15 09:44:46 -05:00
pcie_sriov.c pcie: Add a helper to the SR/IOV API 2022-03-06 05:08:23 -05:00
pcie.c acpi: pcihp: pcie: set power on cap on parent slot 2022-03-06 05:08:23 -05:00
shpc.c pci/shpc: don't push attention button when ejecting powered-off device 2021-01-13 09:06:37 -05:00
slotid_cap.c
trace-events pcie: Add support for Single Root I/O Virtualization (SR/IOV) 2022-03-06 05:08:23 -05:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00