Markus Armbruster a58c439a2d chardev/parallel: Don't close stdin on inappropriate device ... The __linux__ version of qemu_chr_open_pp_fd() tries to claim the parport device with a PPCLAIM ioctl(). On success, it stores the file descriptor in the chardev object, and returns success. On failure, it closes the file descriptor, and returns failure. chardev_new() then passes the Chardev to object_unref(). This duly calls char_parallel_finalize(), which closes the file descriptor stored in the chardev object. Since qemu_chr_open_pp_fd() didn't store it, it's still zero, so this closes standard input. Ooopsie. To demonstate, add a unit test. With the bug above unfixed, running this test closes standard input. char_hotswap_test() happens to run next. It opens a socket, duly gets file descriptor 0, and since it tests for success with > 0 instead of >= 0, it fails. The new unit test needs to be conditional exactly like the chardev it tests. Since the condition is rather complicated, steal the solution from the serial chardev: define HAVE_CHARDEV_PARALLEL in qemu/osdep.h. This also permits simplifying chardev/meson.build a bit. The bug fix is easy enough: store the file descriptor, and leave closing it to char_parallel_finalize(). The next commit will fix char_hotswap_test()'s test for success. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-ID: <20240203080228.2766159-2-armbru@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> [Test fixed up for BSDs, indentation fixed up, commit message improved]		2024-02-14 07:44:38 +01:00
..
accel.h	accel: Declare AccelClass::cpu_common_[un]realize() handlers	2023-10-03 08:00:25 -07:00
async-teardown.h	Don't include headers already included by qemu/osdep.h	2023-02-08 07:28:05 +01:00
atomic128.h	tcg: Correct invalid mentions of 'softmmu' by 'system-mode'	2023-10-07 19:02:33 +02:00
atomic.h	qobject atomics osdep: Make a few macros more hygienic	2023-09-29 08:13:57 +02:00
base64.h
bcd.h
bitmap.h	replace TABs with spaces	2023-03-20 12:43:50 +01:00
bitops.h	qemu/bitops.h: Limit rotate amounts	2023-05-02 12:36:46 -07:00
bswap.h	bswap.h: Fix const_le64() macro	2024-01-26 12:19:35 +00:00
buffer.h
cacheflush.h
cacheinfo.h
chardev_open.h	util/char_dev: Add open_cdev()	2023-12-19 19:03:38 +01:00
clang-tsa.h	clang-tsa: Add macros for shared locks	2022-12-15 16:07:43 +01:00
co-shared-resource.h
compiler.h	meson: do not use set10	2023-10-17 15:20:53 +02:00
config-file.h	qemu-config: Make config_parse_qdict() return bool	2022-12-14 16:19:35 +01:00
coroutine_int.h
coroutine-core.h	Rename "QEMU global mutex" to "BQL" in comments and docs	2024-01-08 10:45:43 -05:00
coroutine-tls.h
coroutine.h	Rename "QEMU global mutex" to "BQL" in comments and docs	2024-01-08 10:45:43 -05:00
cpu-float.h	Clean up ill-advised or unusual header guards	2022-05-11 16:50:01 +02:00
cpuid.h	host/include/i386: Implement clmul.h	2023-09-15 13:57:00 +00:00
crc32c.h	igb: Implement Rx SCTP CSO	2023-05-23 15:20:15 +08:00
crc-ccitt.h	bulk: Do not declare function prototypes using 'extern' keyword	2023-08-31 19:47:43 +02:00
ctype.h
cutils.h	cutils: Adjust signature of parse_uint[_full]	2023-06-02 12:27:19 -05:00
datadir.h
dbus.h	Don't include headers already included by qemu/osdep.h	2023-02-08 07:28:05 +01:00
defer-call.h	util/defer-call: move defer_call() to util/	2023-10-31 15:41:42 +01:00
drm.h
envlist.h	remove unnecessary extern "C" blocks	2023-02-10 14:12:06 +01:00
error-report.h	Move error_printf_unless_qmp() with monitor unit	2022-04-21 17:09:09 +04:00
event_notifier.h
fifo8.h	util/fifo8: Introduce fifo8_peek_buf()	2024-01-10 06:58:50 +00:00
fifo32.h
filemonitor.h
futex.h
guest-random.h	util/guest-random: Clean up global variable shadowing	2023-10-06 13:27:48 +02:00
hbitmap.h	hbitmap: fix hbitmap_status() return value for first dirty bit case	2023-02-17 14:34:24 +01:00
help_option.h
help-texts.h	Update copyright dates to 2023	2023-05-30 15:50:17 +01:00
host-utils.h	host-utils: Add muldiv64_round_up	2023-09-06 11:19:33 +02:00
hw-version.h
id.h
int128.h	host/include/generic/host/atomic128: Fix compilation problem with Clang 17	2023-11-13 11:35:47 +01:00
interval-tree.h	util: Add interval-tree.c	2022-12-20 17:09:41 -08:00
iov.h	util/iov: Remove qemu_iovec_init_extended()	2023-06-05 13:11:24 +02:00
iova-tree.h	util: spelling fixes	2023-08-31 19:47:43 +02:00
jhash.h
job.h	job: remove outdated AioContext locking comments	2023-12-21 22:49:27 +01:00
keyval.h	Clean up ill-advised or unusual header guards	2022-05-11 16:50:01 +02:00
lockable.h	coroutine: Split qemu/coroutine-core.h off qemu/coroutine.h	2023-01-20 07:21:46 +01:00
log-for-trace.h	util/log: Drop return value from qemu_log	2022-04-20 10:51:11 -07:00
log.h	util/log: Add vector registers to log	2023-06-13 17:42:01 +10:00
madvise.h
main-loop.h	qemu/main-loop: rename qemu_cond_wait_iothread() to qemu_cond_wait_bql()	2024-01-08 10:45:43 -05:00
memalign.h
memfd.h
mmap-alloc.h	util/mmap-alloc: qemu_fd_getfs()	2023-04-24 11:29:00 +02:00
module.h	module: add Error arguments to module_load and module_load_qom	2022-11-06 09:48:50 +01:00
mprotect.h
notify.h
nvdimm-utils.h
option_int.h
option.h	include: add qemu/keyval.h	2022-04-21 17:03:51 +04:00
osdep.h	chardev/parallel: Don't close stdin on inappropriate device	2024-02-14 07:44:38 +01:00
path.h
plugin-event.h	include/qemu: Split out plugin-event.h	2023-03-22 15:06:57 +00:00
plugin-memory.h	plugin: Simplify struct qemu_plugin_hwaddr	2023-09-16 14:57:15 +00:00
plugin.h	plugins/loader: Clean up global variable shadowing	2023-10-06 13:27:48 +02:00
pmem.h
processor.h	qemu/processor: Remove unused 'qemu/atomic.h' header	2023-08-31 19:47:43 +02:00
progress_meter.h	coroutine: Clean up superfluous inclusion of qemu/lockable.h	2023-01-19 10:18:28 +01:00
qdist.h
qemu-plugin.h	plugins: add dllexport and dllimport to api funcs	2023-11-08 15:15:23 +00:00
qemu-print.h
qemu-progress.h
qht.h
qsp.h
qtree.h	include: Clean up includes	2024-01-30 21:20:20 +03:00
queue.h
range.h	range: Introduce range_inverse_array()	2023-11-03 09:20:31 +01:00
ratelimit.h
rcu_queue.h	remove unnecessary extern "C" blocks	2023-02-10 14:12:06 +01:00
rcu.h	bulk: Do not declare function prototypes using 'extern' keyword	2023-08-31 19:47:43 +02:00
readline.h	readline: Extract readline_add_completion_of() from monitor	2023-02-04 07:56:54 +01:00
reserved-region.h	util/reserved-region: Add new ReservedRegion helpers	2023-11-03 09:20:31 +01:00
selfmap.h	util/selfmap: Use dev_t and ino_t in MapInfo	2023-09-01 13:34:03 -07:00
seqlock.h
sockets.h	osdep: implement qemu_socketpair() for win32	2023-03-13 15:39:31 +04:00
stats64.h	stat64: Add stat64_set() operation	2023-04-27 16:39:43 +02:00
sys_membarrier.h	bulk: Do not declare function prototypes using 'extern' keyword	2023-08-31 19:47:43 +02:00
systemd.h
thread-context.h	util: Introduce ThreadContext user-creatable object	2022-10-27 11:00:43 +02:00
thread-posix.h	thread-posix: implement Semaphore with QemuCond and QemuMutex	2022-04-06 14:31:56 +02:00
thread-win32.h
thread.h	system/cpus: rename qemu_mutex_lock_iothread() to bql_lock()	2024-01-08 10:45:43 -05:00
throttle-options.h
throttle.h	throttle: use enum ThrottleDirection instead of bool is_write	2023-08-29 10:49:24 +02:00
timed-average.h
timer.h	qemu/timer: Add host ticks function for RISC-V	2023-09-21 10:39:51 +02:00
transactions.h
tsan.h
typedefs.h	include/qemu: Add TCGCPUOps typedef to typedefs.h	2024-01-29 21:04:10 +10:00
unicode.h
units.h
uri.h	util/uri: Remove the uri_string_escape() function	2024-01-24 09:54:05 +01:00
userfaultfd.h	migration: Clean up includes	2023-02-08 07:27:20 +01:00
uuid.h	util/uuid: Define UUID_STR_LEN from UUID_NONE string	2023-11-03 09:20:31 +01:00
vfio-helpers.h
vhost-user-server.h	export/vhost-user-blk: Fix consecutive drains	2023-11-28 14:56:32 +01:00
win_dump_defs.h	include/qemu: add 32-bit Windows dump structures	2022-04-22 13:36:04 +04:00
xattr.h	qemu/xattr.h: Exclude <sys/xattr.h> for Windows	2022-12-23 11:48:13 +01:00
xxhash.h	accel/tcg: include cs_base in our hash calculations	2023-06-01 11:05:05 -04:00
yank.h	qapi: Fix dangling references to docs/devel/qapi-code-gen.txt	2024-01-26 07:04:53 +01:00