19368b1905
Coverity reports a concurrent data access violation because be->users is being accessed in iommufd_backend_can_be_deleted() without holding the mutex. However, these routines are called from the QEMU main thread when a device is created. In this case, the code paths should be protected by the BQL lock and it should be safe to drop the IOMMUFD backend mutex. Simply remove it. Fixes: CID 1531550 Fixes: CID 1531549 Reviewed-by: Eric Auger <eric.auger@redhat.com> Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Signed-off-by: Cédric Le Goater <clg@redhat.com>
37 lines
1.1 KiB
C
37 lines
1.1 KiB
C
#ifndef SYSEMU_IOMMUFD_H
|
|
#define SYSEMU_IOMMUFD_H
|
|
|
|
#include "qom/object.h"
|
|
#include "exec/hwaddr.h"
|
|
#include "exec/cpu-common.h"
|
|
|
|
#define TYPE_IOMMUFD_BACKEND "iommufd"
|
|
OBJECT_DECLARE_TYPE(IOMMUFDBackend, IOMMUFDBackendClass, IOMMUFD_BACKEND)
|
|
|
|
struct IOMMUFDBackendClass {
|
|
ObjectClass parent_class;
|
|
};
|
|
|
|
struct IOMMUFDBackend {
|
|
Object parent;
|
|
|
|
/*< protected >*/
|
|
int fd; /* /dev/iommu file descriptor */
|
|
bool owned; /* is the /dev/iommu opened internally */
|
|
uint32_t users;
|
|
|
|
/*< public >*/
|
|
};
|
|
|
|
int iommufd_backend_connect(IOMMUFDBackend *be, Error **errp);
|
|
void iommufd_backend_disconnect(IOMMUFDBackend *be);
|
|
|
|
int iommufd_backend_alloc_ioas(IOMMUFDBackend *be, uint32_t *ioas_id,
|
|
Error **errp);
|
|
void iommufd_backend_free_id(IOMMUFDBackend *be, uint32_t id);
|
|
int iommufd_backend_map_dma(IOMMUFDBackend *be, uint32_t ioas_id, hwaddr iova,
|
|
ram_addr_t size, void *vaddr, bool readonly);
|
|
int iommufd_backend_unmap_dma(IOMMUFDBackend *be, uint32_t ioas_id,
|
|
hwaddr iova, ram_addr_t size);
|
|
#endif
|