qemu-e2k/qga
Markus Armbruster a903f40c31 qga: Use return values instead of error_is_set(errp)
Using error_is_set(errp) to check whether a function call failed is
fragile: it breaks when errp is null.  ga_get_fd_handle() and
guest_file_handle_add() don't return a useful value when they fail,
but that's just stupid.  Fix that, and check them instead.  As far
as I can tell, errp can't be null there, but this is more robust and
more obviously correct.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
2014-05-09 09:11:30 -04:00
..
vss-win32 vss-win32: Fix build with mingw64-headers-3.1.0 2014-04-07 14:39:19 -05:00
channel-posix.c qemu-ga: Handle errors uniformely in ga_channel_open() 2013-01-14 12:08:05 -06:00
channel-win32.c qemu-ga: isa-serial support on Windows 2014-02-23 18:38:18 -06:00
channel.h
commands-posix.c qga: Use return values instead of error_is_set(errp) 2014-05-09 09:11:30 -04:00
commands-win32.c qga: Consistently name Error ** objects errp, and not err 2014-05-09 09:11:26 -04:00
commands.c qga: Consistently name Error ** objects errp, and not err 2014-05-09 09:11:26 -04:00
guest-agent-command-state.c
guest-agent-core.h qga: Fix compiler warnings (missing format attribute, wrong format strings) 2013-11-21 17:39:25 +01:00
main.c qga: Use return values instead of error_is_set(errp) 2014-05-09 09:11:30 -04:00
Makefile.objs qemu-ga: Call Windows VSS requester in fsfreeze command handler 2013-09-09 14:17:57 -05:00
qapi-schema.json qga: trivial fix for unclear documentation of guest-set-time 2014-04-18 10:33:36 +04:00
service-win32.c qga: escape cmdline args when registering win32 service (CVE-2013-2231) 2013-07-25 14:49:04 -05:00
service-win32.h qga: save state directory in ga_install_service() 2013-05-30 11:37:37 -05:00
vss-win32.c qga: Consistently name Error ** objects errp, and not err 2014-05-09 09:11:26 -04:00
vss-win32.h qga: Consistently name Error ** objects errp, and not err 2014-05-09 09:11:26 -04:00