qemu-e2k/target/s390x
Eric Blake 2562755ee7 maint: Fix macros with broken 'do/while(0); ' usage
The point of writing a macro embedded in a 'do { ... } while (0)'
loop (particularly if the macro has multiple statements or would
otherwise end with an 'if' statement) is so that the macro can be
used as a drop-in statement with the caller supplying the
trailing ';'.  Although our coding style frowns on brace-less 'if':
  if (cond)
    statement;
  else
    something else;
that is the classic case where failure to use do/while(0) wrapping
would cause the 'else' to pair with any embedded 'if' in the macro
rather than the intended outer 'if'.  But conversely, if the macro
includes an embedded ';', then the same brace-less coding style
would now have two statements, making the 'else' a syntax error
rather than pairing with the outer 'if'.  Thus, even though our
coding style with required braces is not impacted, ending a macro
with ';' makes our code harder to port to projects that use
brace-less styles.

The change should have no semantic impact.  I was not able to
fully compile-test all of the changes (as some of them are
examples of the ugly bit-rotting debug print statements that are
completely elided by default, and I didn't want to recompile
with the necessary -D witnesses - cleaning those up is left as a
bite-sized task for another day); I did, however, audit that for
all files touched, all callers of the changed macros DID supply
a trailing ';' at the callsite, and did not appear to be used
as part of a brace-less conditional.

Found mechanically via: $ git grep -B1 'while (0);' | grep -A1 \\\\

Signed-off-by: Eric Blake <eblake@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20171201232433.25193-7-eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2018-01-16 14:54:52 +01:00
..
arch_dump.c
cc_helper.c s390x/tcg: use s390_program_interrupt() in SACF 2017-12-14 17:56:54 +01:00
cpu_features_def.h
cpu_features.c
cpu_features.h
cpu_models.c s390x: change the QEMU cpu model to a stripped down z12 2017-12-14 17:56:54 +01:00
cpu_models.h s390x: change the QEMU cpu model to a stripped down z12 2017-12-14 17:56:54 +01:00
cpu-qom.h target/s390x: change CPU type name to "s390x-cpu" 2017-10-30 08:56:28 +01:00
cpu.c tcg: Avoid setting tcg_initialize if !CONFIG_TCG 2017-10-26 17:47:36 +01:00
cpu.h s390x: change the QEMU cpu model to a stripped down z12 2017-12-14 17:56:54 +01:00
crypto_helper.c s390x/tcg: introduce and use s390_program_interrupt() 2017-12-14 17:56:54 +01:00
diag.c s390x/diag: pass the retaddr into handle_diag_308() 2017-12-14 17:56:54 +01:00
excp_helper.c s390x/tcg: fix and cleanup mcck injection 2017-12-14 17:56:54 +01:00
fpu_helper.c s390x/tcg: get rid of runtime_exception() 2017-12-14 17:56:54 +01:00
gdbstub.c
gen-features.c s390x: change the QEMU cpu model to a stripped down z12 2017-12-14 17:56:54 +01:00
helper.c target/s390x: nuke DPRINTF in helper.c 2017-12-14 17:56:54 +01:00
helper.h s390x/tcg: implement extract-CPU-time facility 2017-12-14 17:56:54 +01:00
insn-data.def s390x/tcg: implement extract-CPU-time facility 2017-12-14 17:56:54 +01:00
insn-format.def
int_helper.c s390x/tcg: get rid of runtime_exception() 2017-12-14 17:56:54 +01:00
internal.h s390x/tcg: fix and cleanup mcck injection 2017-12-14 17:56:54 +01:00
interrupt.c s390x/tcg: drop program_interrupt() 2017-12-14 17:56:54 +01:00
ioinst.c s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG) 2017-12-14 17:56:54 +01:00
kvm_s390x.h s390x/kvm: factor out SIGP code into sigp.c 2017-10-20 13:32:10 +02:00
kvm-stub.c s390x/kvm: factor out SIGP code into sigp.c 2017-10-20 13:32:10 +02:00
kvm.c maint: Fix macros with broken 'do/while(0); ' usage 2018-01-16 14:54:52 +01:00
machine.c s390x/kvm: use cpu model for gscb on compat machines 2017-10-30 09:03:45 +01:00
Makefile.objs s390x/kvm: factor out SIGP code into sigp.c 2017-10-20 13:32:10 +02:00
mem_helper.c s390x/tcg: introduce and use s390_program_interrupt() 2017-12-14 17:56:54 +01:00
misc_helper.c s390x/tcg: implement extract-CPU-time facility 2017-12-14 17:56:54 +01:00
mmu_helper.c s390x/tcg: don't exit the cpu loop in s390_cpu_virt_mem_rw() 2017-12-14 17:56:54 +01:00
sigp.c target/s390x: special handling when starting a CPU with WAIT PSW 2017-10-20 13:32:10 +02:00
trace-events s390x/kvm: factor out SIGP code into sigp.c 2017-10-20 13:32:10 +02:00
translate.c tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED* 2017-12-29 12:43:39 -08:00