OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
b17fbbe55c
qemu-e2k/hw/arm
History
Peter Maydell c8ead57124 hw/arm/sbsa-ref: Remove unnecessary check for secure_sysmem == NULL 
In the virt machine, we support TrustZone being either present or
absent, and so the code must deal with the secure_sysmem pointer
possibly being NULL. In the sbsa-ref machine, TrustZone is always
present, but some code and comments copied from virt still treat
it as possibly not being present.

This causes Coverity to complain (CID 1407287) that we check
secure_sysmem for being NULL after an unconditional dereference.
Simplify the code so that instead of initializing the variable
to NULL, unconditionally assigning it, and then testing it for NULL,
we just initialize it correctly in the variable declaration and
then assume it to be non-NULL. We also delete a comment which
only applied to the non-TrustZone config.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20190704142004.7150-1-peter.maydell@linaro.org
Tested-by: Radosław Biernacki <radoslaw.biernacki@linaro.org>
Reviewed-by: Radosław Biernacki <radoslaw.biernacki@linaro.org>
2019-07-08 14:11:31 +01:00
..
allwinner-a10.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
armsse.c hw/arm: Correctly disable FPU/DSP for some ARMSSE-based boards 2019-06-17 15:12:25 +01:00
armv7m.c hw/arm/armv7m: Forward "vfp" and "dsp" properties to CPU 2019-06-17 15:12:25 +01:00
aspeed_soc.c aspeed: Link SCU to the watchdog 2019-07-01 17:29:00 +01:00
aspeed.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
bcm2835_peripherals.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
bcm2836.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
boot.c hw/arm/boot: fix direct kernel boot with initrd 2019-07-01 17:28:59 +01:00
collie.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
cubieboard.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
digic_boards.c pflash: Clean up after commit 368a354f02, part 2 2019-03-11 22:53:44 +01:00
digic.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
exynos4_boards.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
exynos4210.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
fsl-imx6.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
fsl-imx6ul.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
fsl-imx7.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
fsl-imx25.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
fsl-imx31.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
gumstix.c hw/devices: Move SMSC 91C111 declaration into a new header 2019-04-29 17:57:21 +01:00
highbank.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
imx25_pdk.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
integratorcp.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
Kconfig hw/arm: Add arm SBSA reference machine, skeleton part 2019-07-01 17:29:00 +01:00
kzm.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
mainstone.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
Makefile.objs hw/arm: Add arm SBSA reference machine, skeleton part 2019-07-01 17:29:00 +01:00
mcimx6ul-evk.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
mcimx7d-sabre.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
microbit.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
mps2-tz.c hw/arm/mps2: Use object_initialize_child for correct reference counting 2019-05-24 15:29:02 -03:00
mps2.c hw/arm/mps2: Use object_initialize_child for correct reference counting 2019-05-24 15:29:02 -03:00
msf2-soc.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
msf2-som.c hw/arm/msf2-som: Exit when the cpu is not the expected one 2019-07-01 17:28:59 +01:00
musca.c hw/arm: Correctly disable FPU/DSP for some ARMSSE-based boards 2019-06-17 15:12:25 +01:00
musicpal.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
netduino2.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
nrf51_soc.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
nseries.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
omap1.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
omap2.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
omap_sx1.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
palm.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
pxa2xx_gpio.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
pxa2xx_pic.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
pxa2xx.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
raspi.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
realview.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
sabrelite.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
sbsa-ref.c hw/arm/sbsa-ref: Remove unnecessary check for secure_sysmem == NULL 2019-07-08 14:11:31 +01:00
smmu-common.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
smmu-internal.h
smmuv3-internal.h Clean up header guards that don't match their file name 2019-05-13 08:58:55 +02:00
smmuv3.c hw/arm/smmuv3: Fix decoding of ID register range 2019-06-13 15:14:03 +01:00
spitz.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
stellaris.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
stm32f205_soc.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
strongarm.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
strongarm.h
sysbus-fdt.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
tosa.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00
trace-events trace-events: Fix attribution of trace points to source 2019-03-22 16:18:07 +00:00
versatilepb.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
vexpress.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
virt-acpi-build.c hw/acpi: extract acpi_add_rom_blob() 2019-06-16 16:16:52 -04:00
virt.c machine: show if CLI option '-numa node,mem' is supported in QAPI schema 2019-07-05 17:08:03 -03:00
xilinx_zynq.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
xlnx-versal-virt.c hw/arm: versal: Plug memory leaks 2019-01-07 15:23:46 +00:00
xlnx-versal.c Include qemu/module.h where needed, drop it from qemu-common.h 2019-06-12 13:18:33 +02:00
xlnx-zcu102.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
xlnx-zynqmp.c hw/arm: Replace global smp variables with machine smp properties 2019-07-05 17:08:03 -03:00
z2.c arm: Rename hw/arm/arm.h to hw/arm/boot.h 2019-05-23 14:47:43 +01:00