55e1819c50
The QObject hierarchy is small enough, and unlikely to grow further (since we only use it to map to JSON and already cover all JSON types), that we can simplify things by not tracking a separate vtable, but just inline the code element of the vtable QType directly into QObject (renamed to type), and track a separate array of destroy functions. We can drop qnull_destroy_obj() in the process. The remaining QObject subclasses must export their destructor. This also has the nice benefit of moving the typename 'QType' out of the way, so that the next patch can repurpose it for a nicer name for 'qtype_code'. The various objects are still the same size (so no change in cache line pressure), but now have less indirection (although I didn't bother benchmarking to see if there is a noticeable speedup, as we don't have hard evidence that this was in a performance hotspot in the first place). A future patch could drop the refcnt size to 32 bits for a smaller struct on 64-bit architectures, if desired (we have limits on the largest JSON that we are willing to parse, and will probably never need to take full advantage of a 64-bit refcnt). Suggested-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1449033659-25497-2-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
61 lines
1.1 KiB
C
61 lines
1.1 KiB
C
/*
|
|
* QInt Module
|
|
*
|
|
* Copyright (C) 2009 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Luiz Capitulino <lcapitulino@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
|
|
* See the COPYING.LIB file in the top-level directory.
|
|
*/
|
|
|
|
#include "qapi/qmp/qint.h"
|
|
#include "qapi/qmp/qobject.h"
|
|
#include "qemu-common.h"
|
|
|
|
/**
|
|
* qint_from_int(): Create a new QInt from an int64_t
|
|
*
|
|
* Return strong reference.
|
|
*/
|
|
QInt *qint_from_int(int64_t value)
|
|
{
|
|
QInt *qi;
|
|
|
|
qi = g_malloc(sizeof(*qi));
|
|
qobject_init(QOBJECT(qi), QTYPE_QINT);
|
|
qi->value = value;
|
|
|
|
return qi;
|
|
}
|
|
|
|
/**
|
|
* qint_get_int(): Get the stored integer
|
|
*/
|
|
int64_t qint_get_int(const QInt *qi)
|
|
{
|
|
return qi->value;
|
|
}
|
|
|
|
/**
|
|
* qobject_to_qint(): Convert a QObject into a QInt
|
|
*/
|
|
QInt *qobject_to_qint(const QObject *obj)
|
|
{
|
|
if (!obj || qobject_type(obj) != QTYPE_QINT) {
|
|
return NULL;
|
|
}
|
|
return container_of(obj, QInt, base);
|
|
}
|
|
|
|
/**
|
|
* qint_destroy_obj(): Free all memory allocated by a
|
|
* QInt object
|
|
*/
|
|
void qint_destroy_obj(QObject *obj)
|
|
{
|
|
assert(obj != NULL);
|
|
g_free(qobject_to_qint(obj));
|
|
}
|