OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
b40181942e
qemu-e2k/hw/arm
History
Markus Armbruster b40181942e arm/stm32f205 arm/stm32f405: Fix realize error API violation 
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.

stm32f205_soc_realize() and stm32f405_soc_realize() are wrong that
way: they pass &err to object_property_set_int() without checking it,
and then to qdev_realize().  Harmless, because the former can't
actually fail here.

Fix by passing &error_abort instead.

Cc: Alistair Francis <alistair@alistair23.me>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200630090351.1247703-23-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
2020-07-02 11:54:47 +02:00
..
allwinner-a10.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
allwinner-h3.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
armsse.c hw/arm: Drop useless object_property_set_link() error handling 2020-07-02 06:25:29 +02:00
armv7m.c hw/arm: Drop useless object_property_set_link() error handling 2020-07-02 06:25:29 +02:00
aspeed_ast2600.c hw/arm: Drop useless object_property_set_link() error handling 2020-07-02 06:25:29 +02:00
aspeed_soc.c hw/arm: Drop useless object_property_set_link() error handling 2020-07-02 06:25:29 +02:00
aspeed.c hw/arm/aspeed: Describe each PCA9552 device 2020-06-26 14:30:28 +01:00
bcm2835_peripherals.c sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 2020-06-15 22:06:04 +02:00
bcm2836.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
boot.c
collie.c hw/arm/collie: Put StrongARMState* into a CollieMachineState struct 2020-04-03 19:23:37 +01:00
cubieboard.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
digic_boards.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
digic.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
exynos4_boards.c sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 2020-06-15 22:06:04 +02:00
exynos4210.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
fsl-imx6.c * hw: arm: Set vendor property for IMX SDHCI emulations 2020-06-16 13:36:31 +01:00
fsl-imx6ul.c * hw: arm: Set vendor property for IMX SDHCI emulations 2020-06-16 13:36:31 +01:00
fsl-imx7.c * hw: arm: Set vendor property for IMX SDHCI emulations 2020-06-16 13:36:31 +01:00
fsl-imx25.c * hw: arm: Set vendor property for IMX SDHCI emulations 2020-06-16 13:36:31 +01:00
fsl-imx31.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
gumstix.c
highbank.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
imx25_pdk.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
integratorcp.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
Kconfig hw/arm/mps2: Add I2C devices 2020-06-23 11:39:47 +01:00
kzm.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
mainstone.c hw/arm: Use memory_region_init_rom() with read-only regions 2020-03-17 15:18:46 +01:00
Makefile.objs
mcimx6ul-evk.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
mcimx7d-sabre.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
microbit.c microbit: Eliminate two local variables in microbit_init() 2020-06-15 22:06:04 +02:00
mps2-tz.c hw/arm/mps2-tz: Use the ARM SBCon two-wire serial bus interface 2020-06-23 11:39:47 +01:00
mps2.c hw/arm/mps2: Add audio I2S interface as unimplemented device 2020-06-23 11:39:47 +01:00
msf2-soc.c sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 2020-06-15 22:06:04 +02:00
msf2-som.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
musca.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
musicpal.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
netduino2.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
netduinoplus2.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
nrf51_soc.c hw/arm: Drop useless object_property_set_link() error handling 2020-07-02 06:25:29 +02:00
nseries.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
omap1.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
omap2.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
omap_sx1.c hw/arm: Use memory_region_init_rom() with read-only regions 2020-03-17 15:18:46 +01:00
orangepi.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
palm.c hw/arm: Use memory_region_init_rom() with read-only regions 2020-03-17 15:18:46 +01:00
pxa2xx_gpio.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
pxa2xx_pic.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
pxa2xx.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
raspi.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
realview.c hw/arm: Use TYPE_VERSATILE_I2C instead of hardcoded string 2020-06-23 11:39:47 +01:00
sabrelite.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
sbsa-ref.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
smmu-common.c
smmu-internal.h
smmuv3-internal.h
smmuv3.c
spitz.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
stellaris.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
stm32f205_soc.c arm/stm32f205 arm/stm32f405: Fix realize error API violation 2020-07-02 11:54:47 +02:00
stm32f405_soc.c arm/stm32f205 arm/stm32f405: Fix realize error API violation 2020-07-02 11:54:47 +02:00
strongarm.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
strongarm.h
sysbus-fdt.c
tosa.c hw/arm: Use memory_region_init_rom() with read-only regions 2020-03-17 15:18:46 +01:00
trace-events
versatilepb.c hw/arm: Use TYPE_VERSATILE_I2C instead of hardcoded string 2020-06-23 11:39:47 +01:00
vexpress.c Qdev patches for 2020-06-23 2020-06-25 09:34:52 +01:00
virt-acpi-build.c arm/acpi: Add the TPM2.0 device under the DSDT 2020-06-24 17:18:28 -04:00
virt.c Clean up some calls to ignore Error objects the right way 2020-07-02 06:25:28 +02:00
xilinx_zynq.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
xlnx-versal-virt.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
xlnx-versal.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
xlnx-zcu102.c qdev: Make qdev_prop_set_drive() match the other helpers 2020-06-23 16:07:07 +02:00
xlnx-zynqmp.c qdev: Convert bus-less devices to qdev_realize() with Coccinelle 2020-06-15 22:06:04 +02:00
z2.c