b66ff2c298
There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to -blockdev. With older -drive, at least the probing was always done by qemu (so the only risk of a changed format between successive boots of a guest was if qemu was upgraded and probed differently). But with newer -blockdev, libvirt must specify a format; if libvirt guesses raw where the image was formatted, this results in data corruption visible to the guest; conversely, if libvirt guesses qcow2 where qemu was using raw, this can result in potential security holes, so modern libvirt instead refuses to use images without explicit backing format. The change in libvirt to reject images without explicit backing format has pointed out that a number of tools have been far too reliant on probing in the past. It's time to set a better example in our own iotests of properly setting this parameter. iotest calls to create, rebase, and convert are all impacted to some degree. It's a bit annoying that we are inconsistent on command line - while all of those accept -o backing_file=...,backing_fmt=..., the shortcuts are different: create and rebase have -b and -F, while convert has -B but no -F. (amend has no shortcuts, but the previous patch just deprecated the use of amend to change backing chains). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20200706203954.341758-9-eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
151 lines
7.2 KiB
Plaintext
151 lines
7.2 KiB
Plaintext
QA output created by 097
|
|
|
|
=== Test pass 0 ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=2202010112
|
|
Formatting 'TEST_DIR/t.IMGFMT.itmd', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.itmd backing_fmt=IMGFMT
|
|
wrote 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 131072/131072 bytes at offset 2147352576
|
|
128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Image committed.
|
|
read 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147287040
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147352576
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Offset Length File
|
|
0x7ffd0000 0x30000 TEST_DIR/t.IMGFMT.base
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x20000 TEST_DIR/t.IMGFMT.itmd
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT.itmd
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x20000 TEST_DIR/t.IMGFMT.itmd
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT.itmd
|
|
|
|
=== Test pass 1 ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=2202010112
|
|
Formatting 'TEST_DIR/t.IMGFMT.itmd', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.itmd backing_fmt=IMGFMT
|
|
wrote 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 131072/131072 bytes at offset 2147352576
|
|
128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Image committed.
|
|
read 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147287040
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147352576
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Offset Length File
|
|
0x7ffd0000 0x30000 TEST_DIR/t.IMGFMT.base
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x20000 TEST_DIR/t.IMGFMT.itmd
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT.itmd
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x10000 TEST_DIR/t.IMGFMT.itmd
|
|
0x7fff0000 0x10000 TEST_DIR/t.IMGFMT
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT
|
|
|
|
=== Test pass 2 ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=2202010112
|
|
Formatting 'TEST_DIR/t.IMGFMT.itmd', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.itmd backing_fmt=IMGFMT
|
|
wrote 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 131072/131072 bytes at offset 2147352576
|
|
128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Image committed.
|
|
read 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147287040
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147352576
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Offset Length File
|
|
0x7ffd0000 0x30000 TEST_DIR/t.IMGFMT.base
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x20000 TEST_DIR/t.IMGFMT.itmd
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT.itmd
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x10000 TEST_DIR/t.IMGFMT.itmd
|
|
0x7fff0000 0x10000 TEST_DIR/t.IMGFMT
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT
|
|
|
|
=== Test pass 3 ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=2202010112
|
|
Formatting 'TEST_DIR/t.IMGFMT.itmd', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=2202010112 backing_file=TEST_DIR/t.IMGFMT.itmd backing_fmt=IMGFMT
|
|
wrote 196608/196608 bytes at offset 2147287040
|
|
192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 131072/131072 bytes at offset 2147352576
|
|
128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Image committed.
|
|
read 65536/65536 bytes at offset 2147287040
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147352576
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 65536/65536 bytes at offset 2147418112
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
read 512/512 bytes at offset 2202009600
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
Offset Length File
|
|
0x7ffd0000 0x30000 TEST_DIR/t.IMGFMT.base
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT.base
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x20000 TEST_DIR/t.IMGFMT.itmd
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT.base
|
|
Offset Length File
|
|
0x7ffd0000 0x10000 TEST_DIR/t.IMGFMT.base
|
|
0x7ffe0000 0x10000 TEST_DIR/t.IMGFMT.itmd
|
|
0x7fff0000 0x10000 TEST_DIR/t.IMGFMT
|
|
0x83400000 0x200 TEST_DIR/t.IMGFMT
|
|
*** done
|