bcb40db010
Coverity points out (CID 1513106, 1513107) that MemoryListener is a 192 byte struct which we are passing around by value. Switch to passing a const pointer into xen_register_ioreq() and then to xen_do_ioreq_register(). We can also make the file-scope MemoryListener variables const, since nothing changes them. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Acked-by: Anthony PERARD <anthony.perard@citrix.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230718101057.1110979-1-peter.maydell@linaro.org> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
182 lines
5.1 KiB
C
182 lines
5.1 KiB
C
/*
|
|
* QEMU ARM Xen PVH Machine
|
|
*
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qapi/qapi-commands-migration.h"
|
|
#include "qapi/visitor.h"
|
|
#include "hw/boards.h"
|
|
#include "hw/sysbus.h"
|
|
#include "sysemu/block-backend.h"
|
|
#include "sysemu/tpm_backend.h"
|
|
#include "sysemu/sysemu.h"
|
|
#include "hw/xen/xen-hvm-common.h"
|
|
#include "sysemu/tpm.h"
|
|
#include "hw/xen/arch_hvm.h"
|
|
|
|
#define TYPE_XEN_ARM MACHINE_TYPE_NAME("xenpvh")
|
|
OBJECT_DECLARE_SIMPLE_TYPE(XenArmState, XEN_ARM)
|
|
|
|
static const MemoryListener xen_memory_listener = {
|
|
.region_add = xen_region_add,
|
|
.region_del = xen_region_del,
|
|
.log_start = NULL,
|
|
.log_stop = NULL,
|
|
.log_sync = NULL,
|
|
.log_global_start = NULL,
|
|
.log_global_stop = NULL,
|
|
.priority = MEMORY_LISTENER_PRIORITY_ACCEL,
|
|
};
|
|
|
|
struct XenArmState {
|
|
/*< private >*/
|
|
MachineState parent;
|
|
|
|
XenIOState *state;
|
|
|
|
struct {
|
|
uint64_t tpm_base_addr;
|
|
} cfg;
|
|
};
|
|
|
|
void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
|
|
{
|
|
hw_error("Invalid ioreq type 0x%x\n", req->type);
|
|
|
|
return;
|
|
}
|
|
|
|
void arch_xen_set_memory(XenIOState *state, MemoryRegionSection *section,
|
|
bool add)
|
|
{
|
|
}
|
|
|
|
void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
|
|
{
|
|
}
|
|
|
|
void qmp_xen_set_global_dirty_log(bool enable, Error **errp)
|
|
{
|
|
}
|
|
|
|
#ifdef CONFIG_TPM
|
|
static void xen_enable_tpm(XenArmState *xam)
|
|
{
|
|
Error *errp = NULL;
|
|
DeviceState *dev;
|
|
SysBusDevice *busdev;
|
|
|
|
TPMBackend *be = qemu_find_tpm_be("tpm0");
|
|
if (be == NULL) {
|
|
DPRINTF("Couldn't fine the backend for tpm0\n");
|
|
return;
|
|
}
|
|
dev = qdev_new(TYPE_TPM_TIS_SYSBUS);
|
|
object_property_set_link(OBJECT(dev), "tpmdev", OBJECT(be), &errp);
|
|
object_property_set_str(OBJECT(dev), "tpmdev", be->id, &errp);
|
|
busdev = SYS_BUS_DEVICE(dev);
|
|
sysbus_realize_and_unref(busdev, &error_fatal);
|
|
sysbus_mmio_map(busdev, 0, xam->cfg.tpm_base_addr);
|
|
|
|
DPRINTF("Connected tpmdev at address 0x%lx\n", xam->cfg.tpm_base_addr);
|
|
}
|
|
#endif
|
|
|
|
static void xen_arm_init(MachineState *machine)
|
|
{
|
|
XenArmState *xam = XEN_ARM(machine);
|
|
|
|
xam->state = g_new0(XenIOState, 1);
|
|
|
|
xen_register_ioreq(xam->state, machine->smp.cpus, &xen_memory_listener);
|
|
|
|
#ifdef CONFIG_TPM
|
|
if (xam->cfg.tpm_base_addr) {
|
|
xen_enable_tpm(xam);
|
|
} else {
|
|
DPRINTF("tpm-base-addr is not provided. TPM will not be enabled\n");
|
|
}
|
|
#endif
|
|
}
|
|
|
|
#ifdef CONFIG_TPM
|
|
static void xen_arm_get_tpm_base_addr(Object *obj, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
XenArmState *xam = XEN_ARM(obj);
|
|
uint64_t value = xam->cfg.tpm_base_addr;
|
|
|
|
visit_type_uint64(v, name, &value, errp);
|
|
}
|
|
|
|
static void xen_arm_set_tpm_base_addr(Object *obj, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
XenArmState *xam = XEN_ARM(obj);
|
|
uint64_t value;
|
|
|
|
if (!visit_type_uint64(v, name, &value, errp)) {
|
|
return;
|
|
}
|
|
|
|
xam->cfg.tpm_base_addr = value;
|
|
}
|
|
#endif
|
|
|
|
static void xen_arm_machine_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
|
|
MachineClass *mc = MACHINE_CLASS(oc);
|
|
mc->desc = "Xen Para-virtualized PC";
|
|
mc->init = xen_arm_init;
|
|
mc->max_cpus = 1;
|
|
mc->default_machine_opts = "accel=xen";
|
|
|
|
#ifdef CONFIG_TPM
|
|
object_class_property_add(oc, "tpm-base-addr", "uint64_t",
|
|
xen_arm_get_tpm_base_addr,
|
|
xen_arm_set_tpm_base_addr,
|
|
NULL, NULL);
|
|
object_class_property_set_description(oc, "tpm-base-addr",
|
|
"Set Base address for TPM device.");
|
|
|
|
machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS);
|
|
#endif
|
|
}
|
|
|
|
static const TypeInfo xen_arm_machine_type = {
|
|
.name = TYPE_XEN_ARM,
|
|
.parent = TYPE_MACHINE,
|
|
.class_init = xen_arm_machine_class_init,
|
|
.instance_size = sizeof(XenArmState),
|
|
};
|
|
|
|
static void xen_arm_machine_register_types(void)
|
|
{
|
|
type_register_static(&xen_arm_machine_type);
|
|
}
|
|
|
|
type_init(xen_arm_machine_register_types)
|