QEMU With E2K User Support
Go to file
Joseph Myers bc921b2711 target/i386: correct fix for pcmpxstrx substring search
This corrects a bug introduced in my previous fix for SSE4.2 pcmpestri
/ pcmpestrm / pcmpistri / pcmpistrm substring search, commit
ae35eea7e4.

That commit fixed a bug that showed up in four GCC tests with one libc
implementation.  The tests in question generate random inputs to the
intrinsics and compare results to a C implementation, but they only
test 1024 possible random inputs, and when the tests use the cases of
those instructions that work with word rather than byte inputs, it's
easy to have problematic cases that show up much less frequently than
that.  Thus, testing with a different libc implementation, and so a
different random number generator, showed up a problem with the
previous patch.

When investigating the previous test failures, I found the description
of these instructions in the Intel manuals (starting from computing a
16x16 or 8x8 set of comparison results) confusing and hard to match up
with the more optimized implementation in QEMU, and referred to AMD
manuals which described the instructions in a different way.  Those
AMD descriptions are very explicit that the whole of the string being
searched for must be found in the other operand, not running off the
end of that operand; they say "If the prototype and the SUT are equal
in length, the two strings must be identical for the comparison to be
TRUE.".  However, that statement is incorrect.

In my previous commit message, I noted:

  The operation in this case is a search for a string (argument d to
  the helper) in another string (argument s to the helper); if a copy
  of d at a particular position would run off the end of s, the
  resulting output bit should be 0 whether or not the strings match in
  the region where they overlap, but the QEMU implementation was
  wrongly comparing only up to the point where s ends and counting it
  as a match if an initial segment of d matched a terminal segment of
  s.  Here, "run off the end of s" means that some byte of d would
  overlap some byte outside of s; thus, if d has zero length, it is
  considered to match everywhere, including after the end of s.

The description "some byte of d would overlap some byte outside of s"
is accurate only when understood to refer to overlapping some byte
*within the 16-byte operand* but at or after the zero terminator; it
is valid to run over the end of s if the end of s is the end of the
16-byte operand.  So the fix in the previous patch for the case of d
being empty was correct, but the other part of that patch was not
correct (as it never allowed partial matches even at the end of the
16-byte operand).  Nor was the code before the previous patch correct
for the case of d nonempty, as it would always have allowed partial
matches at the end of s.

Fix with a partial revert of my previous change, combined with
inserting a check for the special case of s having maximum length to
determine where it is necessary to check for matches.

In the added test, test 1 is for the case of empty strings, which
failed before my 2017 patch, test 2 is for the bug introduced by my
2017 patch and test 3 deals with the case where a match of an initial
segment at the end of the string is not valid when the string ends
before the end of the 16-byte operand (that is, the case that would be
broken by a simple revert of the non-empty-string part of my 2017
patch).

Signed-off-by: Joseph Myers <joseph@codesourcery.com>
Message-Id: <alpine.DEB.2.21.2006121344290.9881@digraph.polyomino.org.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2020-06-12 11:10:39 -04:00
.github
.gitlab-ci.d gitlab-ci: Move edk2 and opensbi YAML files to .gitlab-ci.d folder 2020-05-28 11:00:39 +02:00
accel KVM: Kick resamplefd for split kernel irqchip 2020-06-10 12:10:33 -04:00
audio audio: Let capture_callback handler use const buffer argument 2020-05-26 08:29:39 +02:00
authz qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
backends machine queue, 2020-05-13 2020-06-02 10:25:55 +01:00
block block: Factor out bdrv_run_co() 2020-06-05 09:54:48 +01:00
bsd-user exec/cpu-all: Use bool for have_guest_base 2020-05-15 15:25:16 +01:00
capstone@22ead3e0bf
chardev chardev/char-socket: Properly make qio connections non blocking 2020-06-10 12:10:45 -04:00
contrib
crypto qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
default-configs riscv: Initial commit of OpenTitan machine 2020-06-03 09:11:51 -07:00
disas
docs target-arm queue: 2020-06-05 23:31:31 +01:00
dtc@88f18909db
dump
fpu softfloat: Return bool from all classification predicates 2020-05-19 08:43:05 -07:00
fsdev
gdb-xml target/arm: Use correct GDB XML for M-profile cores 2020-05-14 15:03:08 +01:00
hw hw/i386/amd_iommu: Fix the reserved bits definition of IOMMU commands 2020-06-10 12:10:46 -04:00
include exec: set map length to zero when returning NULL 2020-06-10 12:10:50 -04:00
io io/task: Move 'qom/object.h' header to source 2020-06-10 12:09:37 -04:00
libdecnumber
linux-headers
linux-user linux-user pull request 20200605-v2 2020-06-08 11:04:57 +01:00
migration accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
monitor memory: Make 'info mtree' not display disabled regions by default 2020-06-10 12:10:49 -04:00
nbd
net qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
pc-bios Update OpenBIOS images to 4704d9eb built from submodule. 2020-05-21 21:00:39 +01:00
plugins qemu/qemu-plugin: Make qemu_plugin_hwaddr_is_io() hwaddr argument const 2020-05-15 15:25:16 +01:00
po
python/qemu python/qemu/qtest: Check before accessing _qtest 2020-05-31 18:25:31 +02:00
qapi qcow2: Expose bitmaps' size during measure 2020-05-28 13:16:16 -05:00
qga
qobject
qom qom/container: remove .instance_size initializer from container_info 2020-06-10 12:09:59 -04:00
replay replay: implement fair mutex 2020-06-10 12:10:47 -04:00
roms Update OpenBIOS images to 4704d9eb built from submodule. 2020-05-21 21:00:39 +01:00
scripts run-coverity-scan: support --update-tools-only --docker 2020-06-10 12:09:34 -04:00
scsi error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
slirp@2faae0f778
softmmu accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
storage-daemon
stubs accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
target target/i386: correct fix for pcmpxstrx substring search 2020-06-12 11:10:39 -04:00
tcg tcg: Improve move ops in liveness_pass_2 2020-06-02 08:42:37 -07:00
tests target/i386: correct fix for pcmpxstrx substring search 2020-06-12 11:10:39 -04:00
tools/virtiofsd virtiofsd: remove symlink fallbacks 2020-06-01 18:44:27 +01:00
trace
ui audio: Let capture_callback handler use const buffer argument 2020-05-26 08:29:39 +02:00
util util/oslib: Returns the real thread identifier on FreeBSD and NetBSD 2020-06-10 12:10:48 -04:00
.cirrus.yml .cirrus.yml: bootstrap pkg unconditionally 2020-05-06 09:29:03 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore
.gitlab-ci.yml gitlab-ci: Determine the number of jobs dynamically 2020-05-28 11:01:38 +02:00
.gitmodules
.gitpublish
.mailmap MAINTAINERS: Change Aleksandar Rikalo's email address 2020-05-26 13:21:12 +02:00
.patchew.yml
.readthedocs.yml
.shippable.yml
.travis.yml travis.yml: Use clang++ in the Clang tests 2020-05-27 14:26:47 +01:00
arch_init.c arch_init: Remove unused 'qapi-commands-misc.h' include 2020-06-05 21:23:22 +02:00
balloon.c
block.c block: Drop @child_class from bdrv_child_perm() 2020-05-18 19:05:25 +02:00
blockdev-nbd.c
blockdev.c blockdev: Split off basic bitmap operations for qemu-img 2020-05-19 10:32:14 -05:00
blockjob.c block: Add BdrvChildRole to BdrvChild 2020-05-18 19:05:25 +02:00
bootdevice.c Drop more @errp parameters after previous commit 2020-05-15 07:08:14 +02:00
Changelog
CODING_STYLE.rst
configure configure: Do not ignore malloc value 2020-06-10 12:10:50 -04:00
COPYING
COPYING.LIB
cpus-common.c cpus-common: ensure auto-assigned cpu_indexes don't clash 2020-05-27 14:26:49 +01:00
cpus.c cpus: Fix botched configure_icount() error API violation fix 2020-06-10 12:09:59 -04:00
device_tree.c
disas.c disas: Let disas::read_memory() handler return EIO on error 2020-06-10 12:10:23 -04:00
dma-helpers.c
exec-vary.c
exec.c exec: set map length to zero when returning NULL 2020-06-10 12:10:50 -04:00
gdbstub.c gdbstub/linux-user: support debugging over a unix socket 2020-05-06 09:29:26 +01:00
gitdm.config
hmp-commands-info.hx memory: Make 'info mtree' not display disabled regions by default 2020-06-10 12:10:49 -04:00
hmp-commands.hx hmp: Simplify qom-set 2020-06-01 18:44:27 +01:00
ioport.c
iothread.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
job-qmp.c
job.c
Kconfig.host
LICENSE
MAINTAINERS accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
Makefile Makefile: Let the 'help' target list the helper targets 2020-06-10 12:09:38 -04:00
Makefile.objs vmbus: vmbus implementation 2020-06-10 12:09:40 -04:00
Makefile.target
memory_ldst.inc.c
memory_mapping.c
memory.c memory: Make 'info mtree' not display disabled regions by default 2020-06-10 12:10:49 -04:00
module-common.c
os-posix.c
os-win32.c
qdev-monitor.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx qemu-img: Add convert --bitmaps option 2020-05-28 13:16:30 -05:00
qemu-img.c qemu-img: Add convert --bitmaps option 2020-05-28 13:16:30 -05:00
qemu-io-cmds.c
qemu-io.c
qemu-keymap.c
qemu-nbd.c error: Use error_reportf_err() where appropriate 2020-05-27 07:45:30 +02:00
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx qemu-options: updates for abstract unix sockets 2020-05-20 10:34:53 +01:00
qemu-seccomp.c
qemu-storage-daemon.c
qemu.nsi
qemu.sasl
qtest.c
README.rst
replication.c
replication.h
rules.mak
thunk.c
tpm.c
trace-events
VERSION
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the CODING_STYLE.rst file.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://git.qemu.org/git/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://bugs.launchpad.net/qemu/>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_