c5f3014b82
Recently we moved a few options from QemuOptsLists in blockdev.c to
bdrv_runtime_opts in block.c in order to make them accissble using
blockdev-add. However, this has the side effect that these options are
missing from query-command-line-options now, and libvirt consequently
disables the corresponding feature.
This problem was reported as a regression for the 'discard' option,
introduced in commit 818584a4
. However, it is more general than that.
Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are
returned in query-command-line-options. For the future, libvirt is
advised to use QMP schema introspection for block device options.
Reported-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Tested-by: Michal Privoznik <mprivozn@redhat.com>
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
574 lines
16 KiB
C
574 lines
16 KiB
C
#include "qemu/osdep.h"
|
|
#include "qemu-common.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qemu/option.h"
|
|
#include "qemu/config-file.h"
|
|
#include "qmp-commands.h"
|
|
|
|
static QemuOptsList *vm_config_groups[48];
|
|
static QemuOptsList *drive_config_groups[5];
|
|
|
|
static QemuOptsList *find_list(QemuOptsList **lists, const char *group,
|
|
Error **errp)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; lists[i] != NULL; i++) {
|
|
if (strcmp(lists[i]->name, group) == 0)
|
|
break;
|
|
}
|
|
if (lists[i] == NULL) {
|
|
error_setg(errp, "There is no option group '%s'", group);
|
|
}
|
|
return lists[i];
|
|
}
|
|
|
|
QemuOptsList *qemu_find_opts(const char *group)
|
|
{
|
|
QemuOptsList *ret;
|
|
Error *local_err = NULL;
|
|
|
|
ret = find_list(vm_config_groups, group, &local_err);
|
|
if (local_err) {
|
|
error_report_err(local_err);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
QemuOpts *qemu_find_opts_singleton(const char *group)
|
|
{
|
|
QemuOptsList *list;
|
|
QemuOpts *opts;
|
|
|
|
list = qemu_find_opts(group);
|
|
assert(list);
|
|
opts = qemu_opts_find(list, NULL);
|
|
if (!opts) {
|
|
opts = qemu_opts_create(list, NULL, 0, &error_abort);
|
|
}
|
|
return opts;
|
|
}
|
|
|
|
static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
|
|
{
|
|
CommandLineParameterInfoList *param_list = NULL, *entry;
|
|
CommandLineParameterInfo *info;
|
|
int i;
|
|
|
|
for (i = 0; desc[i].name != NULL; i++) {
|
|
info = g_malloc0(sizeof(*info));
|
|
info->name = g_strdup(desc[i].name);
|
|
|
|
switch (desc[i].type) {
|
|
case QEMU_OPT_STRING:
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_STRING;
|
|
break;
|
|
case QEMU_OPT_BOOL:
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_BOOLEAN;
|
|
break;
|
|
case QEMU_OPT_NUMBER:
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_NUMBER;
|
|
break;
|
|
case QEMU_OPT_SIZE:
|
|
info->type = COMMAND_LINE_PARAMETER_TYPE_SIZE;
|
|
break;
|
|
}
|
|
|
|
if (desc[i].help) {
|
|
info->has_help = true;
|
|
info->help = g_strdup(desc[i].help);
|
|
}
|
|
if (desc[i].def_value_str) {
|
|
info->has_q_default = true;
|
|
info->q_default = g_strdup(desc[i].def_value_str);
|
|
}
|
|
|
|
entry = g_malloc0(sizeof(*entry));
|
|
entry->value = info;
|
|
entry->next = param_list;
|
|
param_list = entry;
|
|
}
|
|
|
|
return param_list;
|
|
}
|
|
|
|
/* remove repeated entry from the info list */
|
|
static void cleanup_infolist(CommandLineParameterInfoList *head)
|
|
{
|
|
CommandLineParameterInfoList *pre_entry, *cur, *del_entry;
|
|
|
|
cur = head;
|
|
while (cur->next) {
|
|
pre_entry = head;
|
|
while (pre_entry != cur->next) {
|
|
if (!strcmp(pre_entry->value->name, cur->next->value->name)) {
|
|
del_entry = cur->next;
|
|
cur->next = cur->next->next;
|
|
g_free(del_entry);
|
|
break;
|
|
}
|
|
pre_entry = pre_entry->next;
|
|
}
|
|
cur = cur->next;
|
|
}
|
|
}
|
|
|
|
/* merge the description items of two parameter infolists */
|
|
static void connect_infolist(CommandLineParameterInfoList *head,
|
|
CommandLineParameterInfoList *new)
|
|
{
|
|
CommandLineParameterInfoList *cur;
|
|
|
|
cur = head;
|
|
while (cur->next) {
|
|
cur = cur->next;
|
|
}
|
|
cur->next = new;
|
|
}
|
|
|
|
/* access all the local QemuOptsLists for drive option */
|
|
static CommandLineParameterInfoList *get_drive_infolist(void)
|
|
{
|
|
CommandLineParameterInfoList *head = NULL, *cur;
|
|
int i;
|
|
|
|
for (i = 0; drive_config_groups[i] != NULL; i++) {
|
|
if (!head) {
|
|
head = query_option_descs(drive_config_groups[i]->desc);
|
|
} else {
|
|
cur = query_option_descs(drive_config_groups[i]->desc);
|
|
connect_infolist(head, cur);
|
|
}
|
|
}
|
|
cleanup_infolist(head);
|
|
|
|
return head;
|
|
}
|
|
|
|
/* restore machine options that are now machine's properties */
|
|
static QemuOptsList machine_opts = {
|
|
.merge_lists = true,
|
|
.head = QTAILQ_HEAD_INITIALIZER(machine_opts.head),
|
|
.desc = {
|
|
{
|
|
.name = "type",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "emulated machine"
|
|
},{
|
|
.name = "accel",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "accelerator list",
|
|
},{
|
|
.name = "kernel_irqchip",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "use KVM in-kernel irqchip",
|
|
},{
|
|
.name = "kvm_shadow_mem",
|
|
.type = QEMU_OPT_SIZE,
|
|
.help = "KVM shadow MMU size",
|
|
},{
|
|
.name = "kernel",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "Linux kernel image file",
|
|
},{
|
|
.name = "initrd",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "Linux initial ramdisk file",
|
|
},{
|
|
.name = "append",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "Linux kernel command line",
|
|
},{
|
|
.name = "dtb",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "Linux kernel device tree file",
|
|
},{
|
|
.name = "dumpdtb",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "Dump current dtb to a file and quit",
|
|
},{
|
|
.name = "phandle_start",
|
|
.type = QEMU_OPT_NUMBER,
|
|
.help = "The first phandle ID we may generate dynamically",
|
|
},{
|
|
.name = "dt_compatible",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "Overrides the \"compatible\" property of the dt root node",
|
|
},{
|
|
.name = "dump-guest-core",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "Include guest memory in a core dump",
|
|
},{
|
|
.name = "mem-merge",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "enable/disable memory merge support",
|
|
},{
|
|
.name = "usb",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "Set on/off to enable/disable usb",
|
|
},{
|
|
.name = "firmware",
|
|
.type = QEMU_OPT_STRING,
|
|
.help = "firmware image",
|
|
},{
|
|
.name = "iommu",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "Set on/off to enable/disable Intel IOMMU (VT-d)",
|
|
},{
|
|
.name = "suppress-vmdesc",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "Set on to disable self-describing migration",
|
|
},{
|
|
.name = "aes-key-wrap",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "enable/disable AES key wrapping using the CPACF wrapping key",
|
|
},{
|
|
.name = "dea-key-wrap",
|
|
.type = QEMU_OPT_BOOL,
|
|
.help = "enable/disable DEA key wrapping using the CPACF wrapping key",
|
|
},
|
|
{ /* End of list */ }
|
|
}
|
|
};
|
|
|
|
CommandLineOptionInfoList *qmp_query_command_line_options(bool has_option,
|
|
const char *option,
|
|
Error **errp)
|
|
{
|
|
CommandLineOptionInfoList *conf_list = NULL, *entry;
|
|
CommandLineOptionInfo *info;
|
|
int i;
|
|
|
|
for (i = 0; vm_config_groups[i] != NULL; i++) {
|
|
if (!has_option || !strcmp(option, vm_config_groups[i]->name)) {
|
|
info = g_malloc0(sizeof(*info));
|
|
info->option = g_strdup(vm_config_groups[i]->name);
|
|
if (!strcmp("drive", vm_config_groups[i]->name)) {
|
|
info->parameters = get_drive_infolist();
|
|
} else if (!strcmp("machine", vm_config_groups[i]->name)) {
|
|
info->parameters = query_option_descs(machine_opts.desc);
|
|
} else {
|
|
info->parameters =
|
|
query_option_descs(vm_config_groups[i]->desc);
|
|
}
|
|
entry = g_malloc0(sizeof(*entry));
|
|
entry->value = info;
|
|
entry->next = conf_list;
|
|
conf_list = entry;
|
|
}
|
|
}
|
|
|
|
if (conf_list == NULL) {
|
|
error_setg(errp, "invalid option name: %s", option);
|
|
}
|
|
|
|
return conf_list;
|
|
}
|
|
|
|
QemuOptsList *qemu_find_opts_err(const char *group, Error **errp)
|
|
{
|
|
return find_list(vm_config_groups, group, errp);
|
|
}
|
|
|
|
void qemu_add_drive_opts(QemuOptsList *list)
|
|
{
|
|
int entries, i;
|
|
|
|
entries = ARRAY_SIZE(drive_config_groups);
|
|
entries--; /* keep list NULL terminated */
|
|
for (i = 0; i < entries; i++) {
|
|
if (drive_config_groups[i] == NULL) {
|
|
drive_config_groups[i] = list;
|
|
return;
|
|
}
|
|
}
|
|
fprintf(stderr, "ran out of space in drive_config_groups");
|
|
abort();
|
|
}
|
|
|
|
void qemu_add_opts(QemuOptsList *list)
|
|
{
|
|
int entries, i;
|
|
|
|
entries = ARRAY_SIZE(vm_config_groups);
|
|
entries--; /* keep list NULL terminated */
|
|
for (i = 0; i < entries; i++) {
|
|
if (vm_config_groups[i] == NULL) {
|
|
vm_config_groups[i] = list;
|
|
return;
|
|
}
|
|
}
|
|
fprintf(stderr, "ran out of space in vm_config_groups");
|
|
abort();
|
|
}
|
|
|
|
int qemu_set_option(const char *str)
|
|
{
|
|
Error *local_err = NULL;
|
|
char group[64], id[64], arg[64];
|
|
QemuOptsList *list;
|
|
QemuOpts *opts;
|
|
int rc, offset;
|
|
|
|
rc = sscanf(str, "%63[^.].%63[^.].%63[^=]%n", group, id, arg, &offset);
|
|
if (rc < 3 || str[offset] != '=') {
|
|
error_report("can't parse: \"%s\"", str);
|
|
return -1;
|
|
}
|
|
|
|
list = qemu_find_opts(group);
|
|
if (list == NULL) {
|
|
return -1;
|
|
}
|
|
|
|
opts = qemu_opts_find(list, id);
|
|
if (!opts) {
|
|
error_report("there is no %s \"%s\" defined",
|
|
list->name, id);
|
|
return -1;
|
|
}
|
|
|
|
qemu_opt_set(opts, arg, str + offset + 1, &local_err);
|
|
if (local_err) {
|
|
error_report_err(local_err);
|
|
return -1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
struct ConfigWriteData {
|
|
QemuOptsList *list;
|
|
FILE *fp;
|
|
};
|
|
|
|
static int config_write_opt(void *opaque, const char *name, const char *value,
|
|
Error **errp)
|
|
{
|
|
struct ConfigWriteData *data = opaque;
|
|
|
|
fprintf(data->fp, " %s = \"%s\"\n", name, value);
|
|
return 0;
|
|
}
|
|
|
|
static int config_write_opts(void *opaque, QemuOpts *opts, Error **errp)
|
|
{
|
|
struct ConfigWriteData *data = opaque;
|
|
const char *id = qemu_opts_id(opts);
|
|
|
|
if (id) {
|
|
fprintf(data->fp, "[%s \"%s\"]\n", data->list->name, id);
|
|
} else {
|
|
fprintf(data->fp, "[%s]\n", data->list->name);
|
|
}
|
|
qemu_opt_foreach(opts, config_write_opt, data, NULL);
|
|
fprintf(data->fp, "\n");
|
|
return 0;
|
|
}
|
|
|
|
void qemu_config_write(FILE *fp)
|
|
{
|
|
struct ConfigWriteData data = { .fp = fp };
|
|
QemuOptsList **lists = vm_config_groups;
|
|
int i;
|
|
|
|
fprintf(fp, "# qemu config file\n\n");
|
|
for (i = 0; lists[i] != NULL; i++) {
|
|
data.list = lists[i];
|
|
qemu_opts_foreach(data.list, config_write_opts, &data, NULL);
|
|
}
|
|
}
|
|
|
|
int qemu_config_parse(FILE *fp, QemuOptsList **lists, const char *fname)
|
|
{
|
|
char line[1024], group[64], id[64], arg[64], value[1024];
|
|
Location loc;
|
|
QemuOptsList *list = NULL;
|
|
Error *local_err = NULL;
|
|
QemuOpts *opts = NULL;
|
|
int res = -1, lno = 0;
|
|
|
|
loc_push_none(&loc);
|
|
while (fgets(line, sizeof(line), fp) != NULL) {
|
|
loc_set_file(fname, ++lno);
|
|
if (line[0] == '\n') {
|
|
/* skip empty lines */
|
|
continue;
|
|
}
|
|
if (line[0] == '#') {
|
|
/* comment */
|
|
continue;
|
|
}
|
|
if (sscanf(line, "[%63s \"%63[^\"]\"]", group, id) == 2) {
|
|
/* group with id */
|
|
list = find_list(lists, group, &local_err);
|
|
if (local_err) {
|
|
error_report_err(local_err);
|
|
goto out;
|
|
}
|
|
opts = qemu_opts_create(list, id, 1, NULL);
|
|
continue;
|
|
}
|
|
if (sscanf(line, "[%63[^]]]", group) == 1) {
|
|
/* group without id */
|
|
list = find_list(lists, group, &local_err);
|
|
if (local_err) {
|
|
error_report_err(local_err);
|
|
goto out;
|
|
}
|
|
opts = qemu_opts_create(list, NULL, 0, &error_abort);
|
|
continue;
|
|
}
|
|
value[0] = '\0';
|
|
if (sscanf(line, " %63s = \"%1023[^\"]\"", arg, value) == 2 ||
|
|
sscanf(line, " %63s = \"\"", arg) == 1) {
|
|
/* arg = value */
|
|
if (opts == NULL) {
|
|
error_report("no group defined");
|
|
goto out;
|
|
}
|
|
qemu_opt_set(opts, arg, value, &local_err);
|
|
if (local_err) {
|
|
error_report_err(local_err);
|
|
goto out;
|
|
}
|
|
continue;
|
|
}
|
|
error_report("parse error");
|
|
goto out;
|
|
}
|
|
if (ferror(fp)) {
|
|
error_report("error reading file");
|
|
goto out;
|
|
}
|
|
res = 0;
|
|
out:
|
|
loc_pop(&loc);
|
|
return res;
|
|
}
|
|
|
|
int qemu_read_config_file(const char *filename)
|
|
{
|
|
FILE *f = fopen(filename, "r");
|
|
int ret;
|
|
|
|
if (f == NULL) {
|
|
return -errno;
|
|
}
|
|
|
|
ret = qemu_config_parse(f, vm_config_groups, filename);
|
|
fclose(f);
|
|
|
|
if (ret == 0) {
|
|
return 0;
|
|
} else {
|
|
return -EINVAL;
|
|
}
|
|
}
|
|
|
|
static void config_parse_qdict_section(QDict *options, QemuOptsList *opts,
|
|
Error **errp)
|
|
{
|
|
QemuOpts *subopts;
|
|
QDict *subqdict;
|
|
QList *list = NULL;
|
|
Error *local_err = NULL;
|
|
size_t orig_size, enum_size;
|
|
char *prefix;
|
|
|
|
prefix = g_strdup_printf("%s.", opts->name);
|
|
qdict_extract_subqdict(options, &subqdict, prefix);
|
|
g_free(prefix);
|
|
orig_size = qdict_size(subqdict);
|
|
if (!orig_size) {
|
|
goto out;
|
|
}
|
|
|
|
subopts = qemu_opts_create(opts, NULL, 0, &local_err);
|
|
if (local_err) {
|
|
error_propagate(errp, local_err);
|
|
goto out;
|
|
}
|
|
|
|
qemu_opts_absorb_qdict(subopts, subqdict, &local_err);
|
|
if (local_err) {
|
|
error_propagate(errp, local_err);
|
|
goto out;
|
|
}
|
|
|
|
enum_size = qdict_size(subqdict);
|
|
if (enum_size < orig_size && enum_size) {
|
|
error_setg(errp, "Unknown option '%s' for [%s]",
|
|
qdict_first(subqdict)->key, opts->name);
|
|
goto out;
|
|
}
|
|
|
|
if (enum_size) {
|
|
/* Multiple, enumerated sections */
|
|
QListEntry *list_entry;
|
|
unsigned i = 0;
|
|
|
|
/* Not required anymore */
|
|
qemu_opts_del(subopts);
|
|
|
|
qdict_array_split(subqdict, &list);
|
|
if (qdict_size(subqdict)) {
|
|
error_setg(errp, "Unused option '%s' for [%s]",
|
|
qdict_first(subqdict)->key, opts->name);
|
|
goto out;
|
|
}
|
|
|
|
QLIST_FOREACH_ENTRY(list, list_entry) {
|
|
QDict *section = qobject_to_qdict(qlist_entry_obj(list_entry));
|
|
char *opt_name;
|
|
|
|
if (!section) {
|
|
error_setg(errp, "[%s] section (index %u) does not consist of "
|
|
"keys", opts->name, i);
|
|
goto out;
|
|
}
|
|
|
|
opt_name = g_strdup_printf("%s.%u", opts->name, i++);
|
|
subopts = qemu_opts_create(opts, opt_name, 1, &local_err);
|
|
g_free(opt_name);
|
|
if (local_err) {
|
|
error_propagate(errp, local_err);
|
|
goto out;
|
|
}
|
|
|
|
qemu_opts_absorb_qdict(subopts, section, &local_err);
|
|
if (local_err) {
|
|
error_propagate(errp, local_err);
|
|
qemu_opts_del(subopts);
|
|
goto out;
|
|
}
|
|
|
|
if (qdict_size(section)) {
|
|
error_setg(errp, "[%s] section doesn't support the option '%s'",
|
|
opts->name, qdict_first(section)->key);
|
|
qemu_opts_del(subopts);
|
|
goto out;
|
|
}
|
|
}
|
|
}
|
|
|
|
out:
|
|
QDECREF(subqdict);
|
|
QDECREF(list);
|
|
}
|
|
|
|
void qemu_config_parse_qdict(QDict *options, QemuOptsList **lists,
|
|
Error **errp)
|
|
{
|
|
int i;
|
|
Error *local_err = NULL;
|
|
|
|
for (i = 0; lists[i]; i++) {
|
|
config_parse_qdict_section(options, lists[i], &local_err);
|
|
if (local_err) {
|
|
error_propagate(errp, local_err);
|
|
return;
|
|
}
|
|
}
|
|
}
|