2562755ee7
The point of writing a macro embedded in a 'do { ... } while (0)'
loop (particularly if the macro has multiple statements or would
otherwise end with an 'if' statement) is so that the macro can be
used as a drop-in statement with the caller supplying the
trailing ';'. Although our coding style frowns on brace-less 'if':
if (cond)
statement;
else
something else;
that is the classic case where failure to use do/while(0) wrapping
would cause the 'else' to pair with any embedded 'if' in the macro
rather than the intended outer 'if'. But conversely, if the macro
includes an embedded ';', then the same brace-less coding style
would now have two statements, making the 'else' a syntax error
rather than pairing with the outer 'if'. Thus, even though our
coding style with required braces is not impacted, ending a macro
with ';' makes our code harder to port to projects that use
brace-less styles.
The change should have no semantic impact. I was not able to
fully compile-test all of the changes (as some of them are
examples of the ugly bit-rotting debug print statements that are
completely elided by default, and I didn't want to recompile
with the necessary -D witnesses - cleaning those up is left as a
bite-sized task for another day); I did, however, audit that for
all files touched, all callers of the changed macros DID supply
a trailing ';' at the callsite, and did not appear to be used
as part of a brace-less conditional.
Found mechanically via: $ git grep -B1 'while (0);' | grep -A1 \\\\
Signed-off-by: Eric Blake <eblake@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20171201232433.25193-7-eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
88 lines
3.1 KiB
C
88 lines
3.1 KiB
C
/*
|
|
* Utilities for working with ACPI tables
|
|
*
|
|
* Copyright (c) 2013 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Michael S. Tsirkin <mst@redhat.com>,
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#ifndef TEST_ACPI_UTILS_H
|
|
#define TEST_ACPI_UTILS_H
|
|
|
|
#include "hw/acpi/acpi-defs.h"
|
|
#include "libqtest.h"
|
|
|
|
/* DSDT and SSDTs format */
|
|
typedef struct {
|
|
AcpiTableHeader header;
|
|
gchar *aml; /* aml bytecode from guest */
|
|
gsize aml_len;
|
|
gchar *aml_file;
|
|
gchar *asl; /* asl code generated from aml */
|
|
gsize asl_len;
|
|
gchar *asl_file;
|
|
bool tmp_files_retain; /* do not delete the temp asl/aml */
|
|
} AcpiSdtTable;
|
|
|
|
#define ACPI_READ_FIELD(field, addr) \
|
|
do { \
|
|
memread(addr, &field, sizeof(field)); \
|
|
addr += sizeof(field); \
|
|
} while (0)
|
|
|
|
#define ACPI_READ_ARRAY_PTR(arr, length, addr) \
|
|
do { \
|
|
int idx; \
|
|
for (idx = 0; idx < length; ++idx) { \
|
|
ACPI_READ_FIELD(arr[idx], addr); \
|
|
} \
|
|
} while (0)
|
|
|
|
#define ACPI_READ_ARRAY(arr, addr) \
|
|
ACPI_READ_ARRAY_PTR(arr, sizeof(arr) / sizeof(arr[0]), addr)
|
|
|
|
#define ACPI_READ_TABLE_HEADER(table, addr) \
|
|
do { \
|
|
ACPI_READ_FIELD((table)->signature, addr); \
|
|
ACPI_READ_FIELD((table)->length, addr); \
|
|
ACPI_READ_FIELD((table)->revision, addr); \
|
|
ACPI_READ_FIELD((table)->checksum, addr); \
|
|
ACPI_READ_ARRAY((table)->oem_id, addr); \
|
|
ACPI_READ_ARRAY((table)->oem_table_id, addr); \
|
|
ACPI_READ_FIELD((table)->oem_revision, addr); \
|
|
ACPI_READ_ARRAY((table)->asl_compiler_id, addr); \
|
|
ACPI_READ_FIELD((table)->asl_compiler_revision, addr); \
|
|
} while (0)
|
|
|
|
#define ACPI_ASSERT_CMP(actual, expected) do { \
|
|
char ACPI_ASSERT_CMP_str[5] = {}; \
|
|
memcpy(ACPI_ASSERT_CMP_str, &actual, 4); \
|
|
g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \
|
|
} while (0)
|
|
|
|
#define ACPI_ASSERT_CMP64(actual, expected) do { \
|
|
char ACPI_ASSERT_CMP_str[9] = {}; \
|
|
memcpy(ACPI_ASSERT_CMP_str, &actual, 8); \
|
|
g_assert_cmpstr(ACPI_ASSERT_CMP_str, ==, expected); \
|
|
} while (0)
|
|
|
|
#define ACPI_READ_GENERIC_ADDRESS(field, addr) \
|
|
do { \
|
|
ACPI_READ_FIELD((field).space_id, addr); \
|
|
ACPI_READ_FIELD((field).bit_width, addr); \
|
|
ACPI_READ_FIELD((field).bit_offset, addr); \
|
|
ACPI_READ_FIELD((field).access_width, addr); \
|
|
ACPI_READ_FIELD((field).address, addr); \
|
|
} while (0)
|
|
|
|
|
|
uint8_t acpi_calc_checksum(const uint8_t *data, int len);
|
|
uint32_t acpi_find_rsdp_address(void);
|
|
void acpi_parse_rsdp_table(uint32_t addr, AcpiRsdpDescriptor *rsdp_table);
|
|
|
|
#endif /* TEST_ACPI_UTILS_H */
|