c40a254570
qemu_aio_coroutine_enter() is (indirectly) called recursively when processing co_queue_wakeup. This can lead to stack exhaustion. This patch rewrites co_queue_wakeup in an iterative fashion (instead of recursive) with bounded memory usage to prevent stack exhaustion. qemu_co_queue_run_restart() is inlined into qemu_aio_coroutine_enter() and the qemu_coroutine_enter() call is turned into a loop to avoid recursion. There is one change that is worth mentioning: Previously, when coroutine A queued coroutine B, qemu_co_queue_run_restart() entered coroutine B from coroutine A. If A was terminating then it would still stay alive until B yielded. After this patch B is entered by A's parent so that a A can be deleted immediately if it is terminating. It is safe to make this change since B could never interact with A if it was terminating anyway. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Message-id: 20180322152834.12656-3-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> |
||
|---|---|---|
| .. | ||
| acl.h | ||
| atomic.h | ||
| base64.h | ||
| bcd.h | ||
| bitmap.h | ||
| bitops.h | ||
| bswap.h | ||
| buffer.h | ||
| compiler.h | ||
| config-file.h | ||
| coroutine_int.h | ||
| coroutine.h | ||
| cpuid.h | ||
| crc32c.h | ||
| cutils.h | ||
| envlist.h | ||
| error-report.h | ||
| event_notifier.h | ||
| fifo8.h | ||
| fifo32.h | ||
| fprintf-fn.h | ||
| futex.h | ||
| hbitmap.h | ||
| help_option.h | ||
| host-utils.h | ||
| id.h | ||
| int128.h | ||
| iov.h | ||
| jhash.h | ||
| lockable.h | ||
| log-for-trace.h | ||
| log.h | ||
| main-loop.h | ||
| memfd.h | ||
| mmap-alloc.h | ||
| module.h | ||
| notify.h | ||
| option_int.h | ||
| option.h | ||
| osdep.h | ||
| path.h | ||
| processor.h | ||
| qdist.h | ||
| qht.h | ||
| queue.h | ||
| range.h | ||
| ratelimit.h | ||
| rcu_queue.h | ||
| rcu.h | ||
| readline.h | ||
| seqlock.h | ||
| sockets.h | ||
| stats64.h | ||
| sys_membarrier.h | ||
| systemd.h | ||
| thread-posix.h | ||
| thread-win32.h | ||
| thread.h | ||
| throttle-options.h | ||
| throttle.h | ||
| timed-average.h | ||
| timer.h | ||
| typedefs.h | ||
| unicode.h | ||
| uri.h | ||
| uuid.h | ||
| vfio-helpers.h | ||
| xattr.h | ||