883f2c591f
The 'hwaddr' type is defined in "exec/hwaddr.h" as:
hwaddr is the type of a physical address
(its size can be different from 'target_ulong').
All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx:
$ fgrep define include/exec/hwaddr.h
#define HWADDR_H
#define HWADDR_BITS 64
#define HWADDR_MAX UINT64_MAX
#define TARGET_FMT_plx "%016" PRIx64
^^^^^^
#define HWADDR_PRId PRId64
#define HWADDR_PRIi PRIi64
#define HWADDR_PRIo PRIo64
#define HWADDR_PRIu PRIu64
#define HWADDR_PRIx PRIx64
#define HWADDR_PRIX PRIX64
Since hwaddr's size can be *different* from target_ulong, it is
very confusing to read one of its format using the 'TARGET_FMT_'
prefix, normally used for the target_long / target_ulong types:
$ fgrep TARGET_FMT_ include/exec/cpu-defs.h
#define TARGET_FMT_lx "%08x"
#define TARGET_FMT_ld "%d"
#define TARGET_FMT_lu "%u"
#define TARGET_FMT_lx "%016" PRIx64
#define TARGET_FMT_ld "%" PRId64
#define TARGET_FMT_lu "%" PRIu64
Apparently this format was missed during commit a8170e5e97
("Rename target_phys_addr_t to hwaddr"), so complete it by
doing a bulk-rename with:
$ sed -i -e s/TARGET_FMT_plx/HWADDR_FMT_plx/g $(git grep -l TARGET_FMT_plx)
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230110212947.34557-1-philmd@linaro.org>
[thuth: Fix some warnings from checkpatch.pl along the way]
Signed-off-by: Thomas Huth <thuth@redhat.com>
27 lines
537 B
C
27 lines
537 B
C
/* Define hwaddr if it exists. */
|
|
|
|
#ifndef HWADDR_H
|
|
#define HWADDR_H
|
|
|
|
|
|
#define HWADDR_BITS 64
|
|
/* hwaddr is the type of a physical address (its size can
|
|
be different from 'target_ulong'). */
|
|
|
|
typedef uint64_t hwaddr;
|
|
#define HWADDR_MAX UINT64_MAX
|
|
#define HWADDR_FMT_plx "%016" PRIx64
|
|
#define HWADDR_PRId PRId64
|
|
#define HWADDR_PRIi PRIi64
|
|
#define HWADDR_PRIo PRIo64
|
|
#define HWADDR_PRIu PRIu64
|
|
#define HWADDR_PRIx PRIx64
|
|
#define HWADDR_PRIX PRIX64
|
|
|
|
typedef struct MemMapEntry {
|
|
hwaddr base;
|
|
hwaddr size;
|
|
} MemMapEntry;
|
|
|
|
#endif
|