OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
d05ab380db
qemu-e2k/block
History
Emanuele Giuseppe Esposito d05ab380db block: Mark drain related functions GRAPH_RDLOCK 
Draining recursively traverses the graph, therefore we need to make sure
that also such accesses to the graph are protected by the graph rdlock.

There are 3 different drain callers to consider:
1. drain in the main loop: no issue at all, rdlock is nop.
2. drain in an iothread: rdlock only works in main loop or coroutines,
   so disallow it.
3. drain in a coroutine (regardless of AioContext): the drain mechanism
   takes care of scheduling a BH in the bs->aio_context that will
   then take care of perform the actual draining. This is wrong,
   because as pointed in (2) if bs->aio_context is an iothread then
   rdlock won't work. Therefore change bdrv_co_yield_to_drain to
   schedule the BH in the main loop.

Caller (2) also implies that we need to modify test-bdrv-drain.c to
disallow draining in the iothreads.

For some places, we know that they will hold the lock, but we don't have
the GRAPH_RDLOCK annotations yet. In this case, add assume_graph_lock()
with a FIXME comment. These places will be removed once everything is
properly annotated.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20230929145157.45443-6-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2023-10-12 16:31:33 +02:00
..
export block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
monitor block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
accounting.c
aio_task.c
amend.c
backup.c
blkdebug.c
blkio.c block/blkio: add more comments on the fd passing handling 2023-08-03 11:28:43 -04:00
blklogwrites.c block: Mark bdrv_unref_child() GRAPH_WRLOCK 2023-09-20 17:46:01 +02:00
blkreplay.c
blkverify.c block: Mark bdrv_unref_child() GRAPH_WRLOCK 2023-09-20 17:46:01 +02:00
block-backend.c block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
block-copy.c block: spelling fixes 2023-09-08 13:08:52 +03:00
block-gen.h
block-ram-registrar.c
bochs.c bochs: mark more functions as coroutine_fns and GRAPH_RDLOCK 2023-06-28 09:46:24 +02:00
cloop.c cloop: mark more functions as coroutine_fns and GRAPH_RDLOCK 2023-06-28 09:46:27 +02:00
commit.c
copy-before-write.c block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions 2023-10-12 16:31:33 +02:00
copy-before-write.h
copy-on-read.c block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions 2023-10-12 16:31:33 +02:00
copy-on-read.h
coroutines.h
create.c
crypto.c block: Mark bdrv_parent_perms_conflict() and callers GRAPH_RDLOCK 2023-09-20 17:46:01 +02:00
crypto.h
curl.c
dirty-bitmap.c
dmg-bz2.c
dmg-lzfse.c
dmg.c dmg: mark more functions as coroutine_fns and GRAPH_RDLOCK 2023-06-28 09:46:28 +02:00
dmg.h
file-posix.c Block patches 2023-09-21 09:05:10 -04:00
file-win32.c
filter-compress.c
gluster.c cutils: Adjust signature of parse_uint[_full] 2023-06-02 12:27:19 -05:00
graph-lock.c block: Introduce bdrv_schedule_unref() 2023-09-20 17:46:01 +02:00
io_uring.c block/io_uring: convert to blk_io_plug_call() API 2023-06-01 07:34:03 -04:00
io.c block: Mark drain related functions GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
iscsi-opts.c
iscsi.c block/iscsi: Document why we use raw malloc() 2023-09-08 17:03:09 +02:00
linux-aio.c block: spelling fixes 2023-09-08 13:08:52 +03:00
meson.build block/meson.build: Restore alphabetical order of files 2023-09-08 17:03:09 +02:00
mirror.c block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions 2023-10-12 16:31:33 +02:00
nbd.c nbd/client: Accept 64-bit block status chunks 2023-10-05 11:02:08 -05:00
nfs.c cutils: Adjust signature of parse_uint[_full] 2023-06-02 12:27:19 -05:00
null.c
nvme.c block/nvme: invoke blk_io_plug_call() outside q->lock 2023-07-17 09:17:41 -04:00
parallels-ext.c
parallels.c parallels: naive implementation of parallels_co_pwrite_zeroes 2023-09-21 08:49:17 +02:00
parallels.h parallels: collect bitmap of used clusters at open 2023-09-21 08:47:34 +02:00
plug.c
preallocate.c preallocate: Don't poll during permission updates 2023-09-20 17:46:00 +02:00
progress_meter.c
qapi-sysemu.c block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
qapi.c block: Remove unnecessary variable in bdrv_block_device_info 2023-09-08 17:03:09 +02:00
qcow2-bitmap.c block/dirty-bitmap: Clean up local variable shadowing 2023-09-29 08:13:57 +02:00
qcow2-cache.c
qcow2-cluster.c block: use bdrv_co_debug_event in coroutine context 2023-06-28 09:46:34 +02:00
qcow2-refcount.c block: spelling fixes 2023-09-08 13:08:52 +03:00
qcow2-snapshot.c
qcow2-threads.c
qcow2.c block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions 2023-10-12 16:31:33 +02:00
qcow2.h qcow2: mark more functions as coroutine_fns and GRAPH_RDLOCK 2023-06-28 09:46:32 +02:00
qcow.c block: add BDRV_BLOCK_COMPRESSED flag for bdrv_block_status() 2023-09-20 17:46:01 +02:00
qed-check.c qed: mark more functions as coroutine_fns and GRAPH_RDLOCK 2023-06-28 09:46:20 +02:00
qed-cluster.c
qed-l2-cache.c
qed-table.c block: use bdrv_co_debug_event in coroutine context 2023-06-28 09:46:34 +02:00
qed.c block: mark mixed functions that can suspend 2023-09-26 18:09:08 +02:00
qed.h
quorum.c block: Mark bdrv_add/del_child() and caller GRAPH_WRLOCK 2023-09-20 17:46:01 +02:00
raw-format.c block: use bdrv_co_debug_event in coroutine context 2023-06-28 09:46:34 +02:00
rbd.c block: Clean up local variable shadowing 2023-09-29 08:13:57 +02:00
replication.c block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
reqlist.c
snapshot-access.c block: Make more BlockDriver definitions static 2023-09-08 17:03:09 +02:00
snapshot.c block: Mark bdrv_first_blk() and bdrv_is_root_node() GRAPH_RDLOCK 2023-10-12 16:31:33 +02:00
ssh.c
stream.c block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions 2023-10-12 16:31:33 +02:00
throttle-groups.c block: mark mixed functions that can suspend 2023-09-26 18:09:08 +02:00
throttle.c block/throttle-groups: Use ThrottleDirection instread of bool is_write 2023-08-29 10:49:24 +02:00
trace-events nbd/client: Accept 64-bit block status chunks 2023-10-05 11:02:08 -05:00
trace.h
vdi.c block/vdi: Clean up local variable shadowing 2023-09-29 08:13:57 +02:00
vhdx-endian.c
vhdx-log.c vhdx: mark more functions as coroutine_fns and GRAPH_RDLOCK 2023-06-28 09:46:30 +02:00
vhdx.c block: spelling fixes 2023-09-08 13:08:52 +03:00
vhdx.h block: spelling fixes 2023-09-08 13:08:52 +03:00
vmdk.c block: add BDRV_BLOCK_COMPRESSED flag for bdrv_block_status() 2023-09-20 17:46:01 +02:00
vpc.c block/vpc: Avoid dynamic stack allocation 2023-09-08 17:03:09 +02:00
vvfat.c block: convert more bdrv_is_allocated* and bdrv_block_status* calls to coroutine versions 2023-10-12 16:31:33 +02:00
win32-aio.c
write-threshold.c