b1be42803b
Currently macvtap based macvlan device is working in promiscuous mode, we want to implement mac-programming over macvtap through Libvirt for better performance. Design: QEMU notifies Libvirt when rx-filter config is changed in guest, then Libvirt query the rx-filter information by a monitor command, and sync the change to macvtap device. Related rx-filter config of the nic contains main mac, rx-mode items and vlan table. This patch adds a QMP event to notify management of rx-filter change, and adds a monitor command for management to query rx-filter information. Test: If we repeatedly add/remove vlan, and change macaddr of vlan interfaces in guest by a loop script. Result: The events will flood the QMP client(management), management takes too much resource to process the events. Event_throttle API (set rate to 1 ms) can avoid the events to flood QMP client, but it could cause an unexpected delay (~1ms), guests guests normally expect rx-filter updates immediately. So we use a flag for each nic to avoid events flooding, the event is emitted once until the query command is executed. The flag implementation could not introduce unexpected delay. There maybe exist an uncontrollable delay if we let Libvirt do the real change, guests normally expect rx-filter updates immediately. But it's another separate issue, we can investigate it when the work in Libvirt side is done. Michael S. Tsirkin: tweaked to enable events on start Michael S. Tsirkin: fixed not to crash when no id Michael S. Tsirkin: fold in patch: "additional fixes for mac-programming feature" Amos Kong: always notify QMP client if mactable is changed Amos Kong: return NULL list if no net client supports rx-filter query Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Amos Kong <akong@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
105 lines
3.2 KiB
C
105 lines
3.2 KiB
C
#ifndef MONITOR_H
|
|
#define MONITOR_H
|
|
|
|
#include "qemu-common.h"
|
|
#include "qapi/qmp/qerror.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "block/block.h"
|
|
#include "monitor/readline.h"
|
|
|
|
extern Monitor *cur_mon;
|
|
extern Monitor *default_mon;
|
|
|
|
/* flags for monitor_init */
|
|
#define MONITOR_IS_DEFAULT 0x01
|
|
#define MONITOR_USE_READLINE 0x02
|
|
#define MONITOR_USE_CONTROL 0x04
|
|
#define MONITOR_USE_PRETTY 0x08
|
|
|
|
/* flags for monitor commands */
|
|
#define MONITOR_CMD_ASYNC 0x0001
|
|
|
|
/* QMP events */
|
|
typedef enum MonitorEvent {
|
|
QEVENT_SHUTDOWN,
|
|
QEVENT_RESET,
|
|
QEVENT_POWERDOWN,
|
|
QEVENT_STOP,
|
|
QEVENT_RESUME,
|
|
QEVENT_VNC_CONNECTED,
|
|
QEVENT_VNC_INITIALIZED,
|
|
QEVENT_VNC_DISCONNECTED,
|
|
QEVENT_BLOCK_IO_ERROR,
|
|
QEVENT_RTC_CHANGE,
|
|
QEVENT_WATCHDOG,
|
|
QEVENT_SPICE_CONNECTED,
|
|
QEVENT_SPICE_INITIALIZED,
|
|
QEVENT_SPICE_DISCONNECTED,
|
|
QEVENT_BLOCK_JOB_COMPLETED,
|
|
QEVENT_BLOCK_JOB_CANCELLED,
|
|
QEVENT_BLOCK_JOB_ERROR,
|
|
QEVENT_BLOCK_JOB_READY,
|
|
QEVENT_DEVICE_DELETED,
|
|
QEVENT_DEVICE_TRAY_MOVED,
|
|
QEVENT_NIC_RX_FILTER_CHANGED,
|
|
QEVENT_SUSPEND,
|
|
QEVENT_SUSPEND_DISK,
|
|
QEVENT_WAKEUP,
|
|
QEVENT_BALLOON_CHANGE,
|
|
QEVENT_SPICE_MIGRATE_COMPLETED,
|
|
QEVENT_GUEST_PANICKED,
|
|
|
|
/* Add to 'monitor_event_names' array in monitor.c when
|
|
* defining new events here */
|
|
|
|
QEVENT_MAX,
|
|
} MonitorEvent;
|
|
|
|
int monitor_cur_is_qmp(void);
|
|
|
|
void monitor_protocol_event(MonitorEvent event, QObject *data);
|
|
void monitor_init(CharDriverState *chr, int flags);
|
|
|
|
int monitor_suspend(Monitor *mon);
|
|
void monitor_resume(Monitor *mon);
|
|
|
|
int monitor_read_bdrv_key_start(Monitor *mon, BlockDriverState *bs,
|
|
BlockDriverCompletionFunc *completion_cb,
|
|
void *opaque);
|
|
int monitor_read_block_device_key(Monitor *mon, const char *device,
|
|
BlockDriverCompletionFunc *completion_cb,
|
|
void *opaque);
|
|
|
|
int monitor_get_fd(Monitor *mon, const char *fdname, Error **errp);
|
|
int monitor_handle_fd_param(Monitor *mon, const char *fdname);
|
|
|
|
void monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)
|
|
GCC_FMT_ATTR(2, 0);
|
|
void monitor_printf(Monitor *mon, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
|
|
void monitor_print_filename(Monitor *mon, const char *filename);
|
|
void monitor_flush(Monitor *mon);
|
|
int monitor_set_cpu(int cpu_index);
|
|
int monitor_get_cpu_index(void);
|
|
|
|
typedef void (MonitorCompletion)(void *opaque, QObject *ret_data);
|
|
|
|
void monitor_set_error(Monitor *mon, QError *qerror);
|
|
void monitor_read_command(Monitor *mon, int show_prompt);
|
|
ReadLineState *monitor_get_rs(Monitor *mon);
|
|
int monitor_read_password(Monitor *mon, ReadLineFunc *readline_func,
|
|
void *opaque);
|
|
|
|
int qmp_qom_set(Monitor *mon, const QDict *qdict, QObject **ret);
|
|
|
|
int qmp_qom_get(Monitor *mon, const QDict *qdict, QObject **ret);
|
|
|
|
AddfdInfo *monitor_fdset_add_fd(int fd, bool has_fdset_id, int64_t fdset_id,
|
|
bool has_opaque, const char *opaque,
|
|
Error **errp);
|
|
int monitor_fdset_get_fd(int64_t fdset_id, int flags);
|
|
int monitor_fdset_dup_fd_add(int64_t fdset_id, int dup_fd);
|
|
int monitor_fdset_dup_fd_remove(int dup_fd);
|
|
int monitor_fdset_dup_fd_find(int dup_fd);
|
|
|
|
#endif /* !MONITOR_H */
|