OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
d2e49aad72
qemu-e2k/chardev
History
Markus Armbruster d2e49aad72 char: Fix socket with "type": "vsock" address 
Watch this:

    $ qemu-system-x86_64 -nodefaults -S -display none -qmp stdio
    {"QMP": {"version": {"qemu": {"micro": 91, "minor": 8, "major": 2}, "package": " (v2.8.0-1195-gf84141e-dirty)"}, "capabilities": []}}
    { "execute": "qmp_capabilities" }
    {"return": {}}
    { "execute": "chardev-add", "arguments": { "id": "chr0", "backend": { "type": "socket", "data": { "addr": { "type": "vsock", "data": { "cid": "CID", "port": "P" }}}}}}
    Aborted (core dumped)

Crashes because SocketAddress_to_str() is blissfully unaware of
SOCKET_ADDRESS_KIND_VSOCK.  Fix that.  Pick the output format to match
socket_parse(), just like the existing formats.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 1490895797-29094-3-git-send-email-armbru@redhat.com
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-04-03 17:11:39 +02:00
..
char-console.c char: move console in its own file 2017-01-31 23:31:21 +04:00
char-fd.c char: remove the right fd been watched in qemu_chr_fe_set_handlers() 2017-03-06 11:46:02 +08:00
char-fd.h char: move fd chardev in its own file 2017-01-31 23:31:21 +04:00
char-file.c char: move file chardev in its own file 2017-01-31 23:31:21 +04:00
char-io.c char: remove the right fd been watched in qemu_chr_fe_set_handlers() 2017-03-06 11:46:02 +08:00
char-io.h char: remove the right fd been watched in qemu_chr_fe_set_handlers() 2017-03-06 11:46:02 +08:00
char-mux.c
char-mux.h
char-null.c
char-parallel.c char: move parallel chardev in its own file 2017-01-31 23:31:21 +04:00
char-parallel.h char: move parallel chardev in its own file 2017-01-31 23:31:21 +04:00
char-pipe.c char: move pipe chardev in its own file 2017-01-31 23:31:21 +04:00
char-pty.c char: remove the right fd been watched in qemu_chr_fe_set_handlers() 2017-03-06 11:46:02 +08:00
char-ringbuf.c char: move ringbuf/memory to its own file 2017-01-31 23:31:20 +04:00
char-serial.c char: move serial chardev to its own file 2017-01-31 23:31:21 +04:00
char-serial.h char: move serial chardev to its own file 2017-01-31 23:31:21 +04:00
char-socket.c char: Fix socket with "type": "vsock" address 2017-04-03 17:11:39 +02:00
char-stdio.c char: move stdio in its own file 2017-01-31 23:31:21 +04:00
char-udp.c char: remove the right fd been watched in qemu_chr_fe_set_handlers() 2017-03-06 11:46:02 +08:00
char-win-stdio.c char: move win-stdio into its own file 2017-01-31 23:31:21 +04:00
char-win-stdio.h char: move win-stdio into its own file 2017-01-31 23:31:21 +04:00
char-win.c char: move win chardev base class in its own file 2017-01-31 23:31:21 +04:00
char-win.h char: move win chardev base class in its own file 2017-01-31 23:31:21 +04:00
char.c char: remove the right fd been watched in qemu_chr_fe_set_handlers() 2017-03-06 11:46:02 +08:00
Makefile.objs char: move parallel chardev in its own file 2017-01-31 23:31:21 +04:00