c3adb58fe0
Opening an encrypted image takes an additional step: setting the key. Between open and the key set, the image must not be used. We have some protection against accidental use in place: you can't unpause a guest while we're missing keys. You can, however, hot-plug block devices lacking keys into a running guest just fine, or insert media lacking keys. In the latter case, notifying the guest of the insert is delayed until the key is set, which may suffice to protect at least some guests in common usage. This patch makes the protection apply in more cases, in a rather heavy-handed way: it doesn't let you open encrypted images unless we're in a paused state. It doesn't extend the protection to users other than the guest (block jobs?). Use of runstate_check() from block.c is disgusting. Best I can do right now. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> |
||
|---|---|---|
| .. | ||
| arch-query-cpu-def.c | ||
| clock-warp.c | ||
| cpu-get-clock.c | ||
| cpu-get-icount.c | ||
| cpus.c | ||
| dump.c | ||
| fd-register.c | ||
| fdset-add-fd.c | ||
| fdset-find-fd.c | ||
| fdset-get-fd.c | ||
| fdset-remove-fd.c | ||
| gdbstub.c | ||
| get-fd.c | ||
| get-vm-name.c | ||
| iothread-lock.c | ||
| kvm.c | ||
| Makefile.objs | ||
| migr-blocker.c | ||
| mon-is-qmp.c | ||
| mon-print-filename.c | ||
| mon-printf.c | ||
| mon-protocol-event.c | ||
| mon-set-error.c | ||
| pci-drive-hot-add.c | ||
| qtest.c | ||
| reset.c | ||
| runstate-check.c | ||
| set-fd-handler.c | ||
| slirp.c | ||
| sysbus.c | ||
| uuid.c | ||
| vm-stop.c | ||
| vmstate.c | ||