163b3d1af2
Quoting ISO C99 6.7.8p4, "All the expressions in an initializer for an
object that has static storage duration shall be constant expressions or
string literals".
The compound literal produced by the make_floatx80() macro is not such a
constant expression, per 6.6p7-9. (An implementation may accept it,
according to 6.6p10, but is not required to.)
Therefore using "floatx80_zero" and make_floatx80() for initializing
"f2xm1_table" and "fpatan_table" is not portable. And gcc-4.8 in RHEL-7.6
actually chokes on them:
> target/i386/fpu_helper.c:871:5: error: initializer element is not constant
> { make_floatx80(0xbfff, 0x8000000000000000ULL),
> ^
We've had the make_floatx80_init() macro for this purpose since commit
|
||
|---|---|---|
| .. | ||
| hvf | ||
| arch_dump.c | ||
| arch_memory_mapping.c | ||
| bpt_helper.c | ||
| cc_helper_template.h | ||
| cc_helper.c | ||
| cpu-param.h | ||
| cpu-qom.h | ||
| cpu.c | ||
| cpu.h | ||
| excp_helper.c | ||
| fpu_helper.c | ||
| gdbstub.c | ||
| hax-all.c | ||
| hax-i386.h | ||
| hax-interface.h | ||
| hax-mem.c | ||
| hax-posix.c | ||
| hax-posix.h | ||
| hax-windows.c | ||
| hax-windows.h | ||
| helper.c | ||
| helper.h | ||
| hyperv-proto.h | ||
| hyperv-stub.c | ||
| hyperv.c | ||
| hyperv.h | ||
| int_helper.c | ||
| kvm_i386.h | ||
| kvm-stub.c | ||
| kvm.c | ||
| machine.c | ||
| Makefile.objs | ||
| mem_helper.c | ||
| misc_helper.c | ||
| monitor.c | ||
| mpx_helper.c | ||
| ops_sse_header.h | ||
| ops_sse.h | ||
| seg_helper.c | ||
| sev_i386.h | ||
| sev-stub.c | ||
| sev.c | ||
| shift_helper_template.h | ||
| smm_helper.c | ||
| svm_helper.c | ||
| svm.h | ||
| tcg-stub.c | ||
| trace-events | ||
| translate.c | ||
| whp-dispatch.h | ||
| whpx-all.c | ||
| xsave_helper.c | ||