6494d2c1fd
Some of the PMU hflags bits can go out of synch, for example a store to
MMCR0 with PMCjCE=1 fails to update hflags correctly and results in
hflags mismatch:
qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a003d)
This can be reproduced by running perf on a recent machine.
Some of the fragility here is the duplication of PMU hflags calculations.
This change consolidates that in a single place to update pmu-related
hflags, to be called after a well defined state changes.
The post-load PMU update is pulled out of the MSR update because it does
not depend on the MSR value.
Fixes: 8b3d1c49a9 ("target/ppc: Add new PMC HFLAGS")
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20230530130447.372617-1-npiggin@gmail.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
36 lines
1.2 KiB
C
36 lines
1.2 KiB
C
/*
|
|
* PowerPC emulation special registers manipulation helpers for qemu.
|
|
*
|
|
* Copyright (c) 2003-2007 Jocelyn Mayer
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef HELPER_REGS_H
|
|
#define HELPER_REGS_H
|
|
|
|
void hreg_swap_gpr_tgpr(CPUPPCState *env);
|
|
void hreg_compute_hflags(CPUPPCState *env);
|
|
void hreg_update_pmu_hflags(CPUPPCState *env);
|
|
void cpu_interrupt_exittb(CPUState *cs);
|
|
int hreg_store_msr(CPUPPCState *env, target_ulong value, int alter_hv);
|
|
|
|
#ifdef CONFIG_USER_ONLY
|
|
static inline void check_tlb_flush(CPUPPCState *env, bool global) { }
|
|
#else
|
|
void check_tlb_flush(CPUPPCState *env, bool global);
|
|
#endif
|
|
|
|
#endif /* HELPER_REGS_H */
|