5f3ebbc86d
Don't embed ibreak exception generation into TB and don't invalidate TB on ibreak address change. Add CPUBreakpoint pointers to xtensa CPUArchState, use cpu_breakpoint_insert/cpu_breakpoint_remove_by_ref to manage ibreak breakpoints and provide TCGCPUOps::debug_check_breakpoint callback that recognizes valid instruction breakpoints. Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-ID: <20231130171920.3798954-2-jcmvbkbc@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
144 lines
5.1 KiB
C
144 lines
5.1 KiB
C
/*
|
|
* Copyright (c) 2011 - 2019, Max Filippov, Open Source and Linux Lab.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
* * Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of the Open Source and Linux Lab nor the
|
|
* names of its contributors may be used to endorse or promote products
|
|
* derived from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
|
|
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
|
|
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
|
|
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
|
|
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
|
|
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/log.h"
|
|
#include "cpu.h"
|
|
#include "exec/helper-proto.h"
|
|
#include "qemu/host-utils.h"
|
|
#include "exec/exec-all.h"
|
|
#include "exec/address-spaces.h"
|
|
|
|
void HELPER(wsr_ibreakenable)(CPUXtensaState *env, uint32_t v)
|
|
{
|
|
CPUState *cs = env_cpu(env);
|
|
uint32_t change = v ^ env->sregs[IBREAKENABLE];
|
|
unsigned i;
|
|
|
|
for (i = 0; i < env->config->nibreak; ++i) {
|
|
if (change & (1 << i)) {
|
|
if (v & (1 << i)) {
|
|
cpu_breakpoint_insert(cs, env->sregs[IBREAKA + i],
|
|
BP_CPU, &env->cpu_breakpoint[i]);
|
|
} else {
|
|
cpu_breakpoint_remove_by_ref(cs, env->cpu_breakpoint[i]);
|
|
env->cpu_breakpoint[i] = NULL;
|
|
}
|
|
}
|
|
}
|
|
env->sregs[IBREAKENABLE] = v & ((1 << env->config->nibreak) - 1);
|
|
}
|
|
|
|
void HELPER(wsr_ibreaka)(CPUXtensaState *env, uint32_t i, uint32_t v)
|
|
{
|
|
if (env->sregs[IBREAKENABLE] & (1 << i) && env->sregs[IBREAKA + i] != v) {
|
|
CPUState *cs = env_cpu(env);
|
|
|
|
cpu_breakpoint_remove_by_ref(cs, env->cpu_breakpoint[i]);
|
|
cpu_breakpoint_insert(cs, v, BP_CPU, &env->cpu_breakpoint[i]);
|
|
}
|
|
env->sregs[IBREAKA + i] = v;
|
|
}
|
|
|
|
bool xtensa_debug_check_breakpoint(CPUState *cs)
|
|
{
|
|
XtensaCPU *cpu = XTENSA_CPU(cs);
|
|
CPUXtensaState *env = &cpu->env;
|
|
unsigned int i;
|
|
|
|
if (xtensa_get_cintlevel(env) >= env->config->debug_level) {
|
|
return false;
|
|
}
|
|
for (i = 0; i < env->config->nibreak; ++i) {
|
|
if (env->sregs[IBREAKENABLE] & (1 << i) &&
|
|
env->sregs[IBREAKA + i] == env->pc) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
static void set_dbreak(CPUXtensaState *env, unsigned i, uint32_t dbreaka,
|
|
uint32_t dbreakc)
|
|
{
|
|
CPUState *cs = env_cpu(env);
|
|
int flags = BP_CPU | BP_STOP_BEFORE_ACCESS;
|
|
uint32_t mask = dbreakc | ~DBREAKC_MASK;
|
|
|
|
if (env->cpu_watchpoint[i]) {
|
|
cpu_watchpoint_remove_by_ref(cs, env->cpu_watchpoint[i]);
|
|
}
|
|
if (dbreakc & DBREAKC_SB) {
|
|
flags |= BP_MEM_WRITE;
|
|
}
|
|
if (dbreakc & DBREAKC_LB) {
|
|
flags |= BP_MEM_READ;
|
|
}
|
|
/* contiguous mask after inversion is one less than some power of 2 */
|
|
if ((~mask + 1) & ~mask) {
|
|
qemu_log_mask(LOG_GUEST_ERROR,
|
|
"DBREAKC mask is not contiguous: 0x%08x\n", dbreakc);
|
|
/* cut mask after the first zero bit */
|
|
mask = 0xffffffff << (32 - clo32(mask));
|
|
}
|
|
if (cpu_watchpoint_insert(cs, dbreaka & mask, ~mask + 1,
|
|
flags, &env->cpu_watchpoint[i])) {
|
|
env->cpu_watchpoint[i] = NULL;
|
|
qemu_log_mask(LOG_GUEST_ERROR,
|
|
"Failed to set data breakpoint at 0x%08x/%d\n",
|
|
dbreaka & mask, ~mask + 1);
|
|
}
|
|
}
|
|
|
|
void HELPER(wsr_dbreaka)(CPUXtensaState *env, uint32_t i, uint32_t v)
|
|
{
|
|
uint32_t dbreakc = env->sregs[DBREAKC + i];
|
|
|
|
if ((dbreakc & DBREAKC_SB_LB) &&
|
|
env->sregs[DBREAKA + i] != v) {
|
|
set_dbreak(env, i, v, dbreakc);
|
|
}
|
|
env->sregs[DBREAKA + i] = v;
|
|
}
|
|
|
|
void HELPER(wsr_dbreakc)(CPUXtensaState *env, uint32_t i, uint32_t v)
|
|
{
|
|
if ((env->sregs[DBREAKC + i] ^ v) & (DBREAKC_SB_LB | DBREAKC_MASK)) {
|
|
if (v & DBREAKC_SB_LB) {
|
|
set_dbreak(env, i, env->sregs[DBREAKA + i], v);
|
|
} else {
|
|
if (env->cpu_watchpoint[i]) {
|
|
CPUState *cs = env_cpu(env);
|
|
|
|
cpu_watchpoint_remove_by_ref(cs, env->cpu_watchpoint[i]);
|
|
env->cpu_watchpoint[i] = NULL;
|
|
}
|
|
}
|
|
}
|
|
env->sregs[DBREAKC + i] = v;
|
|
}
|