ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
54 lines
1.3 KiB
C
54 lines
1.3 KiB
C
/*
|
|
* Virtio RNG Support
|
|
*
|
|
* Copyright Red Hat, Inc. 2012
|
|
* Copyright Amit Shah <amit.shah@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* (at your option) any later version. See the COPYING file in the
|
|
* top-level directory.
|
|
*/
|
|
|
|
#ifndef QEMU_VIRTIO_RNG_H
|
|
#define QEMU_VIRTIO_RNG_H
|
|
|
|
#include "hw/virtio/virtio.h"
|
|
#include "sysemu/rng.h"
|
|
#include "sysemu/rng-random.h"
|
|
#include "standard-headers/linux/virtio_rng.h"
|
|
|
|
#define TYPE_VIRTIO_RNG "virtio-rng-device"
|
|
#define VIRTIO_RNG(obj) \
|
|
OBJECT_CHECK(VirtIORNG, (obj), TYPE_VIRTIO_RNG)
|
|
#define VIRTIO_RNG_GET_PARENT_CLASS(obj) \
|
|
OBJECT_GET_PARENT_CLASS(obj, TYPE_VIRTIO_RNG)
|
|
|
|
struct VirtIORNGConf {
|
|
RngBackend *rng;
|
|
uint64_t max_bytes;
|
|
uint32_t period_ms;
|
|
RngRandom *default_backend;
|
|
};
|
|
|
|
typedef struct VirtIORNG {
|
|
VirtIODevice parent_obj;
|
|
|
|
/* Only one vq - guest puts buffer(s) on it when it needs entropy */
|
|
VirtQueue *vq;
|
|
|
|
VirtIORNGConf conf;
|
|
|
|
RngBackend *rng;
|
|
|
|
/* We purposefully don't migrate this state. The quota will reset on the
|
|
* destination as a result. Rate limiting is host state, not guest state.
|
|
*/
|
|
QEMUTimer *rate_limit_timer;
|
|
int64_t quota_remaining;
|
|
bool activate_timer;
|
|
|
|
VMChangeStateEntry *vmstate;
|
|
} VirtIORNG;
|
|
|
|
#endif
|