qemu-e2k/hw/rdma/vmw
Stefan Hajnoczi f93cfdc583 hw/rdma: avoid suspicious strncpy() use
gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled
reports the following error:

  CC      x86_64-softmmu/hw/rdma/vmw/pvrdma_dev_ring.o
In file included from /usr/include/string.h:495,
                 from include/qemu/osdep.h:101,
                 from hw/rdma/vmw/pvrdma_dev_ring.c:16:
In function ‘strncpy’,
    inlined from ‘pvrdma_ring_init’ at hw/rdma/vmw/pvrdma_dev_ring.c:33:5:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 32 equals destination size [-Werror=stringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Use pstrcpy() instead of strncpy().  It is guaranteed to NUL-terminate
strings.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Yuval Shaia <yuval.shaia.ml.gmail.com>
Message-Id: <20200316160702.478964-3-stefanha@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
2020-03-21 19:21:20 +02:00
..
pvrdma.h hw/pvrdma: Collect debugging statistics 2019-03-16 15:52:44 +02:00
pvrdma_cmd.c Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00
pvrdma_dev_ring.c hw/rdma: avoid suspicious strncpy() use 2020-03-21 19:21:20 +02:00
pvrdma_dev_ring.h Clean up includes 2018-12-20 10:29:08 +01:00
pvrdma_main.c qdev: set properties with device_class_set_props() 2020-01-24 20:59:15 +01:00
pvrdma_qp_ops.c misc: Replace zero-length arrays with flexible array member (automatic) 2020-03-16 22:07:42 +01:00
pvrdma_qp_ops.h Clean up header guards that don't match their file name 2019-05-13 08:58:55 +02:00
trace-events trace-events: Shorten file names in comments 2019-03-22 16:18:07 +00:00