54aa3de72e
Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use QAPI_LIST_PREPEND(). But places where we must keep the list in order by appending remain open-coded until later patches. Note that as a side effect, this also performs a cleanup of two minor issues in qga/commands-posix.c: the old code was performing new = g_malloc0(sizeof(*ret)); which 1) is confusing because you have to verify whether 'new' and 'ret' are variables with the same type, and 2) would conflict with C++ compilation (not an actual problem for this file, but makes copy-and-paste harder). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20201113011340.463563-5-eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> [Straightforward conflicts due to commita8aa94b5f8
"qga: update schema for guest-get-disks 'dependents' field" and commita10b453a52
"target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c" resolved. Commit message tweaked.] Signed-off-by: Markus Armbruster <armbru@redhat.com>
200 lines
5.8 KiB
C
200 lines
5.8 KiB
C
/*
|
|
* QAPI Clone Visitor unit-tests.
|
|
*
|
|
* Copyright (C) 2016 Red Hat Inc.
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "qemu-common.h"
|
|
#include "qapi/clone-visitor.h"
|
|
#include "test-qapi-visit.h"
|
|
|
|
static void test_clone_struct(void)
|
|
{
|
|
UserDefOne *src, *dst;
|
|
|
|
src = g_new0(UserDefOne, 1);
|
|
src->integer = 42;
|
|
src->string = g_strdup("Hello");
|
|
src->has_enum1 = false;
|
|
src->enum1 = ENUM_ONE_VALUE2;
|
|
|
|
dst = QAPI_CLONE(UserDefOne, src);
|
|
g_assert(dst);
|
|
g_assert_cmpint(dst->integer, ==, 42);
|
|
g_assert(dst->string != src->string);
|
|
g_assert_cmpstr(dst->string, ==, "Hello");
|
|
g_assert_cmpint(dst->has_enum1, ==, false);
|
|
/* Our implementation does this, but it is not required:
|
|
g_assert_cmpint(dst->enum1, ==, ENUM_ONE_VALUE2);
|
|
*/
|
|
|
|
qapi_free_UserDefOne(src);
|
|
qapi_free_UserDefOne(dst);
|
|
}
|
|
|
|
static void test_clone_alternate(void)
|
|
{
|
|
AltEnumBool *b_src, *s_src, *b_dst, *s_dst;
|
|
|
|
b_src = g_new0(AltEnumBool, 1);
|
|
b_src->type = QTYPE_QBOOL;
|
|
b_src->u.b = true;
|
|
s_src = g_new0(AltEnumBool, 1);
|
|
s_src->type = QTYPE_QSTRING;
|
|
s_src->u.e = ENUM_ONE_VALUE1;
|
|
|
|
b_dst = QAPI_CLONE(AltEnumBool, b_src);
|
|
g_assert(b_dst);
|
|
g_assert_cmpint(b_dst->type, ==, b_src->type);
|
|
g_assert_cmpint(b_dst->u.b, ==, b_src->u.b);
|
|
s_dst = QAPI_CLONE(AltEnumBool, s_src);
|
|
g_assert(s_dst);
|
|
g_assert_cmpint(s_dst->type, ==, s_src->type);
|
|
g_assert_cmpint(s_dst->u.e, ==, s_src->u.e);
|
|
|
|
qapi_free_AltEnumBool(b_src);
|
|
qapi_free_AltEnumBool(s_src);
|
|
qapi_free_AltEnumBool(b_dst);
|
|
qapi_free_AltEnumBool(s_dst);
|
|
}
|
|
|
|
static void test_clone_list_union(void)
|
|
{
|
|
uint8List *src = NULL, *dst;
|
|
uint8List *tmp = NULL;
|
|
int i;
|
|
|
|
/* Build list in reverse */
|
|
for (i = 10; i; i--) {
|
|
QAPI_LIST_PREPEND(src, i);
|
|
}
|
|
|
|
dst = QAPI_CLONE(uint8List, src);
|
|
for (tmp = dst, i = 1; i <= 10; i++) {
|
|
g_assert(tmp);
|
|
g_assert_cmpint(tmp->value, ==, i);
|
|
tmp = tmp->next;
|
|
}
|
|
g_assert(!tmp);
|
|
|
|
qapi_free_uint8List(src);
|
|
qapi_free_uint8List(dst);
|
|
}
|
|
|
|
static void test_clone_empty(void)
|
|
{
|
|
Empty2 *src, *dst;
|
|
|
|
src = g_new0(Empty2, 1);
|
|
dst = QAPI_CLONE(Empty2, src);
|
|
g_assert(dst);
|
|
qapi_free_Empty2(src);
|
|
qapi_free_Empty2(dst);
|
|
}
|
|
|
|
static void test_clone_complex1(void)
|
|
{
|
|
UserDefListUnion *src, *dst;
|
|
|
|
src = g_new0(UserDefListUnion, 1);
|
|
src->type = USER_DEF_LIST_UNION_KIND_STRING;
|
|
|
|
dst = QAPI_CLONE(UserDefListUnion, src);
|
|
g_assert(dst);
|
|
g_assert_cmpint(dst->type, ==, src->type);
|
|
g_assert(!dst->u.string.data);
|
|
|
|
qapi_free_UserDefListUnion(src);
|
|
qapi_free_UserDefListUnion(dst);
|
|
}
|
|
|
|
static void test_clone_complex2(void)
|
|
{
|
|
WrapAlternate *src, *dst;
|
|
|
|
src = g_new0(WrapAlternate, 1);
|
|
src->alt = g_new(UserDefAlternate, 1);
|
|
src->alt->type = QTYPE_QDICT;
|
|
src->alt->u.udfu.integer = 42;
|
|
/* Clone intentionally converts NULL into "" for strings */
|
|
src->alt->u.udfu.string = NULL;
|
|
src->alt->u.udfu.enum1 = ENUM_ONE_VALUE3;
|
|
src->alt->u.udfu.u.value3.intb = 99;
|
|
src->alt->u.udfu.u.value3.has_a_b = true;
|
|
src->alt->u.udfu.u.value3.a_b = true;
|
|
|
|
dst = QAPI_CLONE(WrapAlternate, src);
|
|
g_assert(dst);
|
|
g_assert(dst->alt);
|
|
g_assert_cmpint(dst->alt->type, ==, QTYPE_QDICT);
|
|
g_assert_cmpint(dst->alt->u.udfu.integer, ==, 42);
|
|
g_assert_cmpstr(dst->alt->u.udfu.string, ==, "");
|
|
g_assert_cmpint(dst->alt->u.udfu.enum1, ==, ENUM_ONE_VALUE3);
|
|
g_assert_cmpint(dst->alt->u.udfu.u.value3.intb, ==, 99);
|
|
g_assert_cmpint(dst->alt->u.udfu.u.value3.has_a_b, ==, true);
|
|
g_assert_cmpint(dst->alt->u.udfu.u.value3.a_b, ==, true);
|
|
|
|
qapi_free_WrapAlternate(src);
|
|
qapi_free_WrapAlternate(dst);
|
|
}
|
|
|
|
static void test_clone_complex3(void)
|
|
{
|
|
__org_qemu_x_Struct2 *src, *dst;
|
|
__org_qemu_x_Union1List *tmp;
|
|
|
|
src = g_new0(__org_qemu_x_Struct2, 1);
|
|
tmp = src->array = g_new0(__org_qemu_x_Union1List, 1);
|
|
tmp->value = g_new0(__org_qemu_x_Union1, 1);
|
|
tmp->value->type = ORG_QEMU_X_UNION1_KIND___ORG_QEMU_X_BRANCH;
|
|
tmp->value->u.__org_qemu_x_branch.data = g_strdup("one");
|
|
tmp = tmp->next = g_new0(__org_qemu_x_Union1List, 1);
|
|
tmp->value = g_new0(__org_qemu_x_Union1, 1);
|
|
tmp->value->type = ORG_QEMU_X_UNION1_KIND___ORG_QEMU_X_BRANCH;
|
|
tmp->value->u.__org_qemu_x_branch.data = g_strdup("two");
|
|
tmp = tmp->next = g_new0(__org_qemu_x_Union1List, 1);
|
|
tmp->value = g_new0(__org_qemu_x_Union1, 1);
|
|
tmp->value->type = ORG_QEMU_X_UNION1_KIND___ORG_QEMU_X_BRANCH;
|
|
tmp->value->u.__org_qemu_x_branch.data = g_strdup("three");
|
|
|
|
dst = QAPI_CLONE(__org_qemu_x_Struct2, src);
|
|
g_assert(dst);
|
|
tmp = dst->array;
|
|
g_assert(tmp);
|
|
g_assert(tmp->value);
|
|
g_assert_cmpstr(tmp->value->u.__org_qemu_x_branch.data, ==, "one");
|
|
tmp = tmp->next;
|
|
g_assert(tmp);
|
|
g_assert(tmp->value);
|
|
g_assert_cmpstr(tmp->value->u.__org_qemu_x_branch.data, ==, "two");
|
|
tmp = tmp->next;
|
|
g_assert(tmp);
|
|
g_assert(tmp->value);
|
|
g_assert_cmpstr(tmp->value->u.__org_qemu_x_branch.data, ==, "three");
|
|
tmp = tmp->next;
|
|
g_assert(!tmp);
|
|
|
|
qapi_free___org_qemu_x_Struct2(src);
|
|
qapi_free___org_qemu_x_Struct2(dst);
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
g_test_add_func("/visitor/clone/struct", test_clone_struct);
|
|
g_test_add_func("/visitor/clone/alternate", test_clone_alternate);
|
|
g_test_add_func("/visitor/clone/list_union", test_clone_list_union);
|
|
g_test_add_func("/visitor/clone/empty", test_clone_empty);
|
|
g_test_add_func("/visitor/clone/complex1", test_clone_complex1);
|
|
g_test_add_func("/visitor/clone/complex2", test_clone_complex2);
|
|
g_test_add_func("/visitor/clone/complex3", test_clone_complex3);
|
|
|
|
return g_test_run();
|
|
}
|