475fc97d09
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. amdvi_realize() is wrong that way: it passes @errp to qdev_realize(), object_property_get_int(), and msi_init() without checking it. I can't tell offhand whether qdev_realize() can fail here. Fix by checking it for failure. object_property_get_int() can't. Fix by passing &error_abort instead. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20200630090351.1247703-22-armbru@redhat.com> |
||
|---|---|---|
| .. | ||
| kvm | ||
| xen | ||
| acpi-build.c | ||
| acpi-build.h | ||
| acpi-common.c | ||
| acpi-common.h | ||
| amd_iommu.c | ||
| amd_iommu.h | ||
| e820_memory_layout.c | ||
| e820_memory_layout.h | ||
| fw_cfg.c | ||
| fw_cfg.h | ||
| intel_iommu_internal.h | ||
| intel_iommu.c | ||
| Kconfig | ||
| kvmvapic.c | ||
| Makefile.objs | ||
| microvm.c | ||
| multiboot.c | ||
| multiboot.h | ||
| pc_piix.c | ||
| pc_q35.c | ||
| pc_sysfw.c | ||
| pc.c | ||
| port92.c | ||
| trace-events | ||
| vmmouse.c | ||
| vmport.c | ||
| x86-iommu-stub.c | ||
| x86-iommu.c | ||
| x86.c | ||