Eduardo Habkost e90f2a8c3e qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable ... cannot_instantiate_with_device_add_yet was introduced by commit efec3dd631 to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=true lines in the code. Today (3 years later) this number has not shrunk: we now have 57 cannot_instantiate_with_device_add_yet=true lines. I think it is safe to say it is not a temporary measure, and we won't see the flag go away soon. Instead of a long field name that misleads people to believe it is temporary, replace it a shorter and less misleading field: user_creatable. Except for code comments, changes were generated using the following Coccinelle patch: @@ expression DC; @@ ( -DC->cannot_instantiate_with_device_add_yet = false; +DC->user_creatable = true; | -DC->cannot_instantiate_with_device_add_yet = true; +DC->user_creatable = false; ) @@ typedef ObjectClass; expression dc; identifier class, data; @@ static void device_class_init(ObjectClass *class, void *data) { ... dc->hotpluggable = true; +dc->user_creatable = true; ... } @@ @@ struct DeviceClass { ... -bool cannot_instantiate_with_device_add_yet; +bool user_creatable; ... } @@ expression DC; @@ ( -!DC->cannot_instantiate_with_device_add_yet +DC->user_creatable | -DC->cannot_instantiate_with_device_add_yet +!DC->user_creatable ) Cc: Alistair Francis <alistair.francis@xilinx.com> Cc: Laszlo Ersek <lersek@redhat.com> Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: Markus Armbruster <armbru@redhat.com> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: Thomas Huth <thuth@redhat.com> Acked-by: Alistair Francis <alistair.francis@xilinx.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Acked-by: Marcel Apfelbaum <marcel@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20170503203604.31462-2-ehabkost@redhat.com> [ehabkost: kept "TODO remove once we're there" comment] Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>		2017-05-17 10:37:00 -03:00
..
fsl_etsec
rocker
allwinner_emac.c
cadence_gem.c	cadence_gem: Make the revision a property	2017-04-20 17:39:17 +01:00
dp8393x.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00
e1000_regs.h
e1000.c	e1000: disable debug by default	2017-03-31 08:48:13 +08:00
e1000e_core.c
e1000e_core.h
e1000e.c	e1000e: correctly tear down MSI-X memory regions	2017-03-14 15:39:55 +08:00
e1000x_common.c
e1000x_common.h
eepro100.c
etraxfs_eth.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00
ftgmac100.c	net/ftgmac100: add a 'aspeed' property	2017-04-25 19:17:25 +08:00
imx_fec.c
lan9118.c
lance.c	qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable	2017-05-17 10:37:00 -03:00
Makefile.objs	net: add FTGMAC100 support	2017-04-24 11:30:03 +08:00
mcf_fec.c	hw/net: implement MIB counters in mcf_fec driver	2017-03-14 15:39:55 +08:00
milkymist-minimac2.c
mipsnet.c
ne2000-isa.c
ne2000.c
ne2000.h
net_rx_pkt.c	NetRxPkt: Remove code duplication in net_rx_pkt_pull_data()	2017-03-06 11:46:02 +08:00
net_rx_pkt.h
net_tx_pkt.c
net_tx_pkt.h
opencores_eth.c
pcnet-pci.c
pcnet.c
pcnet.h
rtl8139.c
smc91c111.c
spapr_llan.c
stellaris_enet.c
trace-events
vhost_net.c
virtio-net.c	virtio-net: avoid call tap_enable when there's only one queue	2017-03-31 08:48:13 +08:00
vmware_utils.h
vmxnet3.c	vmxnet3: VMStatify rx/tx q_descr and int_state	2017-03-06 11:46:02 +08:00
vmxnet3.h
vmxnet_debug.h
xen_nic.c
xgmac.c
xilinx_axienet.c
xilinx_ethlite.c