118cafff25
This test tries to build a packet whose size is greater than INT_MAX which tries to trigger integer overflow in qemu_net_queue_append_iov() which may result OOB. Signed-off-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-id: 20181204035347.6148-6-jasowang@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
324 lines
9.0 KiB
C
324 lines
9.0 KiB
C
/*
|
|
* QTest testcase for VirtIO NIC
|
|
*
|
|
* Copyright (c) 2014 SUSE LINUX Products GmbH
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "libqtest.h"
|
|
#include "qemu-common.h"
|
|
#include "qemu/sockets.h"
|
|
#include "qemu/iov.h"
|
|
#include "libqos/libqos-pc.h"
|
|
#include "libqos/libqos-spapr.h"
|
|
#include "libqos/virtio.h"
|
|
#include "libqos/virtio-pci.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "qemu/bswap.h"
|
|
#include "hw/virtio/virtio-net.h"
|
|
#include "standard-headers/linux/virtio_ids.h"
|
|
#include "standard-headers/linux/virtio_ring.h"
|
|
|
|
#define PCI_SLOT_HP 0x06
|
|
#define PCI_SLOT 0x04
|
|
|
|
#define QVIRTIO_NET_TIMEOUT_US (30 * 1000 * 1000)
|
|
#define VNET_HDR_SIZE sizeof(struct virtio_net_hdr_mrg_rxbuf)
|
|
|
|
static void test_end(void)
|
|
{
|
|
qtest_end();
|
|
}
|
|
|
|
#ifndef _WIN32
|
|
|
|
static QVirtioPCIDevice *virtio_net_pci_init(QPCIBus *bus, int slot)
|
|
{
|
|
QVirtioPCIDevice *dev;
|
|
|
|
dev = qvirtio_pci_device_find(bus, VIRTIO_ID_NET);
|
|
g_assert(dev != NULL);
|
|
g_assert_cmphex(dev->vdev.device_type, ==, VIRTIO_ID_NET);
|
|
|
|
qvirtio_pci_device_enable(dev);
|
|
qvirtio_reset(&dev->vdev);
|
|
qvirtio_set_acknowledge(&dev->vdev);
|
|
qvirtio_set_driver(&dev->vdev);
|
|
|
|
return dev;
|
|
}
|
|
|
|
GCC_FMT_ATTR(1, 2)
|
|
static QOSState *pci_test_start(const char *cmd, ...)
|
|
{
|
|
QOSState *qs;
|
|
va_list ap;
|
|
const char *arch = qtest_get_arch();
|
|
|
|
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
|
|
va_start(ap, cmd);
|
|
qs = qtest_pc_vboot(cmd, ap);
|
|
va_end(ap);
|
|
} else if (strcmp(arch, "ppc64") == 0) {
|
|
va_start(ap, cmd);
|
|
qs = qtest_spapr_vboot(cmd, ap);
|
|
va_end(ap);
|
|
} else {
|
|
g_printerr("virtio-net tests are only available on x86 or ppc64\n");
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
global_qtest = qs->qts;
|
|
return qs;
|
|
}
|
|
|
|
static void driver_init(QVirtioDevice *dev)
|
|
{
|
|
uint32_t features;
|
|
|
|
features = qvirtio_get_features(dev);
|
|
features = features & ~(QVIRTIO_F_BAD_FEATURE |
|
|
(1u << VIRTIO_RING_F_INDIRECT_DESC) |
|
|
(1u << VIRTIO_RING_F_EVENT_IDX));
|
|
qvirtio_set_features(dev, features);
|
|
|
|
qvirtio_set_driver_ok(dev);
|
|
}
|
|
|
|
static void rx_test(QVirtioDevice *dev,
|
|
QGuestAllocator *alloc, QVirtQueue *vq,
|
|
int socket)
|
|
{
|
|
uint64_t req_addr;
|
|
uint32_t free_head;
|
|
char test[] = "TEST";
|
|
char buffer[64];
|
|
int len = htonl(sizeof(test));
|
|
struct iovec iov[] = {
|
|
{
|
|
.iov_base = &len,
|
|
.iov_len = sizeof(len),
|
|
}, {
|
|
.iov_base = test,
|
|
.iov_len = sizeof(test),
|
|
},
|
|
};
|
|
int ret;
|
|
|
|
req_addr = guest_alloc(alloc, 64);
|
|
|
|
free_head = qvirtqueue_add(vq, req_addr, 64, true, false);
|
|
qvirtqueue_kick(dev, vq, free_head);
|
|
|
|
ret = iov_send(socket, iov, 2, 0, sizeof(len) + sizeof(test));
|
|
g_assert_cmpint(ret, ==, sizeof(test) + sizeof(len));
|
|
|
|
qvirtio_wait_used_elem(dev, vq, free_head, NULL, QVIRTIO_NET_TIMEOUT_US);
|
|
memread(req_addr + VNET_HDR_SIZE, buffer, sizeof(test));
|
|
g_assert_cmpstr(buffer, ==, "TEST");
|
|
|
|
guest_free(alloc, req_addr);
|
|
}
|
|
|
|
static void tx_test(QVirtioDevice *dev,
|
|
QGuestAllocator *alloc, QVirtQueue *vq,
|
|
int socket)
|
|
{
|
|
uint64_t req_addr;
|
|
uint32_t free_head;
|
|
uint32_t len;
|
|
char buffer[64];
|
|
int ret;
|
|
|
|
req_addr = guest_alloc(alloc, 64);
|
|
memwrite(req_addr + VNET_HDR_SIZE, "TEST", 4);
|
|
|
|
free_head = qvirtqueue_add(vq, req_addr, 64, false, false);
|
|
qvirtqueue_kick(dev, vq, free_head);
|
|
|
|
qvirtio_wait_used_elem(dev, vq, free_head, NULL, QVIRTIO_NET_TIMEOUT_US);
|
|
guest_free(alloc, req_addr);
|
|
|
|
ret = qemu_recv(socket, &len, sizeof(len), 0);
|
|
g_assert_cmpint(ret, ==, sizeof(len));
|
|
len = ntohl(len);
|
|
|
|
ret = qemu_recv(socket, buffer, len, 0);
|
|
g_assert_cmpstr(buffer, ==, "TEST");
|
|
}
|
|
|
|
static void rx_stop_cont_test(QVirtioDevice *dev,
|
|
QGuestAllocator *alloc, QVirtQueue *vq,
|
|
int socket)
|
|
{
|
|
uint64_t req_addr;
|
|
uint32_t free_head;
|
|
char test[] = "TEST";
|
|
char buffer[64];
|
|
int len = htonl(sizeof(test));
|
|
QDict *rsp;
|
|
struct iovec iov[] = {
|
|
{
|
|
.iov_base = &len,
|
|
.iov_len = sizeof(len),
|
|
}, {
|
|
.iov_base = test,
|
|
.iov_len = sizeof(test),
|
|
},
|
|
};
|
|
int ret;
|
|
|
|
req_addr = guest_alloc(alloc, 64);
|
|
|
|
free_head = qvirtqueue_add(vq, req_addr, 64, true, false);
|
|
qvirtqueue_kick(dev, vq, free_head);
|
|
|
|
rsp = qmp("{ 'execute' : 'stop'}");
|
|
qobject_unref(rsp);
|
|
|
|
ret = iov_send(socket, iov, 2, 0, sizeof(len) + sizeof(test));
|
|
g_assert_cmpint(ret, ==, sizeof(test) + sizeof(len));
|
|
|
|
/* We could check the status, but this command is more importantly to
|
|
* ensure the packet data gets queued in QEMU, before we do 'cont'.
|
|
*/
|
|
rsp = qmp("{ 'execute' : 'query-status'}");
|
|
qobject_unref(rsp);
|
|
rsp = qmp("{ 'execute' : 'cont'}");
|
|
qobject_unref(rsp);
|
|
|
|
qvirtio_wait_used_elem(dev, vq, free_head, NULL, QVIRTIO_NET_TIMEOUT_US);
|
|
memread(req_addr + VNET_HDR_SIZE, buffer, sizeof(test));
|
|
g_assert_cmpstr(buffer, ==, "TEST");
|
|
|
|
guest_free(alloc, req_addr);
|
|
}
|
|
|
|
static void send_recv_test(QVirtioDevice *dev,
|
|
QGuestAllocator *alloc, QVirtQueue *rvq,
|
|
QVirtQueue *tvq, int socket)
|
|
{
|
|
rx_test(dev, alloc, rvq, socket);
|
|
tx_test(dev, alloc, tvq, socket);
|
|
}
|
|
|
|
static void stop_cont_test(QVirtioDevice *dev,
|
|
QGuestAllocator *alloc, QVirtQueue *rvq,
|
|
QVirtQueue *tvq, int socket)
|
|
{
|
|
rx_stop_cont_test(dev, alloc, rvq, socket);
|
|
}
|
|
|
|
static void pci_basic(gconstpointer data)
|
|
{
|
|
QVirtioPCIDevice *dev;
|
|
QOSState *qs;
|
|
QVirtQueuePCI *tx, *rx;
|
|
void (*func) (QVirtioDevice *dev,
|
|
QGuestAllocator *alloc,
|
|
QVirtQueue *rvq,
|
|
QVirtQueue *tvq,
|
|
int socket) = data;
|
|
int sv[2], ret;
|
|
|
|
ret = socketpair(PF_UNIX, SOCK_STREAM, 0, sv);
|
|
g_assert_cmpint(ret, !=, -1);
|
|
|
|
qs = pci_test_start("-netdev socket,fd=%d,id=hs0 -device "
|
|
"virtio-net-pci,netdev=hs0", sv[1]);
|
|
dev = virtio_net_pci_init(qs->pcibus, PCI_SLOT);
|
|
|
|
rx = (QVirtQueuePCI *)qvirtqueue_setup(&dev->vdev, qs->alloc, 0);
|
|
tx = (QVirtQueuePCI *)qvirtqueue_setup(&dev->vdev, qs->alloc, 1);
|
|
|
|
driver_init(&dev->vdev);
|
|
func(&dev->vdev, qs->alloc, &rx->vq, &tx->vq, sv[0]);
|
|
|
|
/* End test */
|
|
close(sv[0]);
|
|
qvirtqueue_cleanup(dev->vdev.bus, &tx->vq, qs->alloc);
|
|
qvirtqueue_cleanup(dev->vdev.bus, &rx->vq, qs->alloc);
|
|
qvirtio_pci_device_disable(dev);
|
|
g_free(dev->pdev);
|
|
g_free(dev);
|
|
qtest_shutdown(qs);
|
|
}
|
|
|
|
static void large_tx(gconstpointer data)
|
|
{
|
|
QVirtioPCIDevice *dev;
|
|
QOSState *qs;
|
|
QVirtQueuePCI *tx, *rx;
|
|
QVirtQueue *vq;
|
|
uint64_t req_addr;
|
|
uint32_t free_head;
|
|
size_t alloc_size = (size_t)data / 64;
|
|
int i;
|
|
|
|
qs = pci_test_start("-netdev hubport,id=hp0,hubid=0 "
|
|
"-device virtio-net-pci,netdev=hp0");
|
|
dev = virtio_net_pci_init(qs->pcibus, PCI_SLOT);
|
|
|
|
rx = (QVirtQueuePCI *)qvirtqueue_setup(&dev->vdev, qs->alloc, 0);
|
|
tx = (QVirtQueuePCI *)qvirtqueue_setup(&dev->vdev, qs->alloc, 1);
|
|
|
|
driver_init(&dev->vdev);
|
|
vq = &tx->vq;
|
|
|
|
/* Bypass the limitation by pointing several descriptors to a single
|
|
* smaller area */
|
|
req_addr = guest_alloc(qs->alloc, alloc_size);
|
|
free_head = qvirtqueue_add(vq, req_addr, alloc_size, false, true);
|
|
|
|
for (i = 0; i < 64; i++) {
|
|
qvirtqueue_add(vq, req_addr, alloc_size, false, i != 63);
|
|
}
|
|
qvirtqueue_kick(&dev->vdev, vq, free_head);
|
|
|
|
qvirtio_wait_used_elem(&dev->vdev, vq, free_head, NULL,
|
|
QVIRTIO_NET_TIMEOUT_US);
|
|
|
|
qvirtqueue_cleanup(dev->vdev.bus, &tx->vq, qs->alloc);
|
|
qvirtqueue_cleanup(dev->vdev.bus, &rx->vq, qs->alloc);
|
|
qvirtio_pci_device_disable(dev);
|
|
g_free(dev->pdev);
|
|
g_free(dev);
|
|
qtest_shutdown(qs);
|
|
}
|
|
#endif
|
|
|
|
static void hotplug(void)
|
|
{
|
|
const char *arch = qtest_get_arch();
|
|
|
|
qtest_start("-device virtio-net-pci");
|
|
|
|
qtest_qmp_device_add("virtio-net-pci", "net1",
|
|
"{'addr': %s}", stringify(PCI_SLOT_HP));
|
|
|
|
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
|
|
qpci_unplug_acpi_device_test("net1", PCI_SLOT_HP);
|
|
}
|
|
|
|
test_end();
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
g_test_init(&argc, &argv, NULL);
|
|
#ifndef _WIN32
|
|
qtest_add_data_func("/virtio/net/pci/basic", send_recv_test, pci_basic);
|
|
qtest_add_data_func("/virtio/net/pci/rx_stop_cont",
|
|
stop_cont_test, pci_basic);
|
|
qtest_add_data_func("/virtio/net/pci/large_tx_uint_max",
|
|
(gconstpointer)UINT_MAX, large_tx);
|
|
qtest_add_data_func("/virtio/net/pci/large_tx_net_bufsize",
|
|
(gconstpointer)NET_BUFSIZE, large_tx);
|
|
#endif
|
|
qtest_add_func("/virtio/net/pci/hotplug", hotplug);
|
|
|
|
return g_test_run();
|
|
}
|