qemu-e2k/include/qapi
Markus Armbruster 4b5766488f error: Fix use of error_prepend() with &error_fatal, &error_abort
From include/qapi/error.h:

  * Pass an existing error to the caller with the message modified:
  *     error_propagate(errp, err);
  *     error_prepend(errp, "Could not frobnicate '%s': ", name);

Fei Li pointed out that doing error_propagate() first doesn't work
well when @errp is &error_fatal or &error_abort: the error_prepend()
is never reached.

Since I doubt fixing the documentation will stop people from getting
it wrong, introduce error_propagate_prepend(), in the hope that it
lures people away from using its constituents in the wrong order.
Update the instructions in error.h accordingly.

Convert existing error_prepend() next to error_propagate to
error_propagate_prepend().  If any of these get reached with
&error_fatal or &error_abort, the error messages improve.  I didn't
check whether that's the case anywhere.

Cc: Fei Li <fli@suse.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20181017082702.5581-2-armbru@redhat.com>
2018-10-19 14:51:34 +02:00
..
qmp scripts: Remove check-qerror.sh 2018-10-19 14:40:15 +02:00
clone-visitor.h Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
dealloc-visitor.h include: Fix typos found by codespell 2017-01-24 23:26:52 +03:00
error.h error: Fix use of error_prepend() with &error_fatal, &error_abort 2018-10-19 14:51:34 +02:00
opts-visitor.h Move include qemu/option.h from qemu-common.h to actual users 2018-02-09 13:52:16 +01:00
qmp-event.h qapi: Drop qapi_event_send_FOO()'s Error ** argument 2018-08-28 18:21:38 +02:00
qobject-input-visitor.h Include qapi/qmp/qobject.h exactly where needed 2018-02-09 13:52:15 +01:00
qobject-output-visitor.h Include qapi/qmp/qobject.h exactly where needed 2018-02-09 13:52:15 +01:00
string-input-visitor.h string-input-visitor: Favor new visit_free() function 2016-07-06 10:52:04 +02:00
string-output-visitor.h qapi: Add new visit_complete() function 2016-07-06 10:52:04 +02:00
util.h qapi: Change data type of the FOO_lookup generated for enum FOO 2017-09-04 13:09:13 +02:00
visitor-impl.h qapi: Use QNull for a more regular visit_type_null() 2017-07-24 13:35:11 +02:00
visitor.h qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-02 13:45:57 -06:00