8bdab83b34
When COLO use only one vnet_hdr_support parameter between filter-redirector and filter-mirror(or colo-compare), COLO will crash with segmentation fault. Back track as follow: Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x0000555555cb200b in eth_get_l2_hdr_length (p=0x0) at /home/tao/project/COLO/colo-qemu/include/net/eth.h:296 296 uint16_t proto = be16_to_cpu(PKT_GET_ETH_HDR(p)->h_proto); (gdb) bt 0 0x0000555555cb200b in eth_get_l2_hdr_length (p=0x0) at /home/tao/project/COLO/colo-qemu/include/net/eth.h:296 1 0x0000555555cb22b4 in parse_packet_early (pkt=0x555556a44840) at net/colo.c:49 2 0x0000555555cb2b91 in is_tcp_packet (pkt=0x555556a44840) at net/filter-rewriter.c:63 So wrong vnet_hdr_len will cause pkt->data become NULL. Add check to raise error and add trace-events to track vnet_hdr_len. Signed-off-by: Tao Xu <tao3.xu@intel.com> Signed-off-by: Zhang Chen <chen.zhang@intel.com> Reviewed-by: Li Zhijian <lizhijian@fujitsu.com> Signed-off-by: Jason Wang <jasowang@redhat.com> |
||
---|---|---|
.. | ||
can | ||
announce.c | ||
checksum.c | ||
clients.h | ||
colo-compare.c | ||
colo-compare.h | ||
colo.c | ||
colo.h | ||
dump.c | ||
eth.c | ||
filter-buffer.c | ||
filter-mirror.c | ||
filter-replay.c | ||
filter-rewriter.c | ||
filter.c | ||
hub.c | ||
hub.h | ||
l2tpv3.c | ||
meson.build | ||
net.c | ||
netmap.c | ||
queue.c | ||
slirp.c | ||
socket.c | ||
tap_int.h | ||
tap-bsd.c | ||
tap-linux.c | ||
tap-linux.h | ||
tap-solaris.c | ||
tap-stub.c | ||
tap-win32.c | ||
tap.c | ||
trace-events | ||
trace.h | ||
util.c | ||
util.h | ||
vde.c | ||
vhost-user-stub.c | ||
vhost-user.c | ||
vhost-vdpa-stub.c | ||
vhost-vdpa.c | ||
vmnet_int.h | ||
vmnet-bridged.m | ||
vmnet-common.m | ||
vmnet-host.c | ||
vmnet-shared.c |