12ac6d3db7
qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation would prevent feature table entries for bits 32-63 from being used, and it could assign errp multiple times if there was more than one unknown feature, resulting in an error_set() assertion failure. Fix the truncation, make sure to set the error exactly once and add a qemu-iotests case for it. This fixes https://bugs.launchpad.net/qemu/+bug/1342704/ Reported-by: Maria Kustova <maria.k@catit.be> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
88 lines
3.5 KiB
Plaintext
88 lines
3.5 KiB
Plaintext
QA output created by 036
|
|
|
|
=== Image with unknown incompatible feature bit ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
magic 0x514649fb
|
|
version 3
|
|
backing_file_offset 0x0
|
|
backing_file_size 0x0
|
|
cluster_bits 16
|
|
size 67108864
|
|
crypt_method 0
|
|
l1_size 1
|
|
l1_table_offset 0x30000
|
|
refcount_table_offset 0x10000
|
|
refcount_table_clusters 1
|
|
nb_snapshots 0
|
|
snapshot_offset 0x0
|
|
incompatible_features 0x8000000000000000
|
|
compatible_features 0x0
|
|
autoclear_features 0x0
|
|
refcount_order 4
|
|
header_length 104
|
|
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: Unknown incompatible feature: 8000000000000000
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: Test feature
|
|
|
|
=== Image with multiple incompatible feature bits ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: Unknown incompatible feature: e000000000000000
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: Test feature, Unknown incompatible feature: 6000000000000000
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: Test feature, Unknown incompatible feature: c000000000000000
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: test1, test2, Unknown incompatible feature: 8000000000000000
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: test1, test2, test3
|
|
qemu-img: Could not open 'TEST_DIR/t.IMGFMT': 'image' uses a IMGFMT feature which is not supported by this qemu version: test2, Unknown incompatible feature: a000000000000000
|
|
=== Create image with unknown autoclear feature bit ===
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
magic 0x514649fb
|
|
version 3
|
|
backing_file_offset 0x0
|
|
backing_file_size 0x0
|
|
cluster_bits 16
|
|
size 67108864
|
|
crypt_method 0
|
|
l1_size 1
|
|
l1_table_offset 0x30000
|
|
refcount_table_offset 0x10000
|
|
refcount_table_clusters 1
|
|
nb_snapshots 0
|
|
snapshot_offset 0x0
|
|
incompatible_features 0x0
|
|
compatible_features 0x0
|
|
autoclear_features 0x8000000000000000
|
|
refcount_order 4
|
|
header_length 104
|
|
|
|
|
|
=== Repair image ===
|
|
|
|
No errors were found on the image.
|
|
magic 0x514649fb
|
|
version 3
|
|
backing_file_offset 0x0
|
|
backing_file_size 0x0
|
|
cluster_bits 16
|
|
size 67108864
|
|
crypt_method 0
|
|
l1_size 1
|
|
l1_table_offset 0x30000
|
|
refcount_table_offset 0x10000
|
|
refcount_table_clusters 1
|
|
nb_snapshots 0
|
|
snapshot_offset 0x0
|
|
incompatible_features 0x0
|
|
compatible_features 0x0
|
|
autoclear_features 0x0
|
|
refcount_order 4
|
|
header_length 104
|
|
|
|
Header extension:
|
|
magic 0x6803f857
|
|
length 144
|
|
data <binary>
|
|
|
|
*** done
|