984c367814
We should check whether the user-specified node-name actually refers to
a node. The simplest way to do that is to use bdrv_lookup_bs() instead
of bdrv_find_node() (the former wraps the latter, and produces an error
message if necessary).
Reported-by: Coverity (CID 1430268)
Fixes: ced914d0ab
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200710095037.10885-1-mreitz@redhat.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
118 lines
3.7 KiB
C
118 lines
3.7 KiB
C
/*
|
|
* Block layer code related to image options amend
|
|
*
|
|
* Copyright (c) 2018 Kevin Wolf <kwolf@redhat.com>
|
|
* Copyright (c) 2020 Red Hat. Inc
|
|
*
|
|
* Heavily based on create.c
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "block/block_int.h"
|
|
#include "qemu/job.h"
|
|
#include "qemu/main-loop.h"
|
|
#include "qapi/qapi-commands-block-core.h"
|
|
#include "qapi/qapi-visit-block-core.h"
|
|
#include "qapi/clone-visitor.h"
|
|
#include "qapi/error.h"
|
|
|
|
typedef struct BlockdevAmendJob {
|
|
Job common;
|
|
BlockdevAmendOptions *opts;
|
|
BlockDriverState *bs;
|
|
bool force;
|
|
} BlockdevAmendJob;
|
|
|
|
static int coroutine_fn blockdev_amend_run(Job *job, Error **errp)
|
|
{
|
|
BlockdevAmendJob *s = container_of(job, BlockdevAmendJob, common);
|
|
int ret;
|
|
|
|
job_progress_set_remaining(&s->common, 1);
|
|
ret = s->bs->drv->bdrv_co_amend(s->bs, s->opts, s->force, errp);
|
|
job_progress_update(&s->common, 1);
|
|
qapi_free_BlockdevAmendOptions(s->opts);
|
|
return ret;
|
|
}
|
|
|
|
static const JobDriver blockdev_amend_job_driver = {
|
|
.instance_size = sizeof(BlockdevAmendJob),
|
|
.job_type = JOB_TYPE_AMEND,
|
|
.run = blockdev_amend_run,
|
|
};
|
|
|
|
void qmp_x_blockdev_amend(const char *job_id,
|
|
const char *node_name,
|
|
BlockdevAmendOptions *options,
|
|
bool has_force,
|
|
bool force,
|
|
Error **errp)
|
|
{
|
|
BlockdevAmendJob *s;
|
|
const char *fmt = BlockdevDriver_str(options->driver);
|
|
BlockDriver *drv = bdrv_find_format(fmt);
|
|
BlockDriverState *bs;
|
|
|
|
bs = bdrv_lookup_bs(NULL, node_name, errp);
|
|
if (!bs) {
|
|
return;
|
|
}
|
|
|
|
if (!drv) {
|
|
error_setg(errp, "Block driver '%s' not found or not supported", fmt);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* If the driver is in the schema, we know that it exists. But it may not
|
|
* be whitelisted.
|
|
*/
|
|
if (bdrv_uses_whitelist() && !bdrv_is_whitelisted(drv, false)) {
|
|
error_setg(errp, "Driver is not whitelisted");
|
|
return;
|
|
}
|
|
|
|
if (bs->drv != drv) {
|
|
error_setg(errp,
|
|
"x-blockdev-amend doesn't support changing the block driver");
|
|
return;
|
|
}
|
|
|
|
/* Error out if the driver doesn't support .bdrv_co_amend */
|
|
if (!drv->bdrv_co_amend) {
|
|
error_setg(errp, "Driver does not support x-blockdev-amend");
|
|
return;
|
|
}
|
|
|
|
/* Create the block job */
|
|
s = job_create(job_id, &blockdev_amend_job_driver, NULL,
|
|
bdrv_get_aio_context(bs), JOB_DEFAULT | JOB_MANUAL_DISMISS,
|
|
NULL, NULL, errp);
|
|
if (!s) {
|
|
return;
|
|
}
|
|
|
|
s->bs = bs,
|
|
s->opts = QAPI_CLONE(BlockdevAmendOptions, options),
|
|
s->force = has_force ? force : false;
|
|
job_start(&s->common);
|
|
}
|