f6102c329c
The current code only works by chance. The event facility is a sysbus device, but specifies in its class structure as parent the DeviceClass (instead of a device class). The init function in return lies therefore at the same position as the init function of SysBusDeviceClass and gets triggered instead - a very bad idea of doing that (e.g. the parameter types don't match). Let's bring the initialization code up to date, initializing the event facility + child events in .instance_init and moving the realization of the child events out of the init call, into the realization step. Device realization is now automatically performed when the event facility itself is realized. That realization implicitly triggers realization of the child bus, which in turn initializes the events. Please note that we have to manually propagate the realization of the bus children, common code still has a TODO set for that task. Reviewed-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com> Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> |
||
|---|---|---|
| .. | ||
| css.c | ||
| css.h | ||
| event-facility.c | ||
| ipl.c | ||
| ipl.h | ||
| Makefile.objs | ||
| s390-pci-bus.c | ||
| s390-pci-bus.h | ||
| s390-pci-inst.c | ||
| s390-pci-inst.h | ||
| s390-skeys-kvm.c | ||
| s390-skeys.c | ||
| s390-virtio-bus.c | ||
| s390-virtio-bus.h | ||
| s390-virtio-ccw.c | ||
| s390-virtio-hcall.c | ||
| s390-virtio.c | ||
| s390-virtio.h | ||
| sclp.c | ||
| sclpcpu.c | ||
| sclpquiesce.c | ||
| virtio-ccw.c | ||
| virtio-ccw.h | ||