Peter Maydell 426eeecdf5 cpu-exec: Exit exclusive region on longjmp from step_atomic ... Commit ac03ee5331 narrowed the scope of the exclusive region so it only covers when we're executing the TB, not when we're generating it. However it missed that there is more than one execution path out of cpu_tb_exec -- if the atomic insn causes an exception then the code will longjmp out, skipping the code to end the exclusive region. This causes QEMU to hang the next time the CPU calls start_exclusive(), waiting for itself to exit the region. Move the "end the region" code out to the end of the function so that it is run for both normal exit and also for exit-via-longjmp. We have to use a volatile bool flag to decide whether we need to end the region, because we can longjump out of the codegen as well as the execution. (For some reason this only reproduces for me with a clang optimized build, not a gcc debug build.) Reviewed-by: Emilio G. Cota <cota@braap.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Fixes: ac03ee5331 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <1509640536-32160-1-git-send-email-peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>		2017-11-03 09:34:21 +01:00
..
kvm	kvm: simplify kvm_align_section()	2017-10-18 10:15:00 +02:00
stubs	kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension()	2017-10-02 14:38:06 +02:00
tcg	cpu-exec: Exit exclusive region on longjmp from step_atomic	2017-11-03 09:34:21 +01:00
Makefile.objs	tcg: add the CONFIG_TCG into Makefiles	2017-07-05 09:12:44 +02:00
accel.c	accel: cleanup error output	2017-08-01 17:27:33 +02:00