a58cabd0e3
S390IPLState contains two IplParameterBlock, which may in turn have
either a IPLBlockPV or a IplBlockFcp, both ending with a variable
sized field (an array).
This causes a warning with clang 11 or greater, which checks that
variable sized type are only allocated at the end of the struct:
In file included from ../qemu-cfi-v3/target/s390x/diag.c:21:
../qemu-cfi-v3/hw/s390x/ipl.h:161:23: error: field 'iplb' with variable sized type 'IplParameterBlock' (aka 'union IplParameterBlock') not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
IplParameterBlock iplb;
^
../qemu-cfi-v3/hw/s390x/ipl.h:162:23: error: field 'iplb_pv' with variable sized type 'IplParameterBlock' (aka 'union IplParameterBlock') not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
IplParameterBlock iplb_pv;
In this case, however, the warning is a false positive, because
IPLBlockPV and IplBlockFcp are allocated in a union wrapped at 4K,
making the union non-variable sized.
Fix the warning by turning the two variable sized arrays into arrays
of size 0. This avoids the compiler error and should produce the
same code.
Signed-off-by: Daniele Buono <dbuono@linux.vnet.ibm.com>
Message-Id: <20201105221905.1350-5-dbuono@linux.vnet.ibm.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
290 lines
7.7 KiB
C
290 lines
7.7 KiB
C
/*
|
|
* s390 IPL device
|
|
*
|
|
* Copyright 2015, 2020 IBM Corp.
|
|
* Author(s): Zhang Fan <bjfanzh@cn.ibm.com>
|
|
* Janosch Frank <frankja@linux.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or (at
|
|
* your option) any later version. See the COPYING file in the top-level
|
|
* directory.
|
|
*/
|
|
|
|
#ifndef HW_S390_IPL_H
|
|
#define HW_S390_IPL_H
|
|
|
|
#include "cpu.h"
|
|
#include "exec/address-spaces.h"
|
|
#include "hw/qdev-core.h"
|
|
#include "qom/object.h"
|
|
|
|
struct IPLBlockPVComp {
|
|
uint64_t tweak_pref;
|
|
uint64_t addr;
|
|
uint64_t size;
|
|
} QEMU_PACKED;
|
|
typedef struct IPLBlockPVComp IPLBlockPVComp;
|
|
|
|
struct IPLBlockPV {
|
|
uint8_t reserved18[87]; /* 0x18 */
|
|
uint8_t version; /* 0x6f */
|
|
uint32_t reserved70; /* 0x70 */
|
|
uint32_t num_comp; /* 0x74 */
|
|
uint64_t pv_header_addr; /* 0x78 */
|
|
uint64_t pv_header_len; /* 0x80 */
|
|
struct IPLBlockPVComp components[0];
|
|
} QEMU_PACKED;
|
|
typedef struct IPLBlockPV IPLBlockPV;
|
|
|
|
struct IplBlockCcw {
|
|
uint8_t reserved0[85];
|
|
uint8_t ssid;
|
|
uint16_t devno;
|
|
uint8_t vm_flags;
|
|
uint8_t reserved3[3];
|
|
uint32_t vm_parm_len;
|
|
uint8_t nss_name[8];
|
|
uint8_t vm_parm[64];
|
|
uint8_t reserved4[8];
|
|
} QEMU_PACKED;
|
|
typedef struct IplBlockCcw IplBlockCcw;
|
|
|
|
struct IplBlockFcp {
|
|
uint8_t reserved1[305 - 1];
|
|
uint8_t opt;
|
|
uint8_t reserved2[3];
|
|
uint16_t reserved3;
|
|
uint16_t devno;
|
|
uint8_t reserved4[4];
|
|
uint64_t wwpn;
|
|
uint64_t lun;
|
|
uint32_t bootprog;
|
|
uint8_t reserved5[12];
|
|
uint64_t br_lba;
|
|
uint32_t scp_data_len;
|
|
uint8_t reserved6[260];
|
|
uint8_t scp_data[0];
|
|
} QEMU_PACKED;
|
|
typedef struct IplBlockFcp IplBlockFcp;
|
|
|
|
struct IplBlockQemuScsi {
|
|
uint32_t lun;
|
|
uint16_t target;
|
|
uint16_t channel;
|
|
uint8_t reserved0[77];
|
|
uint8_t ssid;
|
|
uint16_t devno;
|
|
} QEMU_PACKED;
|
|
typedef struct IplBlockQemuScsi IplBlockQemuScsi;
|
|
|
|
#define DIAG308_FLAGS_LP_VALID 0x80
|
|
|
|
union IplParameterBlock {
|
|
struct {
|
|
uint32_t len;
|
|
uint8_t reserved0[3];
|
|
uint8_t version;
|
|
uint32_t blk0_len;
|
|
uint8_t pbt;
|
|
uint8_t flags;
|
|
uint16_t reserved01;
|
|
uint8_t loadparm[8];
|
|
union {
|
|
IplBlockCcw ccw;
|
|
IplBlockFcp fcp;
|
|
IPLBlockPV pv;
|
|
IplBlockQemuScsi scsi;
|
|
};
|
|
} QEMU_PACKED;
|
|
struct {
|
|
uint8_t reserved1[110];
|
|
uint16_t devno;
|
|
uint8_t reserved2[88];
|
|
uint8_t reserved_ext[4096 - 200];
|
|
} QEMU_PACKED;
|
|
} QEMU_PACKED;
|
|
typedef union IplParameterBlock IplParameterBlock;
|
|
|
|
int s390_ipl_set_loadparm(uint8_t *loadparm);
|
|
void s390_ipl_update_diag308(IplParameterBlock *iplb);
|
|
int s390_ipl_prepare_pv_header(void);
|
|
int s390_ipl_pv_unpack(void);
|
|
void s390_ipl_prepare_cpu(S390CPU *cpu);
|
|
IplParameterBlock *s390_ipl_get_iplb(void);
|
|
IplParameterBlock *s390_ipl_get_iplb_pv(void);
|
|
|
|
enum s390_reset {
|
|
/* default is a reset not triggered by a CPU e.g. issued by QMP */
|
|
S390_RESET_EXTERNAL = 0,
|
|
S390_RESET_REIPL,
|
|
S390_RESET_MODIFIED_CLEAR,
|
|
S390_RESET_LOAD_NORMAL,
|
|
S390_RESET_PV,
|
|
};
|
|
void s390_ipl_reset_request(CPUState *cs, enum s390_reset reset_type);
|
|
void s390_ipl_get_reset_request(CPUState **cs, enum s390_reset *reset_type);
|
|
void s390_ipl_clear_reset_request(void);
|
|
|
|
#define QIPL_ADDRESS 0xcc
|
|
|
|
/* Boot Menu flags */
|
|
#define QIPL_FLAG_BM_OPTS_CMD 0x80
|
|
#define QIPL_FLAG_BM_OPTS_ZIPL 0x40
|
|
|
|
/*
|
|
* The QEMU IPL Parameters will be stored at absolute address
|
|
* 204 (0xcc) which means it is 32-bit word aligned but not
|
|
* double-word aligned.
|
|
* Placement of data fields in this area must account for
|
|
* their alignment needs. E.g., netboot_start_address must
|
|
* have an offset of 4 + n * 8 bytes within the struct in order
|
|
* to keep it double-word aligned.
|
|
* The total size of the struct must never exceed 28 bytes.
|
|
* This definition must be kept in sync with the defininition
|
|
* in pc-bios/s390-ccw/iplb.h.
|
|
*/
|
|
struct QemuIplParameters {
|
|
uint8_t qipl_flags;
|
|
uint8_t reserved1[3];
|
|
uint64_t netboot_start_addr;
|
|
uint32_t boot_menu_timeout;
|
|
uint8_t reserved2[12];
|
|
} QEMU_PACKED;
|
|
typedef struct QemuIplParameters QemuIplParameters;
|
|
|
|
#define TYPE_S390_IPL "s390-ipl"
|
|
OBJECT_DECLARE_SIMPLE_TYPE(S390IPLState, S390_IPL)
|
|
|
|
struct S390IPLState {
|
|
/*< private >*/
|
|
DeviceState parent_obj;
|
|
IplParameterBlock iplb;
|
|
IplParameterBlock iplb_pv;
|
|
QemuIplParameters qipl;
|
|
uint64_t start_addr;
|
|
uint64_t compat_start_addr;
|
|
uint64_t bios_start_addr;
|
|
uint64_t compat_bios_start_addr;
|
|
bool enforce_bios;
|
|
bool iplb_valid;
|
|
bool iplb_valid_pv;
|
|
bool netboot;
|
|
/* reset related properties don't have to be migrated or reset */
|
|
enum s390_reset reset_type;
|
|
int reset_cpu_index;
|
|
|
|
/*< public >*/
|
|
char *kernel;
|
|
char *initrd;
|
|
char *cmdline;
|
|
char *firmware;
|
|
char *netboot_fw;
|
|
uint8_t cssid;
|
|
uint8_t ssid;
|
|
uint16_t devno;
|
|
bool iplbext_migration;
|
|
};
|
|
QEMU_BUILD_BUG_MSG(offsetof(S390IPLState, iplb) & 3, "alignment of iplb wrong");
|
|
|
|
#define DIAG_308_RC_OK 0x0001
|
|
#define DIAG_308_RC_NO_CONF 0x0102
|
|
#define DIAG_308_RC_INVALID 0x0402
|
|
#define DIAG_308_RC_NO_PV_CONF 0x0902
|
|
#define DIAG_308_RC_INVAL_FOR_PV 0x0a02
|
|
|
|
#define DIAG308_RESET_MOD_CLR 0
|
|
#define DIAG308_RESET_LOAD_NORM 1
|
|
#define DIAG308_LOAD_CLEAR 3
|
|
#define DIAG308_LOAD_NORMAL_DUMP 4
|
|
#define DIAG308_SET 5
|
|
#define DIAG308_STORE 6
|
|
#define DIAG308_PV_SET 8
|
|
#define DIAG308_PV_STORE 9
|
|
#define DIAG308_PV_START 10
|
|
|
|
#define S390_IPL_TYPE_FCP 0x00
|
|
#define S390_IPL_TYPE_CCW 0x02
|
|
#define S390_IPL_TYPE_PV 0x05
|
|
#define S390_IPL_TYPE_QEMU_SCSI 0xff
|
|
|
|
#define S390_IPLB_HEADER_LEN 8
|
|
#define S390_IPLB_MIN_PV_LEN 148
|
|
#define S390_IPLB_MIN_CCW_LEN 200
|
|
#define S390_IPLB_MIN_FCP_LEN 384
|
|
#define S390_IPLB_MIN_QEMU_SCSI_LEN 200
|
|
|
|
static inline bool iplb_valid_len(IplParameterBlock *iplb)
|
|
{
|
|
return be32_to_cpu(iplb->len) <= sizeof(IplParameterBlock);
|
|
}
|
|
|
|
static inline bool ipl_valid_pv_components(IplParameterBlock *iplb)
|
|
{
|
|
IPLBlockPV *ipib_pv = &iplb->pv;
|
|
int i;
|
|
|
|
if (ipib_pv->num_comp == 0) {
|
|
return false;
|
|
}
|
|
|
|
for (i = 0; i < ipib_pv->num_comp; i++) {
|
|
/* Addr must be 4k aligned */
|
|
if (ipib_pv->components[i].addr & ~TARGET_PAGE_MASK) {
|
|
return false;
|
|
}
|
|
|
|
/* Tweak prefix is monotonically increasing with each component */
|
|
if (i < ipib_pv->num_comp - 1 &&
|
|
ipib_pv->components[i].tweak_pref >=
|
|
ipib_pv->components[i + 1].tweak_pref) {
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static inline bool ipl_valid_pv_header(IplParameterBlock *iplb)
|
|
{
|
|
IPLBlockPV *ipib_pv = &iplb->pv;
|
|
|
|
if (ipib_pv->pv_header_len > 2 * TARGET_PAGE_SIZE) {
|
|
return false;
|
|
}
|
|
|
|
if (!address_space_access_valid(&address_space_memory,
|
|
ipib_pv->pv_header_addr,
|
|
ipib_pv->pv_header_len,
|
|
false,
|
|
MEMTXATTRS_UNSPECIFIED)) {
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
static inline bool iplb_valid_pv(IplParameterBlock *iplb)
|
|
{
|
|
if (iplb->pbt != S390_IPL_TYPE_PV ||
|
|
be32_to_cpu(iplb->len) < S390_IPLB_MIN_PV_LEN) {
|
|
return false;
|
|
}
|
|
if (!ipl_valid_pv_header(iplb)) {
|
|
return false;
|
|
}
|
|
return ipl_valid_pv_components(iplb);
|
|
}
|
|
|
|
static inline bool iplb_valid(IplParameterBlock *iplb)
|
|
{
|
|
switch (iplb->pbt) {
|
|
case S390_IPL_TYPE_FCP:
|
|
return be32_to_cpu(iplb->len) >= S390_IPLB_MIN_FCP_LEN;
|
|
case S390_IPL_TYPE_CCW:
|
|
return be32_to_cpu(iplb->len) >= S390_IPLB_MIN_CCW_LEN;
|
|
default:
|
|
return false;
|
|
}
|
|
}
|
|
|
|
#endif
|