OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity
ff52aab2df
qemu-e2k/block
History
Max Reitz ff52aab2df qcow2: Catch !*host_offset for data allocation 
qcow2_alloc_cluster_offset() uses host_offset == 0 as "no preferred
offset" for the (data) cluster range to be allocated. However, this
offset is actually valid and may be allocated on images with a corrupted
refcount table or first refcount block.

In this case, the corruption prevention should normally catch that
write anyway (because it would overwrite the image header). But since 0
is a special value here, the function assumes that nothing has been
allocated at all which it asserts against.

Because this condition is not qemu's fault but rather that of a broken
image, it shouldn't throw an assertion but rather mark the image corrupt
and show an appropriate message, which this patch does by calling the
corruption check earlier than it would be called normally (before the
assertion).

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-08-15 15:07:16 +02:00
..
archipelago.c block/archipelago: Add support for creating images 2014-08-15 15:07:14 +02:00
backup.c block/backup: Fix hang for unaligned image size 2014-07-09 15:50:11 +02:00
blkdebug.c blkdebug: use BlockDriverState's AioContext 2014-06-04 09:56:11 +02:00
blkverify.c blkverify: implement .bdrv_detach/attach_aio_context() 2014-06-04 09:56:11 +02:00
bochs.c bochs: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
cloop.c cloop: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
commit.c block: extend block-commit to accept a string for the backing file 2014-07-01 10:47:01 +02:00
cow.c block/cow: Avoid use of uninitialized cow_bs in error path 2014-07-01 10:15:34 +02:00
curl.c curl: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
dmg.c dmg: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
gluster.c cleanup QEMUOptionParameter 2014-06-16 17:23:21 +08:00
iscsi.c iscsi: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
linux-aio.c linux-aio: Fix laio resource leak 2014-07-15 15:34:13 +02:00
Makefile.objs block: Support Archipelago as a QEMU block backend 2014-08-15 15:07:14 +02:00
mirror.c mirror: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
nbd-client.c nbd: implement .bdrv_detach/attach_aio_context() 2014-06-04 09:56:11 +02:00
nbd-client.h nbd: implement .bdrv_detach/attach_aio_context() 2014-06-04 09:56:11 +02:00
nbd.c nbd: implement .bdrv_detach/attach_aio_context() 2014-06-04 09:56:11 +02:00
nfs.c nfs: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
parallels.c parallels: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qapi.c qemu-img info: show nocow info 2014-08-15 15:07:14 +02:00
qcow2-cache.c qcow2: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qcow2-cluster.c qcow2: Catch !*host_offset for data allocation 2014-08-15 15:07:16 +02:00
qcow2-refcount.c qcow2: Return useful error code in refcount_init() 2014-08-15 15:07:16 +02:00
qcow2-snapshot.c qcow2: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qcow2.c qcow2: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qcow2.h qcow2: Limit snapshot table size 2014-04-01 15:22:35 +02:00
qcow.c qcow1: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qed-check.c qed: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qed-cluster.c
qed-gencb.c
qed-l2-cache.c
qed-table.c qed: use BlockDriverState's AioContext 2014-06-04 09:56:11 +02:00
qed.c qed: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
qed.h qed: Make qiov match request size until backing file EOF 2014-07-14 12:03:20 +02:00
quorum.c quorum: Add the rewrite-corrupted parameter to quorum 2014-06-27 14:18:17 +02:00
raw_bsd.c block: Add Error argument to bdrv_refresh_limits() 2014-07-18 13:18:43 +01:00
raw-aio.h linux-aio: implement io plug, unplug and flush io queue 2014-07-07 11:05:17 +02:00
raw-posix.c raw-posix: Handle failure for potentially large allocations 2014-08-15 15:07:15 +02:00
raw-win32.c cleanup QEMUOptionParameter 2014-06-16 17:23:21 +08:00
rbd.c rbd: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
sheepdog.c sheepdog: fix NULL dereference in sd_create 2014-06-23 16:36:13 +08:00
snapshot.c Use error_is_set() only when necessary 2014-02-17 11:57:23 -05:00
ssh.c cleanup QEMUOptionParameter 2014-06-16 17:23:21 +08:00
stream.c block: Add Error argument to bdrv_refresh_limits() 2014-07-18 13:18:43 +01:00
vdi.c vdi: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
vhdx-endian.c block: VHDX endian fixes 2014-08-15 15:07:14 +02:00
vhdx-log.c vhdx: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
vhdx.c vhdx: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
vhdx.h block: VHDX endian fixes 2014-08-15 15:07:14 +02:00
vmdk.c vmdk: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
vpc.c vpc: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00
vvfat.c cleanup QEMUOptionParameter 2014-06-16 17:23:21 +08:00
win32-aio.c raw-win32: Handle failure for potentially large allocations 2014-08-15 15:07:16 +02:00